Skip to content

bin_to_octal - #2431

Merged
realDuYuanChao merged 7 commits into
TheAlgorithms:masterfrom
mohammadreza490:patch-6
Sep 19, 2020
Merged

bin_to_octal#2431
realDuYuanChao merged 7 commits into
TheAlgorithms:masterfrom
mohammadreza490:patch-6

Conversation

@mohammadreza490

@mohammadreza490mohammadreza490 commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

Converts binary values to the octal equivalent.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@mohammadreza490
bin_to_octal
7cf647f
Converts binary values to the octal equivalent.
@mohammadreza490
Update bin_to_octal
66830ad
cclauss
cclauss reviewed Sep 15, 2020
View reviewed changes
Comment threadconversions/bin_to_octal Outdated
@mohammadreza490@cclauss
Update conversions/bin_to_octal
cf48d72
Co-authored-by: Christian Clauss <cclauss@me.com>
realDuYuanChao
realDuYuanChao requested changes Sep 16, 2020
View reviewed changes

@realDuYuanChaorealDuYuanChao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you rename bin_to_octal to bin_to_octal.py

@mohammadreza490mohammadreza490 changed the title bin_to_octalbin_to_octal.pySep 16, 2020
@realDuYuanChao

realDuYuanChao commented Sep 16, 2020

Copy link
Copy Markdown
Member

My meaning is rename file bin_to_octal to bin_to_octal.py using below git command

git mv bin_to_octal bin_to_octal.py

realDuYuanChao
realDuYuanChao reviewed Sep 16, 2020
View reviewed changes
Comment threadconversions/bin_to_octal
Comment threadconversions/bin_to_octal
Comment threadconversions/bin_to_octal Outdated
Comment threadconversions/bin_to_octal Outdated
Comment threadconversions/bin_to_octal Outdated
mohammadreza490and others added 3 commits September 16, 2020 16:46
@mohammadreza490@realDuYuanChao
Update conversions/bin_to_octal
7e81026
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@mohammadreza490@realDuYuanChao
Update conversions/bin_to_octal
0e42dbb
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@mohammadreza490@realDuYuanChao
Update conversions/bin_to_octal
39c00ea
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@mohammadreza490mohammadreza490 changed the title bin_to_octal.pybin_to_octalSep 16, 2020
@mohammadreza490

mohammadreza490 commented Sep 16, 2020

Copy link
Copy Markdown
ContributorAuthor

My meaning is rename file bin_to_octal to bin_to_octal.py using below git command

git mv bin_to_octal bin_to_octal.py

Done

@realDuYuanChao
realDuYuanChao merged commit b22596c into TheAlgorithms:masterSep 19, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@mohammadreza490@cclauss
@realDuYuanChao@stokhos
bin_to_octal (TheAlgorithms#2431)
85a1a5b
* bin_to_octal
Converts binary values to the octal equivalent.
* Update bin_to_octal
* Update conversions/bin_to_octal
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update conversions/bin_to_octal
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
* Update conversions/bin_to_octal
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
* Update conversions/bin_to_octal
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
* Rename bin_to_octal to bin_to_octal.py
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realDuYuanChaorealDuYuanChaorealDuYuanChao approved these changes
@cclausscclaussAwaiting requested review from cclauss
+1 more reviewer
@Charlie-xnxxCharlie-xnxxCharlie-xnxx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohammadreza490@realDuYuanChao@cclauss@Charlie-xnxx