Skip to content

Created problem_97 in project euler - #2476

Merged
cclauss merged 8 commits into
TheAlgorithms:masterfrom
Kush1101:master
Sep 25, 2020
Merged

Created problem_97 in project euler#2476
cclauss merged 8 commits into
TheAlgorithms:masterfrom
Kush1101:master

Conversation

@Kush1101

@Kush1101Kush1101 commented Sep 25, 2020

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

realDuYuanChao
realDuYuanChao reviewed Sep 25, 2020
View reviewed changes
Comment threadproject_euler/problem_97/sol1.py Outdated
Comment threadproject_euler/problem_97/sol1.py Outdated
Comment threadproject_euler/problem_97/sol1.py Outdated
Comment threadproject_euler/problem_97/sol1.py Outdated
realDuYuanChao
realDuYuanChao reviewed Sep 25, 2020
View reviewed changes

@realDuYuanChaorealDuYuanChao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test more input

Comment threadproject_euler/problem_97/sol1.py Outdated
@TravisBuddy

TravisBuddy commented Sep 25, 2020

Copy link
Copy Markdown

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ff584e30-fee3-11ea-b444-3dcc0bd866ab

realDuYuanChao
realDuYuanChao reviewed Sep 25, 2020
View reviewed changes
Comment threadproject_euler/problem_97/sol1.py
dhruvmanila
dhruvmanila requested changes Sep 25, 2020
View reviewed changes
Comment threadproject_euler/problem_97/sol1.py Outdated
cclauss
cclauss reviewed Sep 25, 2020
View reviewed changes
Comment threadproject_euler/problem_97/sol1.py
@Kush1101@cclauss
Update project_euler/problem_97/sol1.py
e7814eb
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Sep 25, 2020
View reviewed changes
Comment threadproject_euler/problem_97/sol1.py Outdated
cclauss
cclauss requested changes Sep 25, 2020
View reviewed changes
Comment threadproject_euler/problem_97/sol1.py Outdated
cclauss
cclauss reviewed Sep 25, 2020
View reviewed changes
Comment threadproject_euler/problem_97/sol1.py Outdated
@Kush1101@cclauss
Update project_euler/problem_97/sol1.py
90e4ed2
Co-authored-by: Christian Clauss <cclauss@me.com>
@Kush1101

Kush1101 commented Sep 25, 2020

Copy link
Copy Markdown
MemberAuthor

@cclauss How did the Travis CI tests get so fast?

@cclauss
cclauss merged commit daa1b4d into TheAlgorithms:masterSep 25, 2020
@cclauss

cclauss commented Sep 25, 2020

Copy link
Copy Markdown
Member

How did the Travis CI tests get so fast?

@dhruvmanila did awesome work in #2463

@dhruvmanila

dhruvmanila commented Sep 25, 2020

Copy link
Copy Markdown
Member

Hey! Thanks 😁
You were a helping hand @cclauss

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101@cclauss@stokhos
Created problem_97 in project euler (TheAlgorithms#2476)
e1f1bbe
* Create __init__.py
* Add files via upload
* Update sol1.py
* Update sol1.py
* Update sol1.py
* Update project_euler/problem_97/sol1.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update sol1.py
* Update project_euler/problem_97/sol1.py
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realDuYuanChaorealDuYuanChaorealDuYuanChao left review comments
@dhruvmaniladhruvmaniladhruvmanila requested changes
@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kush1101@TravisBuddy@cclauss@dhruvmanila@realDuYuanChao