Skip to content

Fix imports for all namespace packages - #2506

Merged
cclauss merged 3 commits into
TheAlgorithms:masterfrom
dhruvmanila:patch-imports
Sep 28, 2020
Merged

Fix imports for all namespace packages#2506
cclauss merged 3 commits into
TheAlgorithms:masterfrom
dhruvmanila:patch-imports

Conversation

@dhruvmanila

@dhruvmaniladhruvmanila commented Sep 28, 2020

Copy link
Copy Markdown
Member

As mentioned in #2503

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy

TravisBuddy commented Sep 28, 2020

Copy link
Copy Markdown

Hey @dhruvmanila,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e4d88bf0-01b4-11eb-9be6-0d9634a5fbe7

@dhruvmanila

dhruvmanila commented Sep 28, 2020

Copy link
Copy Markdown
MemberAuthor

Ok, some of the doctest are failing due to the change of paths.
@cclauss Should I fix it?

@cclauss

cclauss commented Sep 28, 2020

Copy link
Copy Markdown
Member

Yes, please

@TravisBuddy

TravisBuddy commented Sep 28, 2020

Copy link
Copy Markdown

Travis tests have failed

Hey @dhruvmanila,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 38645890-01b9-11eb-9be6-0d9634a5fbe7

@dhruvmanila

dhruvmanila commented Sep 28, 2020

Copy link
Copy Markdown
MemberAuthor

It seems like there's a doctest which is actually failing?
Can you take a look at it? https://travis-ci.com/github/TheAlgorithms/Python/jobs/392149978#L1300
@cclauss

@dhruvmanila

dhruvmanila commented Sep 28, 2020

Copy link
Copy Markdown
MemberAuthor

Weird, it's passing when I run it locally.

@dhruvmanila

dhruvmanila commented Sep 28, 2020

Copy link
Copy Markdown
MemberAuthor

Can you rerun the build? @cclauss

cclauss
cclauss approved these changes Sep 28, 2020
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!!

@cclauss
cclauss merged commit 9016fe1 into TheAlgorithms:masterSep 28, 2020
@cclauss

cclauss commented Sep 28, 2020

Copy link
Copy Markdown
Member

Travis is being flakey lately.

@dhruvmanila
dhruvmanila deleted the patch-imports branch September 29, 2020 01:35
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila@stokhos
Fix imports for all namespace packages (TheAlgorithms#2506)
a38b6a0
* Fix imports as they're namespace packages
* Fix import for scripts/validate_filenames.py
* Fix path in doctest
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
Fix imports for all namespace packages (TheAlgorithms#2506)
15e6462
* Fix imports as they're namespace packages
* Fix import for scripts/validate_filenames.py
* Fix path in doctest
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhruvmanila@TravisBuddy@cclauss