Create instagram_crawler.py by yogeshwaran01 · Pull Request #2509 · TheAlgorithms/Python

yogeshwaran01 · 2020-09-29T11:58:38Z

Describe your change:

Crawl the Instagram users information

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-09-29T12:13:32Z

Hey @yogeshwaran01,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 30438200-024d-11eb-aba2-872ffb2742c8

TravisBuddy · 2020-09-29T12:13:32Z

Hey @yogeshwaran01,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 304333e0-024d-11eb-aba2-872ffb2742c8

Co-authored-by: Christian Clauss <cclauss@me.com>

yogeshwaran01

done

yogeshwaran01 · 2020-09-29T12:52:24Z

Requested changes are commited.

yogeshwaran01 · 2020-09-29T13:08:26Z

+ return info["username"]
+
+ @property
+ def profile_picture_url(self) -> str:


requested changes done

TravisBuddy · 2020-09-29T13:51:40Z

Travis tests have failed

Hey @yogeshwaran01,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e41c8a80-025a-11eb-aba2-872ffb2742c8

TravisBuddy · 2020-09-29T14:16:33Z

Hey @yogeshwaran01,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 5f37dcd0-025e-11eb-aba2-872ffb2742c8

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

TravisBuddy · 2020-09-29T14:29:25Z

Travis tests have failed

Hey @yogeshwaran01,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2a97cec0-0260-11eb-aba2-872ffb2742c8

dhruvmanila · 2020-09-29T14:56:32Z

I think the user_agent differs with the platform and browser used.

From wikipedia:
Mozilla/[version] ([system and browser information]) [platform] ([platform details]) [extensions]

"User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) "
"AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36"

Here, you are using a user_agent assuming to be on Macintosh and the browsers to be either Chrome or Safari while our Travis tests are run on Linux. I don't have much idea regarding this topic so please do the research and update the user_agent accordingly.

Resources:
https://en.wikipedia.org/wiki/User_agent
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent

cclauss · 2020-09-29T15:04:35Z

In this repo, we have https://pypi.org/project/fake-useragent/ installed.

TravisBuddy · 2020-09-29T15:08:42Z

Hey @yogeshwaran01,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a86adc20-0265-11eb-aba2-872ffb2742c8

dhruvmanila · 2020-09-29T15:12:49Z

Please do these small checks locally so that you don't waste your time editing over and over again.
Thank you for your cooperation 😁

black <filename>
isort <filename>
flake8 --ignore=E203,W503 --max-complexity=25 --max-line-length=88 --statistics --count <filename>
mypy --ignore-missing-imports <filename>
pytest --doctest-modules <filename>

cclauss · 2020-09-29T15:19:32Z

@dhruvmanila Are you interested in creating a pre-commit hook for us?

https://github.com/cclauss/itinerant-tester/blob/master/.pre-commit-config.yaml
https://github.com/cclauss/itinerant-tester/blob/master/.github/workflows/pre-commit.yml

dhruvmanila · 2020-09-29T15:28:45Z

Sure, I'll take a look at it. I've never tried one, so it will be a fun challenge!

There are also those mypy and pytest errors that need to be fixed. I think this is a good idea for Hacktoberfest.

TravisBuddy · 2020-09-29T15:36:37Z

Travis tests have failed

Hey @yogeshwaran01,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8dc39980-0269-11eb-aba2-872ffb2742c8

dhruvmanila · 2020-09-29T15:45:20Z

Hey, @yogeshwaran01, Please run this command locally and see what you're getting as the output:

pytest --doctest-modules instagram_crawler.py

yogeshwaran01 · 2020-09-29T15:51:39Z

pytest --doctest-modules instagram_crawler.py

It passed the test

3 passed in 9.11s

yogeshwaran01 · 2020-09-29T15:56:54Z

Wow, It worked! Thank you, @cclauss and @dhruvmanila.

dhruvmanila · 2020-09-29T15:59:29Z

Your welcome! 🎉 😃
@cclauss Is it ok to have no tests?

cclauss

Looks good to me. The doctest run locally for both @yogeshwaran01 and I but they fail on Travis CI.

cclauss · 2020-09-29T16:05:44Z

There is a gold star for whoever can make the doctests pass under Travis CI.

* Create instagram_crawler.py * codespell --ignore-words-list=followings * Update web_programming/instagram_crawler.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/instagram_crawler.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/instagram_crawler.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/instagram_crawler.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/instagram_crawler.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/instagram_crawler.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/instagram_crawler.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update instagram_crawler.py * Add doctests * fixup! except (json.decoder.JSONDecodeError, KeyError): * if getenv("CONTINUOUS_INTEGRATION"): return * Update instagram_crawler.py * Update web_programming/instagram_crawler.py Co-authored-by: Dhruv <dhruvmanila@gmail.com> * added fake_useragent * Update instagram_crawler.py * Comment out doctests Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Dhruv <dhruvmanila@gmail.com>

yogeshwaran01and others added 2 commits September 29, 2020 17:25

Create instagram_crawler.py
28671c0

codespell --ignore-words-list=followings
7c6520c

cclauss reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

cclauss reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

Update web_programming/instagram_crawler.py
3cd53cb
Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

cclauss reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

Update web_programming/instagram_crawler.py
cd6f44e
Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

Update web_programming/instagram_crawler.py
52ec0f6
Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

Update web_programming/instagram_crawler.py
66c157d
Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

Update web_programming/instagram_crawler.py
c50204c
Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss requested changes Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

Update web_programming/instagram_crawler.py
fcdf0eb
Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss mentioned this pull request Sep 29, 2020
Create instagram_crawler.py #2508
Closed
14 tasks

Update web_programming/instagram_crawler.py
6756207
Co-authored-by: Christian Clauss <cclauss@me.com>

yogeshwaran01 requested a review from cclauss September 29, 2020 12:27

yogeshwaran01 commented Sep 29, 2020
View reviewed changes

Update instagram_crawler.py
3401506

yogeshwaran01 commented Sep 29, 2020
View reviewed changes

Add doctests
3e92923

cclauss added 3 commits September 29, 2020 15:54

fixup! except (json.decoder.JSONDecodeError, KeyError):
b820a36

if getenv("CONTINUOUS_INTEGRATION"): return
5169ce8

Update instagram_crawler.py
81ac0b1

dhruvmanila reviewed Sep 29, 2020
View reviewed changes

Comment threadweb_programming/instagram_crawler.py Outdated

Update web_programming/instagram_crawler.py
2d7c21a
Co-authored-by: Dhruv <dhruvmanila@gmail.com>

added fake_useragent
fd09b9a

Update instagram_crawler.py
5343049

Comment out doctests
f7254c1

cclauss approved these changes Sep 29, 2020
View reviewed changes

cclauss merged commit e6e2dc6 into TheAlgorithms:masterSep 29, 2020

dhruvmanila mentioned this pull request Sep 30, 2020
Add pre-commit hook for TheAlgorithms/Python #2511
Merged
7 tasks

Uh oh!

Uh oh!

Conversation

yogeshwaran01 commented Sep 29, 2020

Describe your change:

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Sep 29, 2020

TravisBuddy Request Identifier: 30438200-024d-11eb-aba2-872ffb2742c8

Uh oh!

TravisBuddy commented Sep 29, 2020

TravisBuddy Request Identifier: 304333e0-024d-11eb-aba2-872ffb2742c8

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yogeshwaran01 left a comment

Choose a reason for hiding this comment

Uh oh!

yogeshwaran01 commented Sep 29, 2020

Uh oh!

Uh oh!

yogeshwaran01Sep 29, 2020

Choose a reason for hiding this comment

Uh oh!

TravisBuddy commented Sep 29, 2020

Travis tests have failed

TravisBuddy Request Identifier: e41c8a80-025a-11eb-aba2-872ffb2742c8

Uh oh!

TravisBuddy commented Sep 29, 2020

TravisBuddy Request Identifier: 5f37dcd0-025e-11eb-aba2-872ffb2742c8

Uh oh!

Uh oh!

TravisBuddy commented Sep 29, 2020

Travis tests have failed

TravisBuddy Request Identifier: 2a97cec0-0260-11eb-aba2-872ffb2742c8

Uh oh!

dhruvmanila commented Sep 29, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Sep 29, 2020

Uh oh!

TravisBuddy commented Sep 29, 2020

TravisBuddy Request Identifier: a86adc20-0265-11eb-aba2-872ffb2742c8

Uh oh!

dhruvmanila commented Sep 29, 2020

Uh oh!

cclauss commented Sep 29, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhruvmanila commented Sep 29, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TravisBuddy commented Sep 29, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8dc39980-0269-11eb-aba2-872ffb2742c8

Uh oh!

dhruvmanila commented Sep 29, 2020

Uh oh!

yogeshwaran01 commented Sep 29, 2020

Uh oh!

yogeshwaran01 commented Sep 29, 2020

Uh oh!

dhruvmanila commented Sep 29, 2020

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Sep 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

dhruvmanila commented Sep 29, 2020•
edited
Loading

cclauss commented Sep 29, 2020•
edited
Loading

dhruvmanila commented Sep 29, 2020•
edited
Loading