Skip to content

Created problem_112.py in project_euler - #2532

Merged
realDuYuanChao merged 12 commits into
TheAlgorithms:masterfrom
Kush1101:master
Oct 3, 2020
Merged

Created problem_112.py in project_euler#2532
realDuYuanChao merged 12 commits into
TheAlgorithms:masterfrom
Kush1101:master

Conversation

@Kush1101

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Kush1101

Copy link
Copy Markdown
MemberAuthor

@shellhub, @dhruvmanila would be interested in reviewing this?

Comment threadproject_euler/problem_112/sol1.py
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Comment threadproject_euler/problem_112/sol1.py Outdated
Comment threadproject_euler/problem_112/sol1.py
Comment threadproject_euler/problem_112/sol1.py
Comment threadproject_euler/problem_112/sol1.py
@TheAlgorithmsTheAlgorithms deleted a comment from dhruvmanilaOct 1, 2020
Comment threadproject_euler/problem_112/sol1.py Outdated
Comment threadproject_euler/problem_112/sol1.py
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@realDuYuanChao

realDuYuanChao commented Oct 1, 2020 via email

Copy link
Copy Markdown
Member

@Kush1101

Kush1101 commented Oct 1, 2020

Copy link
Copy Markdown
MemberAuthor

But you can have float percentages as well. Testing it for 99.2 or 99.3 will not yield results if we have ==

Comment threadproject_euler/problem_112/__init__.py Outdated
Kush1101and others added 2 commits October 1, 2020 19:21
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
@Kush1101

Copy link
Copy Markdown
MemberAuthor

I think it can be merged now.

@dhruvmanila

Copy link
Copy Markdown
Member

@Kush1101 Do you mean that if we keep the __init__.py file empty the tests are failing?
Can you point out which tests are failing?

@Kush1101

Copy link
Copy Markdown
MemberAuthor

@Kush1101 Do you mean that if we keep the __init__.py file empty the tests are failing?
Can you point out which tests are failing?

Travis CI tests.

@Kush1101

Copy link
Copy Markdown
MemberAuthor

@cclauss I think it's up to you now. Can you review it?

@dhruvmanila

Copy link
Copy Markdown
Member

I don't think so because almost all the __init__.py files are empty. Can you provide me the link for the build which failed due to this issue? That would be really helpful in finding out what's going on. Thanks.

@Kush1101

Kush1101 commented Oct 2, 2020

Copy link
Copy Markdown
MemberAuthor

I don't think so because almost all the __init__.py files are empty. Can you provide me the link for the build which failed due to this issue? That would be really helpful in finding out what's going on. Thanks.
You can see it now. It's actually the pre-commit test that fails.

@realDuYuanChaorealDuYuanChao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete empty line. and try it.

Comment threadproject_euler/problem_112/__init__.py Outdated
@dhruvmanila

Copy link
Copy Markdown
Member

Merging is blocked as @shellhub requested some changes. Maybe only he can merge this?

@realDuYuanChaorealDuYuanChao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@realDuYuanChao
realDuYuanChao merged commit 6a39545 into TheAlgorithms:masterOct 3, 2020
@Kush1101Kush1101 added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 8, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Add files via upload
* Create __init__.py
* Update and rename project_euler/problem_112.py to project_euler/problem_112/sol1.py
* Update project_euler/problem_112/sol1.py
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
* Update sol1.py
* Update sol1.py
* Update project_euler/problem_112/sol1.py
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
* Update project_euler/problem_112/__init__.py
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
* Update __init__.py
* Update __init__.py
* Update __init__.py
* delete __init__.py content
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Add files via upload
* Create __init__.py
* Update and rename project_euler/problem_112.py to project_euler/problem_112/sol1.py
* Update project_euler/problem_112/sol1.py
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
* Update sol1.py
* Update sol1.py
* Update project_euler/problem_112/sol1.py
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
* Update project_euler/problem_112/__init__.py
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
* Update __init__.py
* Update __init__.py
* Update __init__.py
* delete __init__.py content
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Co-authored-by: Du Yuanchao <shellhub.me@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Kush1101@realDuYuanChao@dhruvmanila