Skip to content

Hacktoberfest: Add a solution for Project Euler 49 - #2702

Merged
dhruvmanila merged 16 commits into
TheAlgorithms:masterfrom
Iqrar99:pe-49
Oct 5, 2020
Merged

Hacktoberfest: Add a solution for Project Euler 49#2702
dhruvmanila merged 16 commits into
TheAlgorithms:masterfrom
Iqrar99:pe-49

Conversation

@Iqrar99

@Iqrar99Iqrar99 commented Oct 3, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Seperated the PR based on #2548

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dhruvmanila
dhruvmanila requested changes Oct 4, 2020
View reviewed changes
Comment threadproject_euler/problem_49/sol1.py
Comment threadproject_euler/problem_49/sol1.py
Comment threadproject_euler/problem_49/sol1.py
Comment threadproject_euler/problem_49/sol1.py
Comment threadproject_euler/problem_49/sol1.py Outdated
Comment threadproject_euler/problem_49/sol1.py Outdated
Comment threadproject_euler/problem_49/sol1.py Outdated
Comment threadproject_euler/problem_49/sol1.py Outdated
Comment threadproject_euler/problem_49/sol1.py Outdated
@dhruvmaniladhruvmanila added the awaiting changes A maintainer has requested changes to this PR label Oct 4, 2020
@Iqrar99

Iqrar99 commented Oct 4, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review @dhruvmanila. I'll make the changes soon.

dhruvmanila
dhruvmanila requested changes Oct 4, 2020
View reviewed changes
Comment threadproject_euler/problem_49/sol1.py Outdated
dhruvmanila
dhruvmanila requested changes Oct 5, 2020
View reviewed changes

@dhruvmaniladhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution. 🎉 😃

Comment threadproject_euler/problem_49/sol1.py Outdated
@Iqrar99@dhruvmanila
Update project_euler/problem_49/sol1.py
05c9a36
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
@Iqrar99

Iqrar99 commented Oct 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Looks good to me! Thank you for your contribution. 🎉 😃

You are welcome! Maybe you want to review my Project Euler 50 PR? @dhruvmanila here #2703

@dhruvmanila

dhruvmanila commented Oct 5, 2020

Copy link
Copy Markdown
Member

Sure thing, but please keep this in mind that we receive a lot of PRs and if possible only submit one PR at a time and once that is approved, submit another one.

The ocean is made up of tiny droplets of water

@Iqrar99

Iqrar99 commented Oct 5, 2020

Copy link
Copy Markdown
ContributorAuthor

I see. Take your time 😄

@dhruvmanila

dhruvmanila commented Oct 5, 2020

Copy link
Copy Markdown
Member

Are you participating in Hacktoberfest? If so, please include for Hacktoberfest in the description of your PR to signal us.

@dhruvmaniladhruvmanila removed the awaiting changes A maintainer has requested changes to this PR label Oct 5, 2020
dhruvmanila
dhruvmanila approved these changes Oct 5, 2020
View reviewed changes

@dhruvmaniladhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2695

@Iqrar99Iqrar99 changed the title Add a solution for Project Euler 49Hacktoberfest: Add a solution for Project Euler 49Oct 5, 2020
@dhruvmanila
dhruvmanila merged commit e040ad2 into TheAlgorithms:masterOct 5, 2020
@dhruvmaniladhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 5, 2020
@Iqrar99

Iqrar99 commented Oct 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Thank you so much 😄 I'm looking forward to contributing more!

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Iqrar99github-actions
@dhruvmanila@stokhos
Add a solution for Project Euler 49 (TheAlgorithms#2702)
5d2815c
* added doctests in modular_exponential.py
* added doctests in modular_exponential.py
* added URL link
* updating DIRECTORY.md
* Add problem 49 solution
* updating DIRECTORY.md
* Fix several mistakes
These fixes are intended to follow the CONTRIBUTING.md
* Move the import statements lower
* Update project_euler/problem_49/sol1.py
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Iqrar99github-actions@dhruvmanila
Add a solution for Project Euler 49 (TheAlgorithms#2702)
240f053
* added doctests in modular_exponential.py
* added doctests in modular_exponential.py
* added URL link
* updating DIRECTORY.md
* Add problem 49 solution
* updating DIRECTORY.md
* Fix several mistakes
These fixes are intended to follow the CONTRIBUTING.md
* Move the import statements lower
* Update project_euler/problem_49/sol1.py
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmaniladhruvmaniladhruvmanila approved these changes

Assignees

No one assigned

Labels

hacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Iqrar99@dhruvmanila