Skip to content

Add type hints for "strings" folder - #2882

Merged
dhruvmanila merged 3 commits into
TheAlgorithms:masterfrom
DmytroLitvinov:type-hints-strings
Oct 6, 2020
Merged

Add type hints for "strings" folder#2882
dhruvmanila merged 3 commits into
TheAlgorithms:masterfrom
DmytroLitvinov:type-hints-strings

Conversation

@DmytroLitvinov

@DmytroLitvinovDmytroLitvinov commented Oct 5, 2020•
edited
Loading

Copy link
Copy Markdown

Describe your change:

This PR adds type hints into strings/ folder.
Related to issue #2128

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • [] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@DmytroLitvinov

DmytroLitvinov commented Oct 5, 2020

Copy link
Copy Markdown
Author

Friendly ping @dhruvmanila 👀

@DmytroLitvinovDmytroLitvinov changed the title Add type hints for strings/Add type hints for "strings" folderOct 5, 2020
dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View reviewed changes
Comment threadstrings/aho_corasick.py Outdated
Comment threadstrings/aho_corasick.py Outdated
Comment threadstrings/aho_corasick.py Outdated
Comment threadstrings/boyer_moore_search.py Outdated
Comment threadstrings/knuth_morris_pratt.py Outdated
@dhruvmaniladhruvmanila added the awaiting changes A maintainer has requested changes to this PR label Oct 6, 2020
@dhruvmanila

dhruvmanila commented Oct 6, 2020

Copy link
Copy Markdown
Member

What happened in here lol?
You will have to make an empty commit for other checks to run as right now only Travis CI ran.

@DmytroLitvinov

DmytroLitvinov commented Oct 6, 2020

Copy link
Copy Markdown
Author

@dhruvmanila, after pushing empty commit - 2 other checks were running. The result of their running is updating DIRECTORY.md.

@DmytroLitvinov

DmytroLitvinov commented Oct 6, 2020

Copy link
Copy Markdown
Author

@dhruvmanila , seems like it is okay.

Selection_356
Selection_357

dhruvmanila
dhruvmanila approved these changes Oct 6, 2020
View reviewed changes

@dhruvmaniladhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then it's fine. Thank you for your contribution!

@dhruvmanila
dhruvmanila merged commit 000cedc into TheAlgorithms:masterOct 6, 2020
@DmytroLitvinov
DmytroLitvinov deleted the type-hints-strings branch October 6, 2020 08:45
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
Dmytro Litvinovgithub-actions@stokhos
Add type hints for "strings" folder (TheAlgorithms#2882)
961851c
* Add type hints for strings/ folder
* Rerun other checks
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
Dmytro Litvinovgithub-actions
Add type hints for "strings" folder (TheAlgorithms#2882)
20582ce
* Add type hints for strings/ folder
* Rerun other checks
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmaniladhruvmaniladhruvmanila approved these changes

Assignees

No one assigned

Labels

awaiting changesA maintainer has requested changes to this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DmytroLitvinov@dhruvmanila