Skip to content

Hacktoberfest 2020: Add style improvements for Project Euler Problem 03 - #2917

Merged
dhruvmanila merged 16 commits into
TheAlgorithms:masterfrom
archaengel:master
Oct 6, 2020
Merged

Hacktoberfest 2020: Add style improvements for Project Euler Problem 03#2917
dhruvmanila merged 16 commits into
TheAlgorithms:masterfrom
archaengel:master

Conversation

@archaengel

@archaengelarchaengel commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Related: #2786

@archaengel
Fix typehints in project_euler/problem01
e70c27d
Squashed commit of the following:
commit 6801d07
Author: Archaengel <god11341258@gmail.com>
Date: Mon Oct 5 16:40:10 2020 -0700
Fix typehints in project_euler/problem01
commit 29afc3a
Author: Archaengel <god11341258@gmail.com>
Date: Mon Oct 5 15:06:34 2020 -0700
Add typehints and default argument for project_euler/problem_01
@archaengel
Merge remote-tracking branch 'upstream/master' into master
cd03961
@archaengel
Merge remote-tracking branch 'upstream/master' into master
68c47af
@archaengel
Add default args, typehints, and expand variable names for PE prob 02
db03f25
@archaengel
Merge remote-tracking branch 'upstream/master' into master
07f1d9a
@archaengel
Merge remote-tracking branch 'upstream/master' into master
b3c97d3
@archaengel
Add style improvements for first solution of PE Problem 02
4c163d0
@archaengel
Add default arg and typehints for second solution of PE Problem 02
8c30a0c
@archaengel
Add default arg for third solution of PE Problem 02
a277101
@archaengel
Add style improvements for 1st soln of PE problem 03
f691938
@archaengel
Add default arg and typehints for 2nd soln of PE problem 03
f188b91
@archaengel
Add default arg for 3rd soln of PE problem 03
8053b0d
dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View reviewed changes
Comment threadproject_euler/problem_03/sol2.py Outdated
Comment threadproject_euler/problem_03/sol3.py Outdated
@dhruvmaniladhruvmanila added awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 6, 2020
@archaengel

archaengel commented Oct 6, 2020

Copy link
Copy Markdown
ContributorAuthor

I've removed the unnecessary newlines. Let me know if there's anything else I should address!

dhruvmanila
dhruvmanila approved these changes Oct 6, 2020
View reviewed changes

@dhruvmaniladhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@dhruvmanila
dhruvmanila merged commit 5440138 into TheAlgorithms:masterOct 6, 2020
@archaengel

archaengel commented Oct 6, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review!

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@archaengel@stokhos
Hacktoberfest 2020: Add style improvements for Project Euler Problem …
6daeaab
…03 (TheAlgorithms#2917)
* Fix typehints in project_euler/problem01
Squashed commit of the following:
commit 6801d07
Author: Archaengel <god11341258@gmail.com>
Date: Mon Oct 5 16:40:10 2020 -0700
Fix typehints in project_euler/problem01
commit 29afc3a
Author: Archaengel <god11341258@gmail.com>
Date: Mon Oct 5 15:06:34 2020 -0700
Add typehints and default argument for project_euler/problem_01
* Add default args, typehints, and expand variable names for PE prob 02
* Add style improvements for first solution of PE Problem 02
* Add default arg and typehints for second solution of PE Problem 02
* Add default arg for third solution of PE Problem 02
* Add style improvements for 1st soln of PE problem 03
* Add default arg and typehints for 2nd soln of PE problem 03
* Add default arg for 3rd soln of PE problem 03
* Remove unnecessary newlines
* Remove unnecessary newlines
* Fix end of file for 2nd soln in PE problem 03
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@archaengel
Hacktoberfest 2020: Add style improvements for Project Euler Problem …
8216eb2
…03 (TheAlgorithms#2917)
* Fix typehints in project_euler/problem01
Squashed commit of the following:
commit 6801d07
Author: Archaengel <god11341258@gmail.com>
Date: Mon Oct 5 16:40:10 2020 -0700
Fix typehints in project_euler/problem01
commit 29afc3a
Author: Archaengel <god11341258@gmail.com>
Date: Mon Oct 5 15:06:34 2020 -0700
Add typehints and default argument for project_euler/problem_01
* Add default args, typehints, and expand variable names for PE prob 02
* Add style improvements for first solution of PE Problem 02
* Add default arg and typehints for second solution of PE Problem 02
* Add default arg for third solution of PE Problem 02
* Add style improvements for 1st soln of PE problem 03
* Add default arg and typehints for 2nd soln of PE problem 03
* Add default arg for 3rd soln of PE problem 03
* Remove unnecessary newlines
* Remove unnecessary newlines
* Fix end of file for 2nd soln in PE problem 03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmaniladhruvmaniladhruvmanila approved these changes

Assignees

No one assigned

Labels

awaiting changesA maintainer has requested changes to this PRhacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@archaengel@dhruvmanila