Skip to content

Fixes: #3869: Optimize CI runtime of Project Euler's Problem 74's Solution 2 - #3893

Merged
dhruvmanila merged 2 commits into
TheAlgorithms:masterfrom
tacitvenom:euler_074_sol2
Nov 20, 2020
Merged

Fixes: #3869: Optimize CI runtime of Project Euler's Problem 74's Solution 2#3893
dhruvmanila merged 2 commits into
TheAlgorithms:masterfrom
tacitvenom:euler_074_sol2

Conversation

@tacitvenom

@tacitvenomtacitvenom commented Nov 16, 2020•
edited
Loading

Copy link
Copy Markdown

fixes: #3869

Describe your change:

  • Optimize Project Euler's Problem 74's Solution Improvement #2 using caches of factorials and sums of factorials of digits of a number
  • Fix typo for Project Euler's Problem 74's Solution Minor improvement #1 because of which it wasn't running on CI for running solutions
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dhruvmanila
dhruvmanila requested changes Nov 18, 2020
View reviewed changes
Comment threadproject_euler/problem_074/sol1.py Outdated
Comment threadproject_euler/problem_074/sol2.py Outdated
Comment threadproject_euler/problem_074/sol2.py Outdated
Comment threadproject_euler/problem_074/sol2.py Outdated
Comment threadproject_euler/problem_074/sol2.py Outdated
@dhruvmaniladhruvmanila added awaiting changes A maintainer has requested changes to this PR enhancement This PR modified some existing files labels Nov 18, 2020
@tacitvenom

tacitvenom commented Nov 18, 2020

Copy link
Copy Markdown
Author

I'll squash and rebase once approved (still prefer to keep separate commits for each change)

@dhruvmanila

dhruvmanila commented Nov 18, 2020

Copy link
Copy Markdown
Member

You don't need to do any of the rebasing, it will be done by us when we merge the PR.

dhruvmanila
dhruvmanila requested changes Nov 19, 2020
View reviewed changes
Comment threadproject_euler/problem_074/sol2.py
Comment threadproject_euler/problem_074/sol2.py Outdated
Comment threadproject_euler/problem_074/sol2.py Outdated
@dhruvmanila

dhruvmanila commented Nov 19, 2020

Copy link
Copy Markdown
Member

You need to write the fixes: # part in the pull request body. I made the changes so please update the title of this PR according to what you're submitting.

@tacitvenomtacitvenom changed the title Fixes: #3869Fixes: #3869: Optimize CI runtime of Project Euler's Problem 74's Solution #2Nov 19, 2020
@tacitvenomtacitvenom changed the title Fixes: #3869: Optimize CI runtime of Project Euler's Problem 74's Solution #2Fixes: #3869: Optimize CI runtime of Project Euler's Problem 74's Solution 2Nov 19, 2020
@dhruvmanila

dhruvmanila commented Nov 20, 2020

Copy link
Copy Markdown
Member

Thank you for all the changes, related and unrelated to the issue at hand and sorry for not picking it out in the first review. I will keep that in mind in the future. Also, thanks for the information regarding branchless programming, I will take a look into that.

LGTM! ✅

@dhruvmanila
dhruvmanila merged commit 83b8b3c into TheAlgorithms:masterNov 20, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
tacitvenomgithub-actions@stokhos
Fixes:TheAlgorithms#3869: Optimize CI runtime of Project Euler's Pro…
15ac0e2
…blem 74's Solution 2 (TheAlgorithms#3893)
* Fixes: TheAlgorithms#3869: Optimize Project Euler's Problem 74's Solution 2
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
tacitvenomgithub-actions@peRFectBeliever
Fixes:TheAlgorithms#3869: Optimize CI runtime of Project Euler's Pro…
1489c66
…blem 74's Solution 2 (TheAlgorithms#3893)
* Fixes: TheAlgorithms#3869: Optimize Project Euler's Problem 74's Solution 2
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
tacitvenomgithub-actions
Fixes:TheAlgorithms#3869: Optimize CI runtime of Project Euler's Pro…
bb53aa9
…blem 74's Solution 2 (TheAlgorithms#3893)
* Fixes: TheAlgorithms#3869: Optimize Project Euler's Problem 74's Solution 2
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
tacitvenomgithub-actions@shermanhui
Fixes:TheAlgorithms#3869: Optimize CI runtime of Project Euler's Pro…
3606fa0
…blem 74's Solution 2 (TheAlgorithms#3893)
* Fixes: TheAlgorithms#3869: Optimize Project Euler's Problem 74's Solution 2
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmaniladhruvmaniladhruvmanila approved these changes
@Kush1101Kush1101Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

awaiting changesA maintainer has requested changes to this PRenhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need optimization for Project Euler problem 74 sol2.py

2 participants

@tacitvenom@dhruvmanila