Skip to content

[mypy] Fixes Fisher Yates shuffle and extends annotations #5653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spazm wants to merge 3 commits into from
Closed

[mypy] Fixes Fisher Yates shuffle and extends annotations #5653

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cc5cf4
fischer_yates_shuffle: fixes bug introduced by partial renaming in #4673
spazm Oct 29, 2021
644f534
fischer_yates_shuffle: aligns arrays in test output to simplify compa…
spazm Oct 29, 2021
487a687
[mypy] adds a generic typevar for fisher yates list shuffle
spazm Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions other/fischer_yates_shuffle.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,19 +6,22 @@
wikipedia/Fischer-Yates-Shuffle.
"""
import random
from typing import TypeVar

T = TypeVar('T')

def fisher_yates_shuffle(data: list) -> list:
for _ in range(len(list)):
a = random.randint(0, len(list) - 1)
b = random.randint(0, len(list) - 1)
list[a], list[b] = list[b], list[a]
return list

def fisher_yates_shuffle(data: list[T]) -> list[T]:
for _ in range(len(data)):
a = random.randint(0, len(data) - 1)
b = random.randint(0, len(data) - 1)
data[a], data[b] = data[b], data[a]
return data


if __name__ == "__main__":
integers = [0, 1, 2, 3, 4, 5, 6, 7]
strings = ["python", "says", "hello", "!"]
print("Fisher-Yates Shuffle:")
print("List", integers, strings)
print("Lists ", integers, strings)
print("FY Shuffle", fisher_yates_shuffle(integers), fisher_yates_shuffle(strings))