Update sorts/bubble_sort.py

[dylanbuchi]

Describe your change:

• In sorts/bubble_sort.py:
  • Add missing type annotations
  • Refactor bubble_sort function

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[l3str4nge]

Is calling reversed more efficient? I don't think so. Did you do some benchmarks?

[dylanbuchi]

reversed has to be a bit better since the Python heapq.py module uses it.
It also improves code readability. @l3str4nge

Source: https://www.python.org/dev/peps/pep-0322/

[l3str4nge]

I know but it would be good to know if algorithms performance is better too :) Could you perform any benchmarks before and after refactor?

[dylanbuchi]

Benchmarked with the timeit module:

1000 items:

Before: 0.10902250000071945
After: 0.11019620000297436

5000 items:

Before: 2.8898907999973744
After: 2.844012000001385

10000 items:

Before: 12.34897049999563
After: 11.655540399995516

I tested a bit more locally and sometimes refactored one is better and sometimes it's the original.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.