Skip to content

Add Ideal Gas Law for physics - #6503

Merged
cclauss merged 8 commits into
TheAlgorithms:masterfrom
kavienanj:master
Oct 30, 2022
Merged

Add Ideal Gas Law for physics#6503
cclauss merged 8 commits into
TheAlgorithms:masterfrom
kavienanj:master

Conversation

@kavienanj

@kavienanjkavienanj commented Oct 2, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Ideal Gas Law consists of 2 functions with return computed values for pressure and volume of a gas system according to given input values.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 2, 2022
CaedenPH
CaedenPH approved these changes Oct 2, 2022
View reviewed changes

@CaedenPHCaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py
kavienanjand others added 2 commits October 2, 2022 17:42
@kavienanj@CaedenPH
Update physics/ideal_gas_law.py
63b2f12
Suggestion #1
Co-authored-by: Caeden <caedenperelliharris@gmail.com>
@kavienanj@CaedenPH
Update physics/ideal_gas_law.py
6b9a10d
Suggestion #2
Co-authored-by: Caeden <caedenperelliharris@gmail.com>
@kavienanj

kavienanj commented Oct 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Added the suggestions! Please accept these changes

ZeroDayOwl
ZeroDayOwl suggested changes Oct 16, 2022
View reviewed changes
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py
Comment threadphysics/ideal_gas_law.py Outdated
CaedenPH
CaedenPH reviewed Oct 16, 2022
View reviewed changes
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py Outdated
kavienanjand others added 2 commits October 17, 2022 10:14
@kavienanj@CaedenPH
Update volume return line sugesstion
c56aa57
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@kavienanj
Add suggestions
e59078c
CaedenPH
CaedenPH reviewed Oct 17, 2022
View reviewed changes

@CaedenPHCaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last things from me

Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py
Comment threadphysics/ideal_gas_law.py
@CaedenPH

CaedenPH commented Oct 30, 2022

Copy link
Copy Markdown
Contributor

@cclauss I think this is worthy of review - Perhaps committing my changes might be good, however the pr in general looks good

@cclauss@CaedenPH
Apply suggestions from code review
2bb3442
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@cclauss
cclauss merged commit c0b0b12 into TheAlgorithms:masterOct 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH approved these changes
@cclausscclausscclauss approved these changes
+1 more reviewer
@ZeroDayOwlZeroDayOwlZeroDayOwl requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kavienanj@CaedenPH@cclauss@ZeroDayOwl