Skip to content

feat(maths): add function to perform calculation - #6602

Merged
tianyizheng02 merged 7 commits into
TheAlgorithms:masterfrom
okzapradhana:add-sum-of-two-positive-numbers-bitwise-program
Sep 27, 2023
Merged

feat(maths): add function to perform calculation#6602
tianyizheng02 merged 7 commits into
TheAlgorithms:masterfrom
okzapradhana:add-sum-of-two-positive-numbers-bitwise-program

Conversation

@okzapradhana

@okzapradhanaokzapradhana commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add single function to calculate sum of two positive numbers using bitwise operator
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Okza Pradhana added 2 commits October 3, 2022 17:58
Okza Pradhana
feat(maths): add function to perform calculation
3ffc115
- Add single function to calculate sum of two positive numbers
using bitwise operator
Okza Pradhana
docs: add wikipedia url as explanation
82ffd35
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2022
CaedenPH
CaedenPH approved these changes Aug 18, 2023
View reviewed changes

@CaedenPHCaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianyizheng02 Pinging for review. Looks mostly good to me

Comment threadmaths/sum_of_two_positive_numbers_bitwise.py Outdated
@CaedenPH

CaedenPH commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

Correction. This algorithm should be in the bit_manipulation folder
@okzapradhana Can you move it there please?
(https://github.com/TheAlgorithms/Python/tree/master/bit_manipulation)

tianyizheng02
tianyizheng02 requested changes Aug 21, 2023
View reviewed changes
Comment threadmaths/sum_of_two_positive_numbers_bitwise.py Outdated
Comment threadmaths/sum_of_two_positive_numbers_bitwise.py Outdated
Comment threadmaths/sum_of_two_positive_numbers_bitwise.py Outdated
tianyizheng02and others added 2 commits September 27, 2023 01:48
@tianyizheng02@CaedenPH
Apply suggestions from code review
73e32c1
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@tianyizheng02
Update sum_of_two_positive_numbers_bitwise.py
3e73174
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Sep 27, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Sep 27, 2023
tianyizheng02
tianyizheng02 approved these changes Sep 27, 2023
View reviewed changes

@tianyizheng02tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH Since we can't expect the author to respond to this PR anymore, I'll just accept this (fixed) PR and open a new PR to move this file to the correct directory myself.

@tianyizheng02
tianyizheng02 merged commit b2e186f into TheAlgorithms:masterSep 27, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Sep 27, 2023
@tianyizheng02tianyizheng02 mentioned this pull request Sep 27, 2023
Merged
14 tasks
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH approved these changes
@tianyizheng02tianyizheng02tianyizheng02 approved these changes
@Kush1101Kush1101Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okzapradhana@CaedenPH@tianyizheng02