') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Reduce the complexity of other/scoring_algorithm.py by MaximSmolskiy · Pull Request #8045 · TheAlgorithms/Python · GitHub
Skip to content

Reduce the complexity of other/scoring_algorithm.py - #8045

Merged
dhruvmanila merged 7 commits into
TheAlgorithms:masterfrom
MaximSmolskiy:reduce-the-complexity-of-other/scoring_algorithm.py
Mar 2, 2023
Merged

Reduce the complexity of other/scoring_algorithm.py#8045
dhruvmanila merged 7 commits into
TheAlgorithms:masterfrom
MaximSmolskiy:reduce-the-complexity-of-other/scoring_algorithm.py

Conversation

@MaximSmolskiy

@MaximSmolskiyMaximSmolskiy commented Dec 24, 2022

Copy link
Copy Markdown
Member

Describe your change:

Reduce the complexity of other/scoring_algorithm.py from 16 to 10

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Dec 24, 2022
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Dec 24, 2022
CaedenPH
CaedenPH reviewed Dec 24, 2022
View reviewed changes

@CaedenPHCaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am misunderstanding something, but why is the max complexity being increased?

@MaximSmolskiy

MaximSmolskiy commented Dec 24, 2022

Copy link
Copy Markdown
MemberAuthor

Maybe I am misunderstanding something, but why is the max complexity being increased?

It was decreased in #7954, but now there are algorithms with greater complexity.

@MaximSmolskiy
MaximSmolskiy requested review from CaedenPH and removed request for cclauss and dhruvmanilaJanuary 9, 2023 11:41
@MaximSmolskiy

MaximSmolskiy commented Feb 24, 2023

Copy link
Copy Markdown
MemberAuthor

@cclauss please review

dhruvmanila
dhruvmanila requested changes Mar 1, 2023
View reviewed changes
Comment threadother/scoring_algorithm.py Outdated
Comment on lines +108 to +113
data_lists: list[list[float]] = get_data(source_data)

score_lists: list[list[float]] = calculate_each_score(data_lists, weights)

final_scores: list[float] = generate_final_scores(score_lists)

@dhruvmaniladhruvmanilaMar 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data_lists: list[list[float]] =get_data(source_data)
score_lists: list[list[float]] =calculate_each_score(data_lists, weights)
final_scores: list[float] =generate_final_scores(score_lists)
data_lists=get_data(source_data)
score_lists=calculate_each_score(data_lists, weights)
final_scores=generate_final_scores(score_lists)

There's no need to specify variable type hint as the functions are already annotated.

@MaximSmolskiyMaximSmolskiyMar 1, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Mar 1, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Mar 1, 2023
@MaximSmolskiy
MaximSmolskiy requested review from dhruvmanila and removed request for CaedenPHMarch 1, 2023 19:27
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Mar 2, 2023
@dhruvmanila
dhruvmanila merged commit ee77812 into TheAlgorithms:masterMar 2, 2023
@MaximSmolskiy
MaximSmolskiy deleted the reduce-the-complexity-of-other/scoring_algorithm.py branch March 2, 2023 07:01
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@MaximSmolskiy@Cjkjvfnby
Reduce the complexity of other/scoring_algorithm.py (TheAlgorithms#8045)
3b3a16d
* Increase the --max-complexity threshold in the file .flake8
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@dhruvmaniladhruvmaniladhruvmanila approved these changes

Assignees

No one assigned

Labels

enhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximSmolskiy@CaedenPH@dhruvmanila