Skip to content

Fix mypy errors in lorentz_transformation_four_vector.py - #8075

Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom
tianyizheng02:fix-mypy-errs-2
Jan 26, 2023
Merged

Fix mypy errors in lorentz_transformation_four_vector.py#8075
cclauss merged 9 commits into
TheAlgorithms:masterfrom
tianyizheng02:fix-mypy-errs-2

Conversation

@tianyizheng02

@tianyizheng02tianyizheng02 commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

Fixed type hints to resolve mypy errors in physics/lorentz_transformation_four_vector.py (see #8070), added documentation, and refactored some things

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

github-actionsand others added 5 commits January 2, 2023 01:57
github-actionsgithub-actions
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lorentz_transformation_four_vector.py
7d8e71e
@tianyizheng02
Remove unused symbol vars
2b800d6
@tianyizheng02
Add function documentation and rewrite algorithm explanation
9999dd9
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Jan 4, 2023
@algorithms-keeperalgorithms-keeperBot mentioned this pull request Jan 4, 2023
Closed
14 tasks
CaedenPH
CaedenPH approved these changes Jan 12, 2023
View reviewed changes

@CaedenPHCaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!

ThomSullivan
ThomSullivan approved these changes Jan 17, 2023
View reviewed changes

@ThomSullivanThomSullivan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formula formats are top notch!

@tianyizheng02

tianyizheng02 commented Jan 17, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss Could you take a look to see if it's good to merge?

cclauss
cclauss reviewed Jan 26, 2023
View reviewed changes
Comment threadphysics/lorentz_transformation_four_vector.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Jan 26, 2023
@cclauss
cclauss merged commit 57c12fa into TheAlgorithms:masterJan 26, 2023
@tianyizheng02
tianyizheng02 deleted the fix-mypy-errs-2 branch January 26, 2023 07:22
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@tianyizheng02github-actions@Cjkjvfnby
Fixmypyerrors inlorentz_transformation_four_vector.py(TheAlgo…
11c4b84
…rithms#8075)
* updating DIRECTORY.md
* Fix mypy errors in lorentz_transformation_four_vector.py
* Remove unused symbol vars
* Add function documentation and rewrite algorithm explanation
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
* updating DIRECTORY.md
* Update error message for speed
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@CaedenPHCaedenPHCaedenPH approved these changes
+1 more reviewer
@ThomSullivanThomSullivanThomSullivan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tianyizheng02@cclauss@CaedenPH@ThomSullivan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix `mypy` errors in `lorentz_transformation_four_vector.py` by tianyizheng02 · Pull Request #8075 · TheAlgorithms/Python · GitHub
Skip to content
Fix mypy errors in lorentz_transformation_four_vector.py - #8075
Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Jan 26, 2023
Merged
Fix mypy errors in lorentz_transformation_four_vector.py#8075
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Jan 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Fixed type hints to resolve mypy errors in physics/lorentz_transformation_four_vector.py (see #8070), added documentation, and refactored some things
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actionsand others
added 5 commits
January 2, 2023 01:57
github-actionsgithub-actions
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lorentz_transformation_four_vector.py
7d8e71e
@tianyizheng02
Remove unused symbol vars
2b800d6
@tianyizheng02
Add function documentation and rewrite algorithm explanation
9999dd9
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
enhancement
This PR modified some existing files
labels
Jan 4, 2023
@algorithms-keeperalgorithms-keeperBot
mentioned this pull request
Jan 4, 2023
 Closed

14 tasks
CaedenPH
CaedenPH
approved these changes
Jan 12, 2023
View reviewed changes
@CaedenPHCaedenPH
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!
ThomSullivan
ThomSullivan
approved these changes
Jan 17, 2023
View reviewed changes
@ThomSullivanThomSullivan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formula formats are top notch!
@tianyizheng02
tianyizheng02
commented
Jan 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss Could you take a look to see if it's good to merge?
cclauss
cclauss
reviewed
Jan 26, 2023
View reviewed changes
Comment threadphysics/lorentz_transformation_four_vector.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jan 26, 2023
@cclauss
cclauss
merged commit 57c12fa
into
TheAlgorithms:masterJan 26, 2023
@tianyizheng02
tianyizheng02
deleted the

fix-mypy-errs-2

branch
January 26, 2023 07:22
Cjkjvfnby pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
@tianyizheng02github-actions@Cjkjvfnby
Fixmypyerrors inlorentz_transformation_four_vector.py(TheAlgo…
11c4b84
…rithms#8075)
* updating DIRECTORY.md
* Fix mypy errors in lorentz_transformation_four_vector.py
* Remove unused symbol vars
* Add function documentation and rewrite algorithm explanation
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
* updating DIRECTORY.md
* Update error message for speed
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@CaedenPHCaedenPHCaedenPH approved these changes

+1 more reviewer

@ThomSullivanThomSullivanThomSullivan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianyizheng02@cclauss@CaedenPH@ThomSullivan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix `mypy` errors in `lorentz_transformation_four_vector.py` by tianyizheng02 · Pull Request #8075 · TheAlgorithms/Python · GitHub
Skip to content
Fix mypy errors in lorentz_transformation_four_vector.py - #8075
Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Jan 26, 2023
Merged
Fix mypy errors in lorentz_transformation_four_vector.py#8075
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Jan 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Fixed type hints to resolve mypy errors in physics/lorentz_transformation_four_vector.py (see #8070), added documentation, and refactored some things
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actionsand others
added 5 commits
January 2, 2023 01:57
github-actionsgithub-actions
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lorentz_transformation_four_vector.py
7d8e71e
@tianyizheng02
Remove unused symbol vars
2b800d6
@tianyizheng02
Add function documentation and rewrite algorithm explanation
9999dd9
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
enhancement
This PR modified some existing files
labels
Jan 4, 2023
@algorithms-keeperalgorithms-keeperBot
mentioned this pull request
Jan 4, 2023
 Closed

14 tasks
CaedenPH
CaedenPH
approved these changes
Jan 12, 2023
View reviewed changes
@CaedenPHCaedenPH
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!
ThomSullivan
ThomSullivan
approved these changes
Jan 17, 2023
View reviewed changes
@ThomSullivanThomSullivan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formula formats are top notch!
@tianyizheng02
tianyizheng02
commented
Jan 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss Could you take a look to see if it's good to merge?
cclauss
cclauss
reviewed
Jan 26, 2023
View reviewed changes
Comment threadphysics/lorentz_transformation_four_vector.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jan 26, 2023
@cclauss
cclauss
merged commit 57c12fa
into
TheAlgorithms:masterJan 26, 2023
@tianyizheng02
tianyizheng02
deleted the

fix-mypy-errs-2

branch
January 26, 2023 07:22
Cjkjvfnby pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
@tianyizheng02github-actions@Cjkjvfnby
Fixmypyerrors inlorentz_transformation_four_vector.py(TheAlgo…
11c4b84
…rithms#8075)
* updating DIRECTORY.md
* Fix mypy errors in lorentz_transformation_four_vector.py
* Remove unused symbol vars
* Add function documentation and rewrite algorithm explanation
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
* updating DIRECTORY.md
* Update error message for speed
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@CaedenPHCaedenPHCaedenPH approved these changes

+1 more reviewer

@ThomSullivanThomSullivanThomSullivan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianyizheng02@cclauss@CaedenPH@ThomSullivan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix `mypy` errors in `lorentz_transformation_four_vector.py` by tianyizheng02 · Pull Request #8075 · TheAlgorithms/Python · GitHub
Skip to content
Fix mypy errors in lorentz_transformation_four_vector.py - #8075
Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Jan 26, 2023
Merged
Fix mypy errors in lorentz_transformation_four_vector.py#8075
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Jan 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Fixed type hints to resolve mypy errors in physics/lorentz_transformation_four_vector.py (see #8070), added documentation, and refactored some things
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actionsand others
added 5 commits
January 2, 2023 01:57
github-actionsgithub-actions
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lorentz_transformation_four_vector.py
7d8e71e
@tianyizheng02
Remove unused symbol vars
2b800d6
@tianyizheng02
Add function documentation and rewrite algorithm explanation
9999dd9
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
enhancement
This PR modified some existing files
labels
Jan 4, 2023
@algorithms-keeperalgorithms-keeperBot
mentioned this pull request
Jan 4, 2023
 Closed

14 tasks
CaedenPH
CaedenPH
approved these changes
Jan 12, 2023
View reviewed changes
@CaedenPHCaedenPH
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!
ThomSullivan
ThomSullivan
approved these changes
Jan 17, 2023
View reviewed changes
@ThomSullivanThomSullivan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formula formats are top notch!
@tianyizheng02
tianyizheng02
commented
Jan 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss Could you take a look to see if it's good to merge?
cclauss
cclauss
reviewed
Jan 26, 2023
View reviewed changes
Comment threadphysics/lorentz_transformation_four_vector.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jan 26, 2023
@cclauss
cclauss
merged commit 57c12fa
into
TheAlgorithms:masterJan 26, 2023
@tianyizheng02
tianyizheng02
deleted the

fix-mypy-errs-2

branch
January 26, 2023 07:22
Cjkjvfnby pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
@tianyizheng02github-actions@Cjkjvfnby
Fixmypyerrors inlorentz_transformation_four_vector.py(TheAlgo…
11c4b84
…rithms#8075)
* updating DIRECTORY.md
* Fix mypy errors in lorentz_transformation_four_vector.py
* Remove unused symbol vars
* Add function documentation and rewrite algorithm explanation
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
* updating DIRECTORY.md
* Update error message for speed
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@CaedenPHCaedenPHCaedenPH approved these changes

+1 more reviewer

@ThomSullivanThomSullivanThomSullivan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianyizheng02@cclauss@CaedenPH@ThomSullivan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix `mypy` errors in `lorentz_transformation_four_vector.py` by tianyizheng02 · Pull Request #8075 · TheAlgorithms/Python · GitHub
Skip to content
Fix mypy errors in lorentz_transformation_four_vector.py - #8075
Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Jan 26, 2023
Merged
Fix mypy errors in lorentz_transformation_four_vector.py#8075
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Jan 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Fixed type hints to resolve mypy errors in physics/lorentz_transformation_four_vector.py (see #8070), added documentation, and refactored some things
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actionsand others
added 5 commits
January 2, 2023 01:57
github-actionsgithub-actions
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lorentz_transformation_four_vector.py
7d8e71e
@tianyizheng02
Remove unused symbol vars
2b800d6
@tianyizheng02
Add function documentation and rewrite algorithm explanation
9999dd9
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
enhancement
This PR modified some existing files
labels
Jan 4, 2023
@algorithms-keeperalgorithms-keeperBot
mentioned this pull request
Jan 4, 2023
 Closed

14 tasks
CaedenPH
CaedenPH
approved these changes
Jan 12, 2023
View reviewed changes
@CaedenPHCaedenPH
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!
ThomSullivan
ThomSullivan
approved these changes
Jan 17, 2023
View reviewed changes
@ThomSullivanThomSullivan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formula formats are top notch!
@tianyizheng02
tianyizheng02
commented
Jan 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss Could you take a look to see if it's good to merge?
cclauss
cclauss
reviewed
Jan 26, 2023
View reviewed changes
Comment threadphysics/lorentz_transformation_four_vector.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jan 26, 2023
@cclauss
cclauss
merged commit 57c12fa
into
TheAlgorithms:masterJan 26, 2023
@tianyizheng02
tianyizheng02
deleted the

fix-mypy-errs-2

branch
January 26, 2023 07:22
Cjkjvfnby pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
@tianyizheng02github-actions@Cjkjvfnby
Fixmypyerrors inlorentz_transformation_four_vector.py(TheAlgo…
11c4b84
…rithms#8075)
* updating DIRECTORY.md
* Fix mypy errors in lorentz_transformation_four_vector.py
* Remove unused symbol vars
* Add function documentation and rewrite algorithm explanation
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
* updating DIRECTORY.md
* Update error message for speed
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@CaedenPHCaedenPHCaedenPH approved these changes

+1 more reviewer

@ThomSullivanThomSullivanThomSullivan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianyizheng02@cclauss@CaedenPH@ThomSullivan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix `mypy` errors in `lorentz_transformation_four_vector.py` by tianyizheng02 · Pull Request #8075 · TheAlgorithms/Python · GitHub
Skip to content
Fix mypy errors in lorentz_transformation_four_vector.py - #8075
Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Jan 26, 2023
Merged
Fix mypy errors in lorentz_transformation_four_vector.py#8075
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Jan 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Fixed type hints to resolve mypy errors in physics/lorentz_transformation_four_vector.py (see #8070), added documentation, and refactored some things
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actionsand others
added 5 commits
January 2, 2023 01:57
github-actionsgithub-actions
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lorentz_transformation_four_vector.py
7d8e71e
@tianyizheng02
Remove unused symbol vars
2b800d6
@tianyizheng02
Add function documentation and rewrite algorithm explanation
9999dd9
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
enhancement
This PR modified some existing files
labels
Jan 4, 2023
@algorithms-keeperalgorithms-keeperBot
mentioned this pull request
Jan 4, 2023
 Closed

14 tasks
CaedenPH
CaedenPH
approved these changes
Jan 12, 2023
View reviewed changes
@CaedenPHCaedenPH
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!
ThomSullivan
ThomSullivan
approved these changes
Jan 17, 2023
View reviewed changes
@ThomSullivanThomSullivan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formula formats are top notch!
@tianyizheng02
tianyizheng02
commented
Jan 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss Could you take a look to see if it's good to merge?
cclauss
cclauss
reviewed
Jan 26, 2023
View reviewed changes
Comment threadphysics/lorentz_transformation_four_vector.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jan 26, 2023
@cclauss
cclauss
merged commit 57c12fa
into
TheAlgorithms:masterJan 26, 2023
@tianyizheng02
tianyizheng02
deleted the

fix-mypy-errs-2

branch
January 26, 2023 07:22
Cjkjvfnby pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
@tianyizheng02github-actions@Cjkjvfnby
Fixmypyerrors inlorentz_transformation_four_vector.py(TheAlgo…
11c4b84
…rithms#8075)
* updating DIRECTORY.md
* Fix mypy errors in lorentz_transformation_four_vector.py
* Remove unused symbol vars
* Add function documentation and rewrite algorithm explanation
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
* updating DIRECTORY.md
* Update error message for speed
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@CaedenPHCaedenPHCaedenPH approved these changes

+1 more reviewer

@ThomSullivanThomSullivanThomSullivan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianyizheng02@cclauss@CaedenPH@ThomSullivan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Fix `mypy` errors in `lorentz_transformation_four_vector.py` by tianyizheng02 · Pull Request #8075 · TheAlgorithms/Python · GitHub
Skip to content
Fix mypy errors in lorentz_transformation_four_vector.py - #8075
Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Jan 26, 2023
Merged
Fix mypy errors in lorentz_transformation_four_vector.py#8075
cclauss merged 9 commits into
TheAlgorithms:masterfrom 
tianyizheng02:fix-mypy-errs-2
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Jan 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Fixed type hints to resolve mypy errors in physics/lorentz_transformation_four_vector.py (see #8070), added documentation, and refactored some things
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actionsand others
added 5 commits
January 2, 2023 01:57
github-actionsgithub-actions
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lorentz_transformation_four_vector.py
7d8e71e
@tianyizheng02
Remove unused symbol vars
2b800d6
@tianyizheng02
Add function documentation and rewrite algorithm explanation
9999dd9
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
enhancement
This PR modified some existing files
labels
Jan 4, 2023
@algorithms-keeperalgorithms-keeperBot
mentioned this pull request
Jan 4, 2023
 Closed

14 tasks
CaedenPH
CaedenPH
approved these changes
Jan 12, 2023
View reviewed changes
@CaedenPHCaedenPH
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!
ThomSullivan
ThomSullivan
approved these changes
Jan 17, 2023
View reviewed changes
@ThomSullivanThomSullivan
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formula formats are top notch!
@tianyizheng02
tianyizheng02
commented
Jan 17, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss Could you take a look to see if it's good to merge?
cclauss
cclauss
reviewed
Jan 26, 2023
View reviewed changes
Comment threadphysics/lorentz_transformation_four_vector.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jan 26, 2023
@cclauss
cclauss
merged commit 57c12fa
into
TheAlgorithms:masterJan 26, 2023
@tianyizheng02
tianyizheng02
deleted the

fix-mypy-errs-2

branch
January 26, 2023 07:22
Cjkjvfnby pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
@tianyizheng02github-actions@Cjkjvfnby
Fixmypyerrors inlorentz_transformation_four_vector.py(TheAlgo…
11c4b84
…rithms#8075)
* updating DIRECTORY.md
* Fix mypy errors in lorentz_transformation_four_vector.py
* Remove unused symbol vars
* Add function documentation and rewrite algorithm explanation
Previous explanation was misleading, as the code only calculates Lorentz
transformations for movement in the x direction (0 velocity in the y and
z directions) and not movement in any direction
* updating DIRECTORY.md
* Update error message for speed
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@CaedenPHCaedenPHCaedenPH approved these changes

+1 more reviewer

@ThomSullivanThomSullivanThomSullivan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianyizheng02@cclauss@CaedenPH@ThomSullivan