Uh oh!
There was an error while loading. Please reload this page.
Concatenate algorithms - #8103
Conversation
CaedenPH
commented
Jan 27, 2023
@cclauss Review please? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| @@ -1,20 +1,78 @@ | |||
| """Binary Exponentiation.""" | |||
| def binary_exponentiation_multiplication(a, b): | |||
There was a problem hiding this comment.
It looks like this function calculates a * b rather than a ** b, so shouldn't it belong in a file like binary_multiplication.py instead?
Uh oh!
There was an error while loading. Please reload this page.
| return (r * r) % b | ||
| def binary_exponentiation_mod_multiplication(a, b, c): |
There was a problem hiding this comment.
This function also appears to calculate (modular) multiplication rather than exponentiation, so I feel like this might also belong better in a separate file for binary multiplication
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
tianyizheng02
commented
Mar 11, 2023
Where exactly are there merge conflicts? |
tianyizheng02
commented
Mar 27, 2023
CaedenPH
commented
Mar 27, 2023
Not sure where the merge conflicts are, I'll probably reimplement this pull request fixing the conflicts |
Describe your change:
FIxes#8098
Checklist:
Fixes: #{$ISSUE_NO}.