added a problem with solution on sliding window. - #8566

Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom
rohan472000:patch-2
Apr 18, 2023
Merged

added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom
rohan472000:patch-2

Conversation

@rohan472000

@rohan472000rohan472000 commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Mar 28, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
@algorithms-keeperalgorithms-keeperBot removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Mar 28, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
0
"""
n = len(nums)
if n == 0:

@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Mar 28, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
"""

n = len(nums)
if(n == 0):

@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^

algorithms-keeper[bot]
algorithms-keeperBot reviewed Mar 28, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
"""

n = len(nums)
if n == 0:

@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^

algorithms-keeper[bot]
algorithms-keeperBot reviewed Mar 28, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
2
"""
n = len(nums)
if n == 0:

@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py

Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Mar 28, 2023
CaedenPH
CaedenPH reviewed Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
Comment on lines +6 to +12
Args:
target (int): The minimum sum that the subarray should have.
nums (list[int]): The array to search for subarrays in.

Returns:
int: The length of the shortest contiguous subarray
in nums whose sum is at least target. If no such subarray exists, returns 0.

@CaedenPHCaedenPHMar 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary

@rohan472000rohan472000Mar 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it

@rohan472000rohan472000Mar 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
Comment on lines +14 to +16
Examples:
>>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
2

@CaedenPHCaedenPHMar 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well

@rohan472000rohan472000Mar 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner

@rohan472000rohan472000Mar 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....

Comment threadsliding_window/minimum_size_subarray_sum.py Outdated
tianyizheng02
tianyizheng02 requested changes Mar 30, 2023
View reviewed changes

@tianyizheng02tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file

@rohan472000

rohan472000 commented Mar 30, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.

@tianyizheng02

tianyizheng02 commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.

@rohan472000

rohan472000 commented Mar 30, 2023

Copy link
Copy Markdown
ContributorAuthor

yeah got it....made the changes

cclauss
cclauss reviewed Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py Outdated
return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":

@cclausscclaussApr 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@rohan472000rohan472000Apr 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it

@cclauss

cclauss commented Apr 1, 2023

Copy link
Copy Markdown
Member

Why can't we have checkboxes like every other pull request has?
image

@rohan472000

rohan472000 commented Apr 1, 2023

Copy link
Copy Markdown
ContributorAuthor

yeah ...filled the checkboxes

@cclauss

cclauss commented Apr 1, 2023

Copy link
Copy Markdown
Member

Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists

@tianyizheng02

tianyizheng02 commented Apr 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

No, you fill the checkboxes like this:

* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:

  • Test 1
  • Test 2
  • Test 3

@rohan472000

rohan472000 commented Apr 1, 2023

Copy link
Copy Markdown
ContributorAuthor

No, you fill the checkboxes like this:

* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:

  • Test 1
  • Test 2
  • Test 3

Thanks....I changed it.

@rohan472000

rohan472000 commented Apr 2, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss@tianyizheng02
I'm getting below error, what case can we add to solve these testcases?

Failure

File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum
Failed example:
minimum_subarray_sum(0, [1, 2, 3])
Expected:
0
Got:
1

Failure

File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum
Failed example:
minimum_subarray_sum(-6, [3, 4, 5])
Expected:
0
Got:
1

@tianyizheng02

tianyizheng02 commented Apr 2, 2023

Copy link
Copy Markdown
Contributor

Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.

So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].

Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].

In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.

@rohan472000

rohan472000 commented Apr 2, 2023

Copy link
Copy Markdown
ContributorAuthor

done...i was thinking to do that earlier...

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Apr 2, 2023
@rohan472000

rohan472000 commented Apr 2, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@cclauss@tianyizheng02@CaedenPH , please review the code.

@rohan472000

rohan472000 commented Apr 18, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.

@cclauss

cclauss commented Apr 18, 2023

Copy link
Copy Markdown
Member

The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.

@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting reviews This PR is ready to be reviewed labels Apr 18, 2023
@cclauss
cclauss merged commit 458debc into TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Apr 18, 2023
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes
+1 more reviewer
@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
added a problem with solution on sliding window. - #8566
Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Apr 18, 2023
Merged
added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Conversation
@rohan472000
@rohan472000rohan472000
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 0
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if(n == 0):
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 2
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
CaedenPH
CaedenPH
reviewed
Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+6
 to 
+12

 Args:
 target (int): The minimum sum that the subarray should have.
 nums (list[int]): The array to search for subarrays in.

 Returns:
 int: The length of the shortest contiguous subarray
 in nums whose sum is at least target. If no such subarray exists, returns 0.
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+14
 to 
+16

 Examples:
 >>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
 2
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Mar 30, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.
@tianyizheng02
tianyizheng02
commented
Mar 30, 2023

Copy link


Copy Markdown

Contributor
Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah got it....made the changes
cclauss
cclauss
reviewed
Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py
Outdated

 return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":
@cclausscclaussApr 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
@rohan472000rohan472000Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Why can't we have checkboxes like every other pull request has?
image
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah ...filled the checkboxes
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists
@tianyizheng02
tianyizheng02
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
Thanks....I changed it.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02

I'm getting below error, what case can we add to solve these testcases?
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(0, [1, 2, 3])

Expected:

0

Got:

1
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(-6, [3, 4, 5])

Expected:

0

Got:

1
@tianyizheng02
tianyizheng02
commented
Apr 2, 2023

Copy link


Copy Markdown

Contributor
Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.
So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].
Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].
In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
done...i was thinking to do that earlier...
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Apr 2, 2023
@rohan472000
rohan472000
commented
Apr 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02@CaedenPH , please review the code.
@rohan472000
rohan472000
commented
Apr 18, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.
@cclauss
cclauss
commented
Apr 18, 2023

Copy link


Copy Markdown

Member
The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Apr 18, 2023
@cclauss
cclauss
merged commit 458debc
into
TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Apr 18, 2023
tianyizheng02 pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
added a problem with solution on sliding window. - #8566
Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Apr 18, 2023
Merged
added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Conversation
@rohan472000
@rohan472000rohan472000
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 0
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if(n == 0):
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 2
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
CaedenPH
CaedenPH
reviewed
Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+6
 to 
+12

 Args:
 target (int): The minimum sum that the subarray should have.
 nums (list[int]): The array to search for subarrays in.

 Returns:
 int: The length of the shortest contiguous subarray
 in nums whose sum is at least target. If no such subarray exists, returns 0.
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+14
 to 
+16

 Examples:
 >>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
 2
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Mar 30, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.
@tianyizheng02
tianyizheng02
commented
Mar 30, 2023

Copy link


Copy Markdown

Contributor
Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah got it....made the changes
cclauss
cclauss
reviewed
Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py
Outdated

 return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":
@cclausscclaussApr 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
@rohan472000rohan472000Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Why can't we have checkboxes like every other pull request has?
image
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah ...filled the checkboxes
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists
@tianyizheng02
tianyizheng02
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
Thanks....I changed it.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02

I'm getting below error, what case can we add to solve these testcases?
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(0, [1, 2, 3])

Expected:

0

Got:

1
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(-6, [3, 4, 5])

Expected:

0

Got:

1
@tianyizheng02
tianyizheng02
commented
Apr 2, 2023

Copy link


Copy Markdown

Contributor
Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.
So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].
Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].
In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
done...i was thinking to do that earlier...
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Apr 2, 2023
@rohan472000
rohan472000
commented
Apr 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02@CaedenPH , please review the code.
@rohan472000
rohan472000
commented
Apr 18, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.
@cclauss
cclauss
commented
Apr 18, 2023

Copy link


Copy Markdown

Member
The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Apr 18, 2023
@cclauss
cclauss
merged commit 458debc
into
TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Apr 18, 2023
tianyizheng02 pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
added a problem with solution on sliding window. - #8566
Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Apr 18, 2023
Merged
added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Conversation
@rohan472000
@rohan472000rohan472000
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 0
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if(n == 0):
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 2
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
CaedenPH
CaedenPH
reviewed
Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+6
 to 
+12

 Args:
 target (int): The minimum sum that the subarray should have.
 nums (list[int]): The array to search for subarrays in.

 Returns:
 int: The length of the shortest contiguous subarray
 in nums whose sum is at least target. If no such subarray exists, returns 0.
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+14
 to 
+16

 Examples:
 >>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
 2
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Mar 30, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.
@tianyizheng02
tianyizheng02
commented
Mar 30, 2023

Copy link


Copy Markdown

Contributor
Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah got it....made the changes
cclauss
cclauss
reviewed
Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py
Outdated

 return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":
@cclausscclaussApr 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
@rohan472000rohan472000Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Why can't we have checkboxes like every other pull request has?
image
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah ...filled the checkboxes
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists
@tianyizheng02
tianyizheng02
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
Thanks....I changed it.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02

I'm getting below error, what case can we add to solve these testcases?
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(0, [1, 2, 3])

Expected:

0

Got:

1
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(-6, [3, 4, 5])

Expected:

0

Got:

1
@tianyizheng02
tianyizheng02
commented
Apr 2, 2023

Copy link


Copy Markdown

Contributor
Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.
So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].
Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].
In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
done...i was thinking to do that earlier...
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Apr 2, 2023
@rohan472000
rohan472000
commented
Apr 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02@CaedenPH , please review the code.
@rohan472000
rohan472000
commented
Apr 18, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.
@cclauss
cclauss
commented
Apr 18, 2023

Copy link


Copy Markdown

Member
The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Apr 18, 2023
@cclauss
cclauss
merged commit 458debc
into
TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Apr 18, 2023
tianyizheng02 pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
added a problem with solution on sliding window. - #8566
Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Apr 18, 2023
Merged
added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Conversation
@rohan472000
@rohan472000rohan472000
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 0
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if(n == 0):
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 2
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
CaedenPH
CaedenPH
reviewed
Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+6
 to 
+12

 Args:
 target (int): The minimum sum that the subarray should have.
 nums (list[int]): The array to search for subarrays in.

 Returns:
 int: The length of the shortest contiguous subarray
 in nums whose sum is at least target. If no such subarray exists, returns 0.
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+14
 to 
+16

 Examples:
 >>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
 2
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Mar 30, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.
@tianyizheng02
tianyizheng02
commented
Mar 30, 2023

Copy link


Copy Markdown

Contributor
Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah got it....made the changes
cclauss
cclauss
reviewed
Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py
Outdated

 return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":
@cclausscclaussApr 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
@rohan472000rohan472000Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Why can't we have checkboxes like every other pull request has?
image
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah ...filled the checkboxes
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists
@tianyizheng02
tianyizheng02
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
Thanks....I changed it.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02

I'm getting below error, what case can we add to solve these testcases?
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(0, [1, 2, 3])

Expected:

0

Got:

1
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(-6, [3, 4, 5])

Expected:

0

Got:

1
@tianyizheng02
tianyizheng02
commented
Apr 2, 2023

Copy link


Copy Markdown

Contributor
Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.
So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].
Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].
In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
done...i was thinking to do that earlier...
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Apr 2, 2023
@rohan472000
rohan472000
commented
Apr 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02@CaedenPH , please review the code.
@rohan472000
rohan472000
commented
Apr 18, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.
@cclauss
cclauss
commented
Apr 18, 2023

Copy link


Copy Markdown

Member
The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Apr 18, 2023
@cclauss
cclauss
merged commit 458debc
into
TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Apr 18, 2023
tianyizheng02 pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
added a problem with solution on sliding window. - #8566
Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Apr 18, 2023
Merged
added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Conversation
@rohan472000
@rohan472000rohan472000
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 0
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if(n == 0):
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 2
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
CaedenPH
CaedenPH
reviewed
Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+6
 to 
+12

 Args:
 target (int): The minimum sum that the subarray should have.
 nums (list[int]): The array to search for subarrays in.

 Returns:
 int: The length of the shortest contiguous subarray
 in nums whose sum is at least target. If no such subarray exists, returns 0.
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+14
 to 
+16

 Examples:
 >>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
 2
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Mar 30, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.
@tianyizheng02
tianyizheng02
commented
Mar 30, 2023

Copy link


Copy Markdown

Contributor
Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah got it....made the changes
cclauss
cclauss
reviewed
Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py
Outdated

 return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":
@cclausscclaussApr 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
@rohan472000rohan472000Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Why can't we have checkboxes like every other pull request has?
image
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah ...filled the checkboxes
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists
@tianyizheng02
tianyizheng02
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
Thanks....I changed it.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02

I'm getting below error, what case can we add to solve these testcases?
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(0, [1, 2, 3])

Expected:

0

Got:

1
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(-6, [3, 4, 5])

Expected:

0

Got:

1
@tianyizheng02
tianyizheng02
commented
Apr 2, 2023

Copy link


Copy Markdown

Contributor
Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.
So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].
Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].
In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
done...i was thinking to do that earlier...
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Apr 2, 2023
@rohan472000
rohan472000
commented
Apr 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02@CaedenPH , please review the code.
@rohan472000
rohan472000
commented
Apr 18, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.
@cclauss
cclauss
commented
Apr 18, 2023

Copy link


Copy Markdown

Member
The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Apr 18, 2023
@cclauss
cclauss
merged commit 458debc
into
TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Apr 18, 2023
tianyizheng02 pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
added a problem with solution on sliding window. - #8566
Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Apr 18, 2023
Merged
added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Conversation
@rohan472000
@rohan472000rohan472000
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 0
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if(n == 0):
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 2
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
CaedenPH
CaedenPH
reviewed
Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+6
 to 
+12

 Args:
 target (int): The minimum sum that the subarray should have.
 nums (list[int]): The array to search for subarrays in.

 Returns:
 int: The length of the shortest contiguous subarray
 in nums whose sum is at least target. If no such subarray exists, returns 0.
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+14
 to 
+16

 Examples:
 >>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
 2
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Mar 30, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.
@tianyizheng02
tianyizheng02
commented
Mar 30, 2023

Copy link


Copy Markdown

Contributor
Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah got it....made the changes
cclauss
cclauss
reviewed
Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py
Outdated

 return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":
@cclausscclaussApr 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
@rohan472000rohan472000Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Why can't we have checkboxes like every other pull request has?
image
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah ...filled the checkboxes
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists
@tianyizheng02
tianyizheng02
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
Thanks....I changed it.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02

I'm getting below error, what case can we add to solve these testcases?
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(0, [1, 2, 3])

Expected:

0

Got:

1
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(-6, [3, 4, 5])

Expected:

0

Got:

1
@tianyizheng02
tianyizheng02
commented
Apr 2, 2023

Copy link


Copy Markdown

Contributor
Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.
So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].
Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].
In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
done...i was thinking to do that earlier...
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Apr 2, 2023
@rohan472000
rohan472000
commented
Apr 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02@CaedenPH , please review the code.
@rohan472000
rohan472000
commented
Apr 18, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.
@cclauss
cclauss
commented
Apr 18, 2023

Copy link


Copy Markdown

Member
The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Apr 18, 2023
@cclauss
cclauss
merged commit 458debc
into
TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Apr 18, 2023
tianyizheng02 pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
added a problem with solution on sliding window. - #8566
Merged
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Apr 18, 2023
Merged
added a problem with solution on sliding window.#8566
cclauss merged 41 commits into
TheAlgorithms:masterfrom 
rohan472000:patch-2
Conversation
@rohan472000
@rohan472000rohan472000
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 0
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 23:5.parsererror: errorat22:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if(n == 0):
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 24:5.parsererror: errorat23:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~if(n==0):
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 """

 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 20:5.parsererror: errorat19:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Mar 28, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

 2
 """
 n = len(nums)
 if n == 0:
@algorithms-keeperalgorithms-keeperBotMar 28, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occured while parsing the file: sliding_window/minimum_size_subarray_sum.py
Traceback (mostrecentcalllast):
File"/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line145, inparsereports=lint_file(
^^^^^^^^^^libcst._exceptions.ParserSyntaxError: SyntaxError @ 19:5.parsererror: errorat18:4: expectedoneof (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~ifn==0:
^
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Mar 28, 2023
CaedenPH
CaedenPH
reviewed
Mar 28, 2023
View reviewed changes
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+6
 to 
+12

 Args:
 target (int): The minimum sum that the subarray should have.
 nums (list[int]): The array to search for subarrays in.

 Returns:
 int: The length of the shortest contiguous subarray
 in nums whose sum is at least target. If no such subarray exists, returns 0.
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically these parameters and return types should be self documented so these are unnecessary
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...i will remove it
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated


Comment on lines

+14
 to 
+16

 Examples:
 >>> minsubarraysum(7, [2, 3, 1, 2, 4, 3])
 2
@CaedenPHCaedenPHMar 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple more doctests with different numbers and perhaps negative numbers as well
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I will do it sooner
@rohan472000rohan472000Mar 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH, done....
Comment threadsliding_window/minimum_size_subarray_sum.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Mar 30, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to place this in an existing directory rather than creating a new directory just for this file
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02, well there is no directory for this algo, so i made it where all questions and answers based on sliding window can be kept.
@tianyizheng02
tianyizheng02
commented
Mar 30, 2023

Copy link


Copy Markdown

Contributor
Algorithms in this repo are placed in directories based on broad categories like dynamic programming, machine learning, sorting algorithms, etc. It's best to place new algorithm files in the same directory as similar algorithms rather than making a whole new directory for a single algorithm.
@rohan472000
rohan472000
commented
Mar 30, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah got it....made the changes
cclauss
cclauss
reviewed
Apr 1, 2023
View reviewed changes
Comment threaddynamic_programming/minimum_size_subarray_sum.py
Outdated

 return 0 if min_len == sys.maxsize else min_len


if __name__ == "__main__":
@cclausscclaussApr 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
@rohan472000rohan472000Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I removed it
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Why can't we have checkboxes like every other pull request has?
image
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
yeah ...filled the checkboxes
@cclauss
cclauss
commented
Apr 1, 2023

Copy link


Copy Markdown

Member
Markdown has a syntax for checklists... https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists#creating-task-lists
@tianyizheng02
tianyizheng02
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
@rohan472000
rohan472000
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
No, you fill the checkboxes like this:
* [x] Test 1
* [ ] Test 2
* [ ] Test 3

And it should look like this in the preview:
  •  Test 1
  •  Test 2
  •  Test 3
Thanks....I changed it.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02

I'm getting below error, what case can we add to solve these testcases?
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 20, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(0, [1, 2, 3])

Expected:

0

Got:

1
Failure
File "C:\pycharm\codes\Python-pull\sliding_window\minimum_size_subarray_sum.py", line 32, in minimum_size_subarray_sum.minimum_subarray_sum

Failed example:

minimum_subarray_sum(-6, [3, 4, 5])

Expected:

0

Got:

1
@tianyizheng02
tianyizheng02
commented
Apr 2, 2023

Copy link


Copy Markdown

Contributor
Returns the length of the shortest contiguous subarray in a list of numbers whose sum is at least target.
So then minimum_subarray_sum(0, [1, 2, 3])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ 0 is [1].
Likewise, minimum_subarray_sum(-6, [3, 4, 5])should return 1, not 0 like you wrote, because the shortest contiguous subarray with sum ≥ -6 is [3].
In short, the code isn't wrong; it's those two tests that are wrong. Adding more test cases won't fix the issue.
@rohan472000
rohan472000
commented
Apr 2, 2023

Copy link


Copy Markdown

ContributorAuthor
done...i was thinking to do that earlier...
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Apr 2, 2023
@rohan472000
rohan472000
commented
Apr 2, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02@CaedenPH , please review the code.
@rohan472000
rohan472000
commented
Apr 18, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss ,It has been more than 2 weeks of this PR, review it, if something has to be changed in it then suggest.
@cclauss
cclauss
commented
Apr 18, 2023

Copy link


Copy Markdown

Member
The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. Reading the code, I did not understand that this was related to sliding window, A URL to more details can be a great help to visitors to our repo. If you add a URL to the docstring then I will gladly re-review.
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Apr 18, 2023
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Apr 18, 2023
@cclauss
cclauss
merged commit 458debc
into
TheAlgorithms:masterApr 18, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Apr 18, 2023
tianyizheng02 pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
added a problem with solution on sliding window. (TheAlgorithms#8566)
cbcaf06
* added a problem with solution on sliding window.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* added hint for return type and parameter
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* removed un-necessary docs and added 2 test cases
* Rename sliding_window/minimum_size_subarray_sum.py to dynamic_programming/minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update dynamic_programming/minimum_size_subarray_sum.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update minimum_size_subarray_sum.py
* Update minimum_size_subarray_sum.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@CaedenPHCaedenPHCaedenPH left review comments
@tianyizheng02tianyizheng02tianyizheng02 requested changes
@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rohan472000@tianyizheng02@cclauss@CaedenPH