added a problem on kadane's algo and its solution. by rohan472000 · Pull Request #8569 · TheAlgorithms/Python

rohan472000 · 2023-03-29T05:29:24Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

tianyizheng02

Better to place this in an existing directory rather than creating a new directory for it

rohan472000 · 2023-03-30T03:20:21Z

@tianyizheng02 , there is no existing directory for this algo

tianyizheng02 · 2023-03-30T03:25:27Z

We don't make separate directories for each algorithm in this repo. Algorithms are grouped based on general categories such as dynamic programming, machine learning, sorting algorithms, etc. My point is that you should place your new algorithm file in the same directory as similar algorithms.

rohan472000 · 2023-03-30T03:27:27Z

ohh...will do it

how to change the directory now??

…g/max_product_subarray.py

cclauss · 2023-03-30T05:12:53Z

+ n = len(nums)
+
+ if n == 0:
+ return 0


Suggested change
n=len(nums)
ifn==0:
return0
ifnotnumbers:
return0

'n' is the length of nums list , so it will always be a number.

We do not need it until line 23 so let's not run the len() function before we need it.

it's an edge case, so we need to check it first.. rather than going to next step.

We can check it in two lines not three and without a function call.

cclauss · 2023-03-30T05:13:37Z

+ max_till_now = nums[0]
+ min_till_now = nums[0]
+ max_prod = nums[0]


Suggested change
max_till_now=nums[0]
min_till_now=nums[0]
max_prod=nums[0]
max_till_now=min_till_now=max_prod=numbers[0]

cclauss · 2023-03-30T05:18:27Z

+ if nums[i] < 0:
+ max_till_now, min_till_now = min_till_now, max_till_now
+ max_till_now = max(nums[i], max_till_now * nums[i])
+ min_till_now = min(nums[i], min_till_now * nums[i])


Suggested change
ifnums[i] <0:
max_till_now, min_till_now=min_till_now, max_till_now
max_till_now=max(nums[i], max_till_now*nums[i])
min_till_now=min(nums[i], min_till_now*nums[i])
number=numbers[i]
ifnumber<0:
max_till_now, min_till_now=min_till_now, max_till_now
max_till_now=max(number, max_till_now*number])
min_till_now=min(number, min_till_now*number)

Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

cclauss · 2023-03-30T06:37:46Z

+ if numbers is None or not isinstance(numbers, list):
+ return 0
+
+ n = len(numbers)
+
+ if n == 0:
+ return 0
+
+ if not all(isinstance(x, int) for x in numbers):
+ return 0


It is the Pythonic thing to do to raise a TypeError if the caller passes in garbage data.
Suggested change
ifnumbersisNoneornotisinstance(numbers, list):
return0
n=len(numbers)
ifn==0:
return0
ifnotall(isinstance(x, int) forxinnumbers):
return0
ifnotnumbers:
return0
ifnotisinstance(numbers, (list, set, tuple)) ornotall(isinstance(number, int) fornumberinnumbers):
raiseTypeError("numbers must be an iterable of integers")

for more information, see https://pre-commit.ci

rohan472000 · 2023-03-30T07:00:34Z

@cclauss , I have committed all your requests, but still the build is failing , why?

cclauss · 2023-03-30T07:02:57Z

On your local machine type python3 -m doctest -v dynamic_programming/max_product_subarray.py to see if the tests pass.

https://github.com/TheAlgorithms/Python/actions/runs/4561456657/jobs/8047431889?pr=8569#step:6:657

rohan472000 · 2023-03-30T07:07:46Z

max_product_subarray([2, 3, -2, 4.5, -1])
54.0

here is the problem, this is returning float but int is needed.

what should i return if there is float in numbers, print invalid???

cclauss · 2023-03-30T07:10:01Z

Raise TypeError #8569 (comment)

for more information, see https://pre-commit.ci

rohan472000 · 2023-03-30T07:28:19Z

raised the type error, but still build is failing

cclauss · 2023-03-30T08:09:25Z

Here is a doctest for an exception...

Python/maths/ugly_numbers.py

Lines 23 to 26 in a71f22d

 >>> ugly_numbers(-5.5)
 Traceback (most recent call last):
 ...
 TypeError: 'float' object cannot be interpreted as an integer

for more information, see https://pre-commit.ci

Co-authored-by: Christian Clauss <cclauss@me.com>

for more information, see https://pre-commit.ci

Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss

Modified because max_product_subarray("ABC") should not return 0.

rohan472000 · 2023-03-31T11:21:07Z

@cclauss , Thanks for the required modification.

cclauss · 2023-03-31T11:38:26Z

Thanks for your contribution.

* added kadane's algorithm directory with one problem's solution. * added type hints * Rename kaadne_algorithm/max_product_subarray.py to dynamic_programming/max_product_subarray.py * Update dynamic_programming/max_product_subarray.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update max_product_subarray.py * Update max_product_subarray.py * Update dynamic_programming/max_product_subarray.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update max_product_subarray.py * Update max_product_subarray.py * Update max_product_subarray.py * Update max_product_subarray.py * Update max_product_subarray.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update max_product_subarray.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update max_product_subarray.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update max_product_subarray.py * Update max_product_subarray.py * Update dynamic_programming/max_product_subarray.py Co-authored-by: Christian Clauss <cclauss@me.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dynamic_programming/max_product_subarray.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update max_product_subarray.py --------- Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

added kadane's algorithm directory with one problem's solution.
6209eb7

algorithms-keeperBot added awaiting reviews This PR is ready to be reviewed require type hints https://docs.python.org/3/library/typing.html labels Mar 29, 2023

algorithms-keeperBot reviewed Mar 29, 2023
View reviewed changes

Comment threadkadane_algorithm/max_product_subarray.py Outdated

rohan472000 changed the title ~~added kadane's algorithm directory with one problem's solution.~~added kadane's algorithm directory with a problem and its solution.Mar 29, 2023

added type hints
767b1d0

algorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Mar 29, 2023

tianyizheng02 requested changes Mar 30, 2023
View reviewed changes

Rename kaadne_algorithm/max_product_subarray.py to dynamic_programmin…
a5ea4b2
…g/max_product_subarray.py

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Mar 30, 2023

rohan472000 changed the title ~~added kadane's algorithm directory with a problem and its solution.~~added a problem on kadane's algo and its solution.Mar 30, 2023

cclauss requested changes Mar 30, 2023
View reviewed changes

algorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Mar 30, 2023

Update dynamic_programming/max_product_subarray.py
28b4406
Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Mar 30, 2023

rohan472000and others added 4 commits March 30, 2023 11:48

Update max_product_subarray.py
71ceff4

Update max_product_subarray.py
0a6d492

Update dynamic_programming/max_product_subarray.py
0d4a9aa
Co-authored-by: Christian Clauss <cclauss@me.com>

Update max_product_subarray.py
b841831

algorithms-keeperBot reviewed Mar 30, 2023
View reviewed changes

Comment threaddynamic_programming/max_product_subarray.py

Update max_product_subarray.py
88aeeba

algorithms-keeperBot reviewed Mar 30, 2023
View reviewed changes

Comment threaddynamic_programming/max_product_subarray.py

Update max_product_subarray.py
caea207

cclauss requested changes Mar 30, 2023
View reviewed changes

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Mar 30, 2023

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Mar 30, 2023

rohan472000and others added 2 commits March 30, 2023 12:22

Update max_product_subarray.py
39ac3cb

[pre-commit.ci] auto fixes from pre-commit.com hooks
ea6a16c
for more information, see https://pre-commit.ci

cclauss reviewed Mar 30, 2023
View reviewed changes

Comment threaddynamic_programming/max_product_subarray.py Outdated

rohan472000and others added 2 commits March 30, 2023 12:50

Update max_product_subarray.py
45e5d97

[pre-commit.ci] auto fixes from pre-commit.com hooks
9e3d158
for more information, see https://pre-commit.ci

rohan472000and others added 4 commits March 30, 2023 16:58

Update max_product_subarray.py
5fa1095

[pre-commit.ci] auto fixes from pre-commit.com hooks
12eb7e4
for more information, see https://pre-commit.ci

Update max_product_subarray.py
dc92eb7

Update max_product_subarray.py
58df091

cclauss reviewed Mar 31, 2023
View reviewed changes

Comment threaddynamic_programming/max_product_subarray.py Outdated

Update dynamic_programming/max_product_subarray.py
889163b
Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss reviewed Mar 31, 2023
View reviewed changes

Comment threaddynamic_programming/max_product_subarray.py Outdated

pre-commit-ciBotand others added 2 commits March 31, 2023 10:54

[pre-commit.ci] auto fixes from pre-commit.com hooks
3fc72c3
for more information, see https://pre-commit.ci

Update dynamic_programming/max_product_subarray.py
87880bb
Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Mar 31, 2023

Update max_product_subarray.py
5437ee3

cclauss approved these changes Mar 31, 2023
View reviewed changes

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Mar 31, 2023

cclauss merged commit a004929 into TheAlgorithms:masterMar 31, 2023

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

-n=len(nums)
-ifn==0:
-return0
+ifnotnumbers:
+return0

-max_till_now=nums[0]
-min_till_now=nums[0]
-max_prod=nums[0]
+max_till_now=min_till_now=max_prod=numbers[0]

-ifnums[i] <0:
-max_till_now, min_till_now=min_till_now, max_till_now
-max_till_now=max(nums[i], max_till_now*nums[i])
-min_till_now=min(nums[i], min_till_now*nums[i])
+number=numbers[i]
+ifnumber<0:
+max_till_now, min_till_now=min_till_now, max_till_now
+max_till_now=max(number, max_till_now*number])
+min_till_now=min(number, min_till_now*number)

-ifnumbersisNoneornotisinstance(numbers, list):
-return0
-n=len(numbers)
-ifn==0:
-return0
-ifnotall(isinstance(x, int) forxinnumbers):
-return0
+ifnotnumbers:
+return0
+ifnotisinstance(numbers, (list, set, tuple)) ornotall(isinstance(number, int) fornumberinnumbers):
+raiseTypeError("numbers must be an iterable of integers")

Uh oh!

Uh oh!

Conversation

rohan472000 commented Mar 29, 2023• edited by cclauss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

algorithms-keeperBot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

tianyizheng02 left a comment

Choose a reason for hiding this comment

Uh oh!

rohan472000 commented Mar 30, 2023

Uh oh!

tianyizheng02 commented Mar 30, 2023

Uh oh!

rohan472000 commented Mar 30, 2023

Uh oh!

cclaussMar 30, 2023

Choose a reason for hiding this comment

Uh oh!

rohan472000Mar 30, 2023

Choose a reason for hiding this comment

Uh oh!

cclaussMar 30, 2023

Choose a reason for hiding this comment

Uh oh!

rohan472000Mar 30, 2023

Choose a reason for hiding this comment

Uh oh!

cclaussMar 30, 2023

Choose a reason for hiding this comment

Uh oh!

cclaussMar 30, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cclaussMar 30, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

algorithms-keeperBot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

algorithms-keeperBot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

cclaussMar 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rohan472000 commented Mar 30, 2023

Uh oh!

cclauss commented Mar 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohan472000 commented Mar 30, 2023

rohan472000 commented Mar 29, 2023•
edited by cclauss
Loading

cclaussMar 30, 2023•
edited
Loading

cclauss commented Mar 30, 2023•
edited
Loading

cclauss commented Mar 30, 2023•
edited
Loading