') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Reduce the complexity of boolean_algebra/quine_mc_cluskey.py by MaximSmolskiy · Pull Request #8604 · TheAlgorithms/Python · GitHub
Skip to content

Reduce the complexity of boolean_algebra/quine_mc_cluskey.py - #8604

Merged
tianyizheng02 merged 7 commits into
TheAlgorithms:masterfrom
MaximSmolskiy:reduce-the-complexity-of-boolean_algebra/quine_mc_cluskey.py
Aug 15, 2023
Merged

Reduce the complexity of boolean_algebra/quine_mc_cluskey.py#8604
tianyizheng02 merged 7 commits into
TheAlgorithms:masterfrom
MaximSmolskiy:reduce-the-complexity-of-boolean_algebra/quine_mc_cluskey.py

Conversation

@MaximSmolskiy

@MaximSmolskiyMaximSmolskiy commented Apr 1, 2023

Copy link
Copy Markdown
Member

Describe your change:

Reduce the complexity of boolean_algebra/quine_mc_cluskey.py from 17 to 13

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Apr 1, 2023
@MaximSmolskiyMaximSmolskiy changed the title Reduce the complexity of boolean algebra/quine mc cluskey.pyReduce the complexity of boolean_algebra/quine_mc_cluskey.pyApr 1, 2023
@MaximSmolskiy

MaximSmolskiy commented May 27, 2023

Copy link
Copy Markdown
MemberAuthor

@cclauss please review

cclauss
cclauss reviewed May 28, 2023
View reviewed changes
Comment threadboolean_algebra/quine_mc_cluskey.py
cclauss
cclauss previously requested changes Jun 29, 2023
View reviewed changes
Comment threadboolean_algebra/quine_mc_cluskey.py Outdated
Comment threadboolean_algebra/quine_mc_cluskey.py Outdated
Comment threadboolean_algebra/quine_mc_cluskey.py Outdated
Comment threadboolean_algebra/quine_mc_cluskey.py
Comment threadboolean_algebra/quine_mc_cluskey.py Outdated
Comment threadboolean_algebra/quine_mc_cluskey.py
tianyizheng02
tianyizheng02 requested changes Aug 13, 2023
View reviewed changes

@tianyizheng02tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good, and I only have a couple of minor suggestions. However, I noticed a number of issues elsewhere in the code (not related to your changes) that require refactoring and renaming some things. I don't want to hold this PR up, so it's probably best that I address those issues in a later PR.

Comment threadboolean_algebra/quine_mc_cluskey.py Outdated
Comment threadboolean_algebra/quine_mc_cluskey.py Outdated
@tianyizheng02
tianyizheng02 dismissed cclauss’s stale reviewAugust 15, 2023 23:10

Most review suggestions have already been applied

@tianyizheng02
tianyizheng02 merged commit f66568e into TheAlgorithms:masterAug 15, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Aug 15, 2023
@MaximSmolskiy
MaximSmolskiy deleted the reduce-the-complexity-of-boolean_algebra/quine_mc_cluskey.py branch August 15, 2023 23:13
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes
@cclausscclaussAwaiting requested review from cclauss

Assignees

No one assigned

Labels

enhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximSmolskiy@cclauss@tianyizheng02