Skip to content

Create apparent_power.py - #8664

Merged
cclauss merged 16 commits into
TheAlgorithms:masterfrom
rohan472000:patch-5
Apr 18, 2023
Merged

Create apparent_power.py#8664
cclauss merged 16 commits into
TheAlgorithms:masterfrom
rohan472000:patch-5

Conversation

@rohan472000

@rohan472000rohan472000 commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Apr 17, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Apr 17, 2023
@rohan472000rohan472000 mentioned this pull request Apr 17, 2023
Closed
cclauss
cclauss reviewed Apr 17, 2023
View reviewed changes
Comment threadelectronics/apparent_power.py Outdated
cclauss
cclauss reviewed Apr 17, 2023
View reviewed changes
Comment threadelectronics/apparent_power.py Outdated
cclauss
cclauss reviewed Apr 17, 2023
View reviewed changes
Comment threadelectronics/apparent_power.py Outdated
rohan472000and others added 3 commits April 18, 2023 00:29
@rohan472000@cclauss
Update electronics/apparent_power.py
ecc1c4f
Co-authored-by: Christian Clauss <cclauss@me.com>
@rohan472000@cclauss
Update electronics/apparent_power.py
811a2db
Co-authored-by: Christian Clauss <cclauss@me.com>
@rohan472000
Update apparent_power.py
5703541
cclauss
cclauss requested changes Apr 17, 2023
View reviewed changes
Comment threadelectronics/apparent_power.py Outdated
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Apr 17, 2023
@rohan472000@cclauss
Update electronics/apparent_power.py
9430cdb
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Apr 17, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Apr 17, 2023
@EngineerMarek

EngineerMarek commented Apr 17, 2023

Copy link
Copy Markdown

Shouldn't we call this something like abs_apparent_power? This is only the absolute value of apparent power calculated from the pythagorean theorem, but it does not include the phase. Though I don't know how you guys would like to implement complex numbers for that or if there is already an implementation/a standart for that

@cclauss

cclauss commented Apr 17, 2023

Copy link
Copy Markdown
Member

Or should we raise ValueError("real_power must not be negative")

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Apr 18, 2023
@rohan472000

rohan472000 commented Apr 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Shouldn't we call this something like abs_apparent_power? This is only the absolute value of apparent power calculated from the pythagorean theorem, but it does not include the phase. Though I don't know how you guys would like to implement complex numbers for that or if there is already an implementation/a standart for that

I tried to implement that, have a look.

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Apr 18, 2023
cclauss
cclauss reviewed Apr 18, 2023
View reviewed changes
Comment threadelectronics/apparent_power.py Outdated
cclauss
cclauss reviewed Apr 18, 2023
View reviewed changes
Comment threadelectronics/apparent_power.py Outdated
cclauss
cclauss approved these changes Apr 18, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks for your contribution.

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Apr 18, 2023
@cclauss
cclauss merged commit b5047cf into TheAlgorithms:masterApr 18, 2023
@rohan472000

rohan472000 commented Apr 18, 2023

Copy link
Copy Markdown
ContributorAuthor

The one thing that I forgot to ask for is a URL to a Wikipedia article or some other source that explains the algorithm and where/when it should be used. This can be a great help to visitors to our repo. If you create a pull request that adds https://en.wikipedia.org/wiki/AC_power#Apparent_power or something similar to the docstring then I will gladly review it.

sure...done that, please have a look.

tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@rohan472000@pre-commit-ci
@cclauss@tianyizheng02
Create apparent_power.py (TheAlgorithms#8664)
772f26c
* Create apparent_power.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update apparent_power.py
* Update apparent_power.py
* Update apparent_power.py
* Update electronics/apparent_power.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update electronics/apparent_power.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update apparent_power.py
* Update electronics/apparent_power.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update apparent_power.py
* Update apparent_power.py
* Update apparent_power.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update apparent_power.py
* Update apparent_power.py
* Update apparent_power.py
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohan472000@EngineerMarek@cclauss