Skip to content

Added minimum waiting time problem solution using greedy algorithm - #8701

Merged
cclauss merged 11 commits into
TheAlgorithms:masterfrom
Himanshutomar31:master
May 1, 2023
Merged

Added minimum waiting time problem solution using greedy algorithm#8701
cclauss merged 11 commits into
TheAlgorithms:masterfrom
Himanshutomar31:master

Conversation

@Himanshutomar31

@Himanshutomar31Himanshutomar31 commented Apr 29, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Apr 29, 2023
@algorithms-keeperalgorithms-keeperBot added the require type hints https://docs.python.org/3/library/typing.html label Apr 29, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Apr 29, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadgreedy_methods/minimum_waiting_time.py Outdated
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Apr 29, 2023
@algorithms-keeperalgorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Apr 29, 2023
rohan472000
rohan472000 suggested changes Apr 30, 2023
View reviewed changes
Comment threadgreedy_methods/minimum_waiting_time.py
amirsoroush
amirsoroush reviewed Apr 30, 2023
View reviewed changes

@amirsoroushamirsoroush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think the code is quite self-explanatory. We can remove those comments. If you decided to change the parameter's type hint, remember to change it in doc string as well.

Comment threadgreedy_methods/minimum_waiting_time.py Outdated
Comment threadgreedy_methods/minimum_waiting_time.py Outdated
@Himanshutomar31

Himanshutomar31 commented May 1, 2023

Copy link
Copy Markdown
ContributorAuthor

comment

Hi Amir, I have done the suggested changes, you can review them. Thanks!

@Himanshutomar31

Himanshutomar31 commented May 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Hello @cclauss , would you kindly review my pull request and merge it? Thank you!

cclauss
cclauss requested changes May 1, 2023
View reviewed changes
Comment threadgreedy_methods/minimum_waiting_time.py Outdated
Comment threadgreedy_methods/minimum_waiting_time.py
Comment threadgreedy_methods/minimum_waiting_time.py Outdated
Comment threadgreedy_methods/minimum_waiting_time.py Outdated
cclauss
cclauss reviewed May 1, 2023
View reviewed changes
Comment threadgreedy_methods/minimum_waiting_time.py
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label May 1, 2023
@cclauss
cclauss merged commit e966c5c into TheAlgorithms:masterMay 1, 2023
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@Himanshutomar31@pre-commit-ci@tianyizheng02
Added minimum waiting time problem solution using greedy algorithm (T…
4ce4dd5
…heAlgorithms#8701)
* Added minimum waiting time problem solution using greedy algorithm
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* ruff --fix
* Add type hints
* Added two more doc test
* Removed unnecessary comments
* updated type hints
* Updated the code as per the code review
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
+3 more reviewers
@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
@rohan472000rohan472000rohan472000 requested changes
@amirsoroushamirsoroushamirsoroush approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Himanshutomar31@cclauss@rohan472000@amirsoroush