Skip to content

Create count negative numbers in matrix algorithm - #8813

Merged
cclauss merged 21 commits into
TheAlgorithms:masterfrom
CaedenPH:create-count-negative-numbers-in-matrix
Jun 10, 2023
Merged

Create count negative numbers in matrix algorithm#8813
cclauss merged 21 commits into
TheAlgorithms:masterfrom
CaedenPH:create-count-negative-numbers-in-matrix

Conversation

@CaedenPH

@CaedenPHCaedenPH commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

Three implementations of this algorithm are implemented and benchmarked together with doctests

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeperalgorithms-keeperBot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Jun 8, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py Outdated
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot added the require tests Tests [doctest/unittest/pytest] are required label Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Jun 8, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@CaedenPH

CaedenPH commented Jun 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41
As shown, this benchmark function doesnt have doctests either

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Jun 8, 2023
@cclauss

cclauss commented Jun 9, 2023

Copy link
Copy Markdown
Member

When would we want to use this algorithm?

cclauss
cclauss reviewed Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py Outdated
@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order

@cclausscclaussJun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py Outdated
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH

CaedenPH commented Jun 9, 2023

Copy link
Copy Markdown
ContributorAuthor

When would we want to use this algorithm?

@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?
As far as I'm aware this repository is just about algorithms, not necessarily useful ones.

To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough

cclauss
cclauss requested changes Jun 10, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py Outdated
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py Outdated
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py Outdated
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py Outdated
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPHand others added 3 commits June 10, 2023 12:40
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions
github-actionsBotforce-pushed the create-count-negative-numbers-in-matrix branch 2 times, most recently from 0d8a616 to a55db73CompareJune 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeperBot reviewed Jun 10, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
algorithms-keeper[bot]
algorithms-keeperBot reviewed Jun 10, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jun 10, 2023
@CaedenPH
CaedenPH requested a review from cclaussJune 10, 2023 11:53
@CaedenPH

CaedenPH commented Jun 10, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss All changes have been implemented and tests are passing

@cclauss
cclauss enabled auto-merge (squash) June 10, 2023 12:17
cclauss
cclauss approved these changes Jun 10, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.

@cclauss
cclauss merged commit daa0c8f into TheAlgorithms:masterJun 10, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Jun 10, 2023
@cclauss

cclauss commented Jun 10, 2023

Copy link
Copy Markdown
Member

I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.

@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
+1 more reviewer
@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require testsTests [doctest/unittest/pytest] are required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH@cclauss
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Create count negative numbers in matrix algorithm by CaedenPH · Pull Request #8813 · TheAlgorithms/Python · GitHub
Skip to content
Create count negative numbers in matrix algorithm - #8813
Merged
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Jun 10, 2023
Merged
Create count negative numbers in matrix algorithm#8813
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Conversation
@CaedenPH
@CaedenPHCaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Three implementations of this algorithm are implemented and benchmarked together with doctests
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@CaedenPH
CaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41

As shown, this benchmark function doesnt have doctests either
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@cclauss
cclauss
commented
Jun 9, 2023

Copy link


Copy Markdown

Member
When would we want to use this algorithm?
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order
@cclausscclaussJun 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH
CaedenPH
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
When would we want to use this algorithm?
@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?

As far as I'm aware this repository is just about algorithms, not necessarily useful ones.
To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough
cclauss
cclauss
requested changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPHand others
added 3 commits
June 10, 2023 12:40
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions
github-actionsBotforce-pushed
the
create-count-negative-numbers-in-matrix
branch
2 times, most recently
from
0d8a616 to
a55db73CompareJune 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Jun 10, 2023
@CaedenPH
CaedenPH
requested a review
from cclaussJune 10, 2023 11:53
@CaedenPH
CaedenPH
commented
Jun 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss All changes have been implemented and tests are passing
@cclauss
cclauss
enabled auto-merge (squash)
June 10, 2023 12:17
cclauss
cclauss
approved these changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.
@cclauss
cclauss
merged commit daa0c8f
into
TheAlgorithms:masterJun 10, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 10, 2023
@cclauss
cclauss
commented
Jun 10, 2023

Copy link


Copy Markdown

Member
I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

require testsTests [doctest/unittest/pytest] are required

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Create count negative numbers in matrix algorithm by CaedenPH · Pull Request #8813 · TheAlgorithms/Python · GitHub
Skip to content
Create count negative numbers in matrix algorithm - #8813
Merged
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Jun 10, 2023
Merged
Create count negative numbers in matrix algorithm#8813
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Conversation
@CaedenPH
@CaedenPHCaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Three implementations of this algorithm are implemented and benchmarked together with doctests
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@CaedenPH
CaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41

As shown, this benchmark function doesnt have doctests either
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@cclauss
cclauss
commented
Jun 9, 2023

Copy link


Copy Markdown

Member
When would we want to use this algorithm?
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order
@cclausscclaussJun 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH
CaedenPH
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
When would we want to use this algorithm?
@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?

As far as I'm aware this repository is just about algorithms, not necessarily useful ones.
To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough
cclauss
cclauss
requested changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPHand others
added 3 commits
June 10, 2023 12:40
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions
github-actionsBotforce-pushed
the
create-count-negative-numbers-in-matrix
branch
2 times, most recently
from
0d8a616 to
a55db73CompareJune 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Jun 10, 2023
@CaedenPH
CaedenPH
requested a review
from cclaussJune 10, 2023 11:53
@CaedenPH
CaedenPH
commented
Jun 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss All changes have been implemented and tests are passing
@cclauss
cclauss
enabled auto-merge (squash)
June 10, 2023 12:17
cclauss
cclauss
approved these changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.
@cclauss
cclauss
merged commit daa0c8f
into
TheAlgorithms:masterJun 10, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 10, 2023
@cclauss
cclauss
commented
Jun 10, 2023

Copy link


Copy Markdown

Member
I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

require testsTests [doctest/unittest/pytest] are required

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Create count negative numbers in matrix algorithm by CaedenPH · Pull Request #8813 · TheAlgorithms/Python · GitHub
Skip to content
Create count negative numbers in matrix algorithm - #8813
Merged
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Jun 10, 2023
Merged
Create count negative numbers in matrix algorithm#8813
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Conversation
@CaedenPH
@CaedenPHCaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Three implementations of this algorithm are implemented and benchmarked together with doctests
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@CaedenPH
CaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41

As shown, this benchmark function doesnt have doctests either
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@cclauss
cclauss
commented
Jun 9, 2023

Copy link


Copy Markdown

Member
When would we want to use this algorithm?
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order
@cclausscclaussJun 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH
CaedenPH
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
When would we want to use this algorithm?
@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?

As far as I'm aware this repository is just about algorithms, not necessarily useful ones.
To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough
cclauss
cclauss
requested changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPHand others
added 3 commits
June 10, 2023 12:40
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions
github-actionsBotforce-pushed
the
create-count-negative-numbers-in-matrix
branch
2 times, most recently
from
0d8a616 to
a55db73CompareJune 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Jun 10, 2023
@CaedenPH
CaedenPH
requested a review
from cclaussJune 10, 2023 11:53
@CaedenPH
CaedenPH
commented
Jun 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss All changes have been implemented and tests are passing
@cclauss
cclauss
enabled auto-merge (squash)
June 10, 2023 12:17
cclauss
cclauss
approved these changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.
@cclauss
cclauss
merged commit daa0c8f
into
TheAlgorithms:masterJun 10, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 10, 2023
@cclauss
cclauss
commented
Jun 10, 2023

Copy link


Copy Markdown

Member
I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

require testsTests [doctest/unittest/pytest] are required

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Create count negative numbers in matrix algorithm by CaedenPH · Pull Request #8813 · TheAlgorithms/Python · GitHub
Skip to content
Create count negative numbers in matrix algorithm - #8813
Merged
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Jun 10, 2023
Merged
Create count negative numbers in matrix algorithm#8813
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Conversation
@CaedenPH
@CaedenPHCaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Three implementations of this algorithm are implemented and benchmarked together with doctests
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@CaedenPH
CaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41

As shown, this benchmark function doesnt have doctests either
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@cclauss
cclauss
commented
Jun 9, 2023

Copy link


Copy Markdown

Member
When would we want to use this algorithm?
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order
@cclausscclaussJun 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH
CaedenPH
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
When would we want to use this algorithm?
@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?

As far as I'm aware this repository is just about algorithms, not necessarily useful ones.
To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough
cclauss
cclauss
requested changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPHand others
added 3 commits
June 10, 2023 12:40
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions
github-actionsBotforce-pushed
the
create-count-negative-numbers-in-matrix
branch
2 times, most recently
from
0d8a616 to
a55db73CompareJune 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Jun 10, 2023
@CaedenPH
CaedenPH
requested a review
from cclaussJune 10, 2023 11:53
@CaedenPH
CaedenPH
commented
Jun 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss All changes have been implemented and tests are passing
@cclauss
cclauss
enabled auto-merge (squash)
June 10, 2023 12:17
cclauss
cclauss
approved these changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.
@cclauss
cclauss
merged commit daa0c8f
into
TheAlgorithms:masterJun 10, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 10, 2023
@cclauss
cclauss
commented
Jun 10, 2023

Copy link


Copy Markdown

Member
I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

require testsTests [doctest/unittest/pytest] are required

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Create count negative numbers in matrix algorithm by CaedenPH · Pull Request #8813 · TheAlgorithms/Python · GitHub
Skip to content
Create count negative numbers in matrix algorithm - #8813
Merged
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Jun 10, 2023
Merged
Create count negative numbers in matrix algorithm#8813
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Conversation
@CaedenPH
@CaedenPHCaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Three implementations of this algorithm are implemented and benchmarked together with doctests
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@CaedenPH
CaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41

As shown, this benchmark function doesnt have doctests either
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@cclauss
cclauss
commented
Jun 9, 2023

Copy link


Copy Markdown

Member
When would we want to use this algorithm?
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order
@cclausscclaussJun 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH
CaedenPH
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
When would we want to use this algorithm?
@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?

As far as I'm aware this repository is just about algorithms, not necessarily useful ones.
To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough
cclauss
cclauss
requested changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPHand others
added 3 commits
June 10, 2023 12:40
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions
github-actionsBotforce-pushed
the
create-count-negative-numbers-in-matrix
branch
2 times, most recently
from
0d8a616 to
a55db73CompareJune 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Jun 10, 2023
@CaedenPH
CaedenPH
requested a review
from cclaussJune 10, 2023 11:53
@CaedenPH
CaedenPH
commented
Jun 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss All changes have been implemented and tests are passing
@cclauss
cclauss
enabled auto-merge (squash)
June 10, 2023 12:17
cclauss
cclauss
approved these changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.
@cclauss
cclauss
merged commit daa0c8f
into
TheAlgorithms:masterJun 10, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 10, 2023
@cclauss
cclauss
commented
Jun 10, 2023

Copy link


Copy Markdown

Member
I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

require testsTests [doctest/unittest/pytest] are required

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Create count negative numbers in matrix algorithm by CaedenPH · Pull Request #8813 · TheAlgorithms/Python · GitHub
Skip to content
Create count negative numbers in matrix algorithm - #8813
Merged
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Jun 10, 2023
Merged
Create count negative numbers in matrix algorithm#8813
cclauss merged 21 commits into
TheAlgorithms:masterfrom 
CaedenPH:create-count-negative-numbers-in-matrix
Conversation
@CaedenPH
@CaedenPHCaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Three implementations of this algorithm are implemented and benchmarked together with doctests
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
removed

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Jun 8, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 8, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@CaedenPH
CaedenPH
commented
Jun 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Note this pr supposedly has lack of tests however the benchmark function shouldn't have doctests anyway
https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py#L41

As shown, this benchmark function doesnt have doctests either
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Jun 8, 2023
@cclauss
cclauss
commented
Jun 9, 2023

Copy link


Copy Markdown

Member
When would we want to use this algorithm?
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@@ -0,0 +1,164 @@
"""
Given an `m x n` matrix grid which is sorted in non-increasing order
@cclausscclaussJun 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a validate_matrix(matrix) function? We do not need to run it everywhere but we should have it if we want to validate test input.
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
02cd4f3
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Jun 9, 2023
View reviewed changes
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
63c5147
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH
CaedenPH
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
When would we want to use this algorithm?
@cclauss If you have a grid of sorted numbers in descending order in a matrix, this algorithm can be used to count the number of negative numbers. Not sure when someone would want to use it, but then again when would someone want to use the quine from other/quine?

As far as I'm aware this repository is just about algorithms, not necessarily useful ones.
To answer your previous comment about validating the matrix, I don't think that is necessary. For searches that require sorted arrays, there aren't checks to ensure that those arrays are sorted so I think indicating that the matrix must be sorted is good enough
cclauss
cclauss
requested changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking cool!!
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
Outdated

@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
a55db73
Co-authored-by: Christian Clauss <cclauss@me.com>
CaedenPHand others
added 3 commits
June 10, 2023 12:40
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
0d8a616
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
9a7719c
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH@cclauss
Update matrix/count_negative_numbers_in_sorted_matrix.py
7a2f01e
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions
github-actionsBotforce-pushed
the
create-count-negative-numbers-in-matrix
branch
2 times, most recently
from
0d8a616 to
a55db73CompareJune 10, 2023 11:41
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Jun 10, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmatrix/count_negative_numbers_in_sorted_matrix.py
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Jun 10, 2023
@CaedenPH
CaedenPH
requested a review
from cclaussJune 10, 2023 11:53
@CaedenPH
CaedenPH
commented
Jun 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss All changes have been implemented and tests are passing
@cclauss
cclauss
enabled auto-merge (squash)
June 10, 2023 12:17
cclauss
cclauss
approved these changes
Jun 10, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.
@cclauss
cclauss
merged commit daa0c8f
into
TheAlgorithms:masterJun 10, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Jun 10, 2023
@cclauss
cclauss
commented
Jun 10, 2023

Copy link


Copy Markdown

Member
I have never figured out https://docs.python.org/3/library/bisect.html but it would be interesting to benchmark against an implementation that leveraged it.
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

require testsTests [doctest/unittest/pytest] are required

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH@cclauss