Skip to content

Add Docker devcontainer configuration files - #8887

Merged
cclauss merged 11 commits into
TheAlgorithms:masterfrom
HManiac74:master
Jul 25, 2023
Merged

Add Docker devcontainer configuration files#8887
cclauss merged 11 commits into
TheAlgorithms:masterfrom
HManiac74:master

Conversation

@HManiac74

Copy link
Copy Markdown
Contributor

Added configuration files for running the repo in a Docker dev Container

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Jul 23, 2023

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have GitPod... Why is this any better than that?

We run on Python 3.11 so please upgrade from bullseye to bookworm and remove all comments about Python < 3.11.

Remove all the comments about Node.js because this repo has none of that.

Comment thread.devcontainer/devcontainer.json Outdated
Comment thread.devcontainer/devcontainer.json
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jul 23, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Jul 25, 2023
Comment threadrequirements.txt Outdated
Comment thread.devcontainer/Dockerfile Outdated
Comment thread.devcontainer/devcontainer.json
Comment thread.devcontainer/devcontainer.json Outdated
"extensions": [
"ms-python.python",
"ms-python.vscode-pylance"
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR, it would be cool to add... https://github.com/astral-sh/ruff-vscode

@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jul 25, 2023
HManiac74and others added 2 commits July 25, 2023 17:50
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Jul 25, 2023
@cclausscclauss changed the title Adel Docker devcontainer configuration filesAdd Docker devcontainer configuration filesJul 25, 2023
Comment thread.devcontainer/Dockerfile

@CaedenPHCaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As cclauss mentioned, we have a gitpod config file, and I don't see much value in adding devcontainer config files, primarily due to the fact that this is unlike other repositories, and that it is a group of standalone files that don't require much, if any config
This also only customises for a singular tool, vscode, excluding other text editors/IDE's
Even still, if this is decided to be merged, perhaps it would be ideal to add information on how to set up this container in the CONTRIBUTING.md

@HManiac74

Copy link
Copy Markdown
ContributorAuthor

Some people might prefer a local development container, and VSCode is a very good IDE, and platform independent, so I thought this might be a good idea

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this AND GitPod can cohabitate without nullifying each other. Contributors can choose their favorite.

Let's reserve the right to revert this contribution if users protest or if it does not bring sufficient value.

@CaedenPH is correct that we need docs in CONTRIBUTING.md so @HManiac74 please create a follow-on PR that helps folks to get started.

@cclauss
cclauss merged commit b77e6ad into TheAlgorithms:masterJul 25, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewsThis PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HManiac74@cclauss@CaedenPH