Skip to content

Added functions to calculate temperature of an ideal gas and number o… - #8919

Merged
tianyizheng02 merged 8 commits into
TheAlgorithms:masterfrom
robertjcalistri:ideal-gas-law
Aug 14, 2023
Merged

Added functions to calculate temperature of an ideal gas and number o…#8919
tianyizheng02 merged 8 commits into
TheAlgorithms:masterfrom
robertjcalistri:ideal-gas-law

Conversation

@robertjcalistri

@robertjcalistrirobertjcalistri commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

…f moles of an ideal gas

Describe your change:

  • [ X] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Aug 2, 2023
tianyizheng02
tianyizheng02 requested changes Aug 3, 2023
View reviewed changes
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py Outdated
Comment threadphysics/ideal_gas_law.py Outdated
robertjcalistriand others added 2 commits August 3, 2023 08:11
@robertjcalistri@tianyizheng02
Update physics/ideal_gas_law.py
2beb207
Renamed function name
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@robertjcalistri@tianyizheng02
Update physics/ideal_gas_law.py
a2d6d5b
Updated formatting
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Aug 3, 2023
robertjcalistriand others added 3 commits August 3, 2023 08:13
@robertjcalistri@tianyizheng02
Update physics/ideal_gas_law.py
c8c29e9
Removed unnecessary parentheses
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@robertjcalistri@tianyizheng02
Update physics/ideal_gas_law.py
b637591
Removed unnecessary parentheses
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@robertjcalistri
Update ideal_gas_law.py
5ce54f2
Updated incorrect function calls moles of gas system doctests
tianyizheng02
tianyizheng02 approved these changes Aug 14, 2023
View reviewed changes

@tianyizheng02tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor formatting nitpick, but other than that, LGTM

Comment threadphysics/ideal_gas_law.py Outdated
@tianyizheng02
tianyizheng02 merged commit 2ab3bf2 into TheAlgorithms:masterAug 14, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Aug 14, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robertjcalistri@tianyizheng02