') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update run.py in machine_learning/forecasting by p1utoze · Pull Request #8957 · TheAlgorithms/Python · GitHub
Skip to content

Update run.py in machine_learning/forecasting - #8957

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
p1utoze:branch
Aug 14, 2023
Merged

Update run.py in machine_learning/forecasting#8957
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
p1utoze:branch

Conversation

@p1utoze

@p1utozep1utoze commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

…tion

Describe your change:

Fixes [#7305]

I have modified the run.py and it runs without any errors locally.

  • Removed headers argument from read_csv as it caused errors in Normalization.
  • Renamed the train and test column variables as it wasn't easily comprehensible
  • Added a Type check condition in case of passing wrong type as arguments in data_safety_checker function.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@tianyizheng02

tianyizheng02 commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Your PR doesn't actually fix #7305 because the Pytest warnings are still present in the build logs:

machine_learning/forecasting/run.py::machine_learning.forecasting.run.sarimax_predictor
/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/statsmodels/tsa/statespace/sarimax.py:866: UserWarning: Too few observations to estimate starting parameters for ARMA and trend. All parameters except for variances will be set to zeros.
warn('Too few observations to estimate starting parameters%s.'
machine_learning/forecasting/run.py::machine_learning.forecasting.run.sarimax_predictor
/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/statsmodels/tsa/statespace/sarimax.py:866: UserWarning: Too few observations to estimate starting parameters for seasonal ARMA. All parameters except for variances will be set to zeros.
warn('Too few observations to estimate starting parameters%s.'
machine_learning/forecasting/run.py::machine_learning.forecasting.run.sarimax_predictor
/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/numpy/core/fromnumeric.py:3747: RuntimeWarning: Degrees of freedom <= 0 for slice
return _methods._var(a, axis=axis, dtype=dtype, out=out, ddof=ddof,
machine_learning/forecasting/run.py::machine_learning.forecasting.run.sarimax_predictor
/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/numpy/core/_methods.py:226: RuntimeWarning: invalid value encountered in divide
arrmean = um.true_divide(arrmean, div, out=arrmean,
machine_learning/forecasting/run.py::machine_learning.forecasting.run.sarimax_predictor
/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/numpy/core/_methods.py:261: RuntimeWarning: invalid value encountered in scalar divide
ret = ret.dtype.type(ret / rcount)

However, your changes are still good, so we can merge this PR anyway after some minor tweaks

tianyizheng02
tianyizheng02 requested changes Aug 14, 2023
View reviewed changes

@tianyizheng02tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes, just need to clean up the old code and it should be good

Comment threadmachine_learning/forecasting/run.py Outdated
Comment on lines +122 to +125
# data_input = [[18231, 0.0, 1], [22621, 1.0, 2], [15675, 0.0, 3], [23583, 1.0, 4]]
# data_input_df = pd.DataFrame(
# data_input, columns=["total_user", "total_even", "days"]
# )

@tianyizheng02tianyizheng02Aug 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# data_input = [[18231, 0.0, 1], [22621, 1.0, 2], [15675, 0.0, 3], [23583, 1.0, 4]]
# data_input_df = pd.DataFrame(
# data_input, columns=["total_user", "total_even", "days"]
# )

Let's just delete the old code rather than commenting it out

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Aug 14, 2023
@p1utoze

p1utoze commented Aug 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Sure, I'll update the code formatting.
Regarding the Pytest Warnings, I looked into the source of the error and it might be due to ARIMA deprecation.
Two approaches from mine would be to either transform the data passed to SARIMAX model for estimation or supress the warnings should be well enough.

tianyizheng02
tianyizheng02 approved these changes Aug 14, 2023
View reviewed changes

@tianyizheng02tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianyizheng02
tianyizheng02 merged commit c290dd6 into TheAlgorithms:masterAug 14, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Aug 14, 2023
@tianyizheng02

tianyizheng02 commented Aug 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Sure, I'll update the code formatting. Regarding the Pytest Warnings, I looked into the source of the error and it might be due to ARIMA deprecation. Two approaches from mine would be to either transform the data passed to SARIMAX model for estimation or supress the warnings should be well enough.

@p1utoze At first glance, it looks to me like some of the errors are caused by the small number of observations (which makes sense, the ARIMA models probably need way more observations to work well). Maybe reworking this file to use a different CSV file (one with much more data) might fix some if not all of the warnings.

That's all work for a future PR, though.

@p1utoze

p1utoze commented Aug 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Hey! I finally fixed the warnings. The numpy Runtime warning was due to the 0 in seasonal_order tuple and regarding the ARIMA models. Yes you are right, it needs more observations to work well and the User Warning are raised because of the sample test >>> sarimax_predictor([4,2,6,8], [3,1,2,4], [2]) used by doctests. Supressing it should be fine enough. Shall I create another PR then?

@tianyizheng02

tianyizheng02 commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Yeah, that'd be great, thanks!

@p1utoze
p1utoze deleted the branch branch August 14, 2023 07:36
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@p1utoze@tianyizheng02