Skip to content

Created harshad_numbers.py - #9023

Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom
davidekong:master
Sep 6, 2023
Merged

Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom
davidekong:master

Conversation

@davidekong

@davidekongdavidekong commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Aug 31, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py Outdated
"""


def int_to_base(number, base_of_interest):

@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base

Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:

Please provide type hint for the parameter: number

Please provide type hint for the parameter: base_of_interest

Comment threadmaths/harshad_numbers.py Outdated
return result


def sum_of_digits(num: int, base_of_interest: int):

@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:

Comment threadmaths/harshad_numbers.py Outdated
return res


def all_harshad_numbers(num: int, base_of_interest: int):

@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:

Comment threadmaths/harshad_numbers.py Outdated
return result, numbers


def is_harshad_number(num: int, base_of_interest: int):

@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:

@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Aug 31, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py Outdated
from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:

@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot reviewed Aug 31, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py Outdated
"""


def int_to_base(number: int, base_of_interest: int) -> str:

@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot reviewed Aug 31, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py Outdated
"""


def int_to_base(number: int, base_of_interest: int) -> str:

@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base

@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot reviewed Aug 31, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py Outdated
tianyizheng02
tianyizheng02 requested changes Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py Outdated
@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.

@tianyizheng02tianyizheng02Sep 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:

  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.

Comment threadmaths/harshad_numbers.py Outdated
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py Outdated
Comment threadmaths/harshad_numbers.py Outdated
Comment on lines +49 to +51
res = 0
for char in num_str:
res += int(char, base_of_interest)

@tianyizheng02tianyizheng02Sep 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)

Comment threadmaths/harshad_numbers.py Outdated
Comment threadmaths/harshad_numbers.py Outdated
Comment threadmaths/harshad_numbers.py Outdated
davidekongand others added 2 commits September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Sep 5, 2023
davidekongand others added 2 commits September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot reviewed Sep 5, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot reviewed Sep 5, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot reviewed Sep 5, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot reviewed Sep 5, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot reviewed Sep 5, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot reviewed Sep 6, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Sep 6, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02 requested changes Sep 6, 2023
View reviewed changes

@tianyizheng02tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py Outdated
Comment on lines +49 to +50
if (base > 36) or (base < 2):
raise ValueError("'base' must be between 36 and 2 inclusive")

@tianyizheng02tianyizheng02Sep 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")

Parentheses are unnecessary, and it's kinda strange to read the range backward

Comment threadmaths/harshad_numbers.py Outdated
Comment on lines +53 to +55
res = 0
for char in num_str:
res += int(char, base)

@tianyizheng02tianyizheng02Sep 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)

Let's avoid manually looping when possible

Comment threadmaths/harshad_numbers.py Outdated
Comment on lines +83 to +84
if (base > 36) or (base < 2):
raise ValueError("'base' must be between 36 and 2 inclusive")

@tianyizheng02tianyizheng02Sep 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")

See previous comment

Comment threadmaths/harshad_numbers.py Outdated
Comment on lines +86 to +91
numbers = []
if limit >= 0:
for i in range(1, limit):
y = sum_of_digits(i, base)
if i % int(y, base) == 0:
numbers.append(int_to_base(i, base))

@tianyizheng02tianyizheng02Sep 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
]

Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)

Comment threadmaths/harshad_numbers.py Outdated
Comment on lines +119 to +120
if (base > 36) or (base < 2):
raise ValueError("'base' must be between 36 and 2 inclusive")

@tianyizheng02tianyizheng02Sep 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")

@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot removed the require tests Tests [doctest/unittest/pytest] are required label Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Sep 6, 2023
@tianyizheng02
tianyizheng02 merged commit 9e4f996 into TheAlgorithms:masterSep 6, 2023
@tianyizheng02

tianyizheng02 commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes
+1 more reviewer
@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Created harshad_numbers.py by davidekong · Pull Request #9023 · TheAlgorithms/Python · GitHub
Skip to content
Created harshad_numbers.py - #9023
Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Sep 6, 2023
Merged
Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Conversation
@davidekong
@davidekongdavidekong
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number, base_of_interest):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
Comment threadmaths/harshad_numbers.py
Outdated

 return result


def sum_of_digits(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return res


def all_harshad_numbers(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return result, numbers


def is_harshad_number(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

tests are failing
Do not merge until tests pass
labels
Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot
removed
the 
require type hints
https://docs.python.org/3/library/typing.html
label
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py
Outdated

@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+51

 res = 0
 for char in num_str:
 res += int(char, base_of_interest)
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

davidekongand others
added 2 commits
September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 5, 2023
davidekongand others
added 2 commits
September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02
requested changes
Sep 6, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+50

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
Parentheses are unnecessary, and it's kinda strange to read the range backward
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+53
 to 
+55

 res = 0
 for char in num_str:
 res += int(char, base)
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)
Let's avoid manually looping when possible
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+83
 to 
+84

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
See previous comment
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+86
 to 
+91

 numbers = []
 if limit >= 0:
 for i in range(1, limit):
 y = sum_of_digits(i, base)
 if i % int(y, base) == 0:
 numbers.append(int_to_base(i, base))
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
 ]
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+119
 to 
+120

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
@tianyizheng02
tianyizheng02
merged commit 9e4f996
into
TheAlgorithms:masterSep 6, 2023
@tianyizheng02
tianyizheng02
commented
Sep 6, 2023

Copy link


Copy Markdown

Contributor
Thanks for your contribution!
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Created harshad_numbers.py by davidekong · Pull Request #9023 · TheAlgorithms/Python · GitHub
Skip to content
Created harshad_numbers.py - #9023
Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Sep 6, 2023
Merged
Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Conversation
@davidekong
@davidekongdavidekong
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number, base_of_interest):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
Comment threadmaths/harshad_numbers.py
Outdated

 return result


def sum_of_digits(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return res


def all_harshad_numbers(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return result, numbers


def is_harshad_number(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

tests are failing
Do not merge until tests pass
labels
Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot
removed
the 
require type hints
https://docs.python.org/3/library/typing.html
label
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py
Outdated

@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+51

 res = 0
 for char in num_str:
 res += int(char, base_of_interest)
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

davidekongand others
added 2 commits
September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 5, 2023
davidekongand others
added 2 commits
September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02
requested changes
Sep 6, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+50

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
Parentheses are unnecessary, and it's kinda strange to read the range backward
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+53
 to 
+55

 res = 0
 for char in num_str:
 res += int(char, base)
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)
Let's avoid manually looping when possible
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+83
 to 
+84

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
See previous comment
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+86
 to 
+91

 numbers = []
 if limit >= 0:
 for i in range(1, limit):
 y = sum_of_digits(i, base)
 if i % int(y, base) == 0:
 numbers.append(int_to_base(i, base))
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
 ]
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+119
 to 
+120

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
@tianyizheng02
tianyizheng02
merged commit 9e4f996
into
TheAlgorithms:masterSep 6, 2023
@tianyizheng02
tianyizheng02
commented
Sep 6, 2023

Copy link


Copy Markdown

Contributor
Thanks for your contribution!
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Created harshad_numbers.py by davidekong · Pull Request #9023 · TheAlgorithms/Python · GitHub
Skip to content
Created harshad_numbers.py - #9023
Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Sep 6, 2023
Merged
Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Conversation
@davidekong
@davidekongdavidekong
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number, base_of_interest):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
Comment threadmaths/harshad_numbers.py
Outdated

 return result


def sum_of_digits(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return res


def all_harshad_numbers(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return result, numbers


def is_harshad_number(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

tests are failing
Do not merge until tests pass
labels
Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot
removed
the 
require type hints
https://docs.python.org/3/library/typing.html
label
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py
Outdated

@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+51

 res = 0
 for char in num_str:
 res += int(char, base_of_interest)
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

davidekongand others
added 2 commits
September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 5, 2023
davidekongand others
added 2 commits
September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02
requested changes
Sep 6, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+50

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
Parentheses are unnecessary, and it's kinda strange to read the range backward
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+53
 to 
+55

 res = 0
 for char in num_str:
 res += int(char, base)
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)
Let's avoid manually looping when possible
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+83
 to 
+84

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
See previous comment
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+86
 to 
+91

 numbers = []
 if limit >= 0:
 for i in range(1, limit):
 y = sum_of_digits(i, base)
 if i % int(y, base) == 0:
 numbers.append(int_to_base(i, base))
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
 ]
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+119
 to 
+120

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
@tianyizheng02
tianyizheng02
merged commit 9e4f996
into
TheAlgorithms:masterSep 6, 2023
@tianyizheng02
tianyizheng02
commented
Sep 6, 2023

Copy link


Copy Markdown

Contributor
Thanks for your contribution!
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Created harshad_numbers.py by davidekong · Pull Request #9023 · TheAlgorithms/Python · GitHub
Skip to content
Created harshad_numbers.py - #9023
Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Sep 6, 2023
Merged
Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Conversation
@davidekong
@davidekongdavidekong
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number, base_of_interest):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
Comment threadmaths/harshad_numbers.py
Outdated

 return result


def sum_of_digits(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return res


def all_harshad_numbers(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return result, numbers


def is_harshad_number(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

tests are failing
Do not merge until tests pass
labels
Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot
removed
the 
require type hints
https://docs.python.org/3/library/typing.html
label
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py
Outdated

@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+51

 res = 0
 for char in num_str:
 res += int(char, base_of_interest)
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

davidekongand others
added 2 commits
September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 5, 2023
davidekongand others
added 2 commits
September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02
requested changes
Sep 6, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+50

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
Parentheses are unnecessary, and it's kinda strange to read the range backward
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+53
 to 
+55

 res = 0
 for char in num_str:
 res += int(char, base)
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)
Let's avoid manually looping when possible
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+83
 to 
+84

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
See previous comment
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+86
 to 
+91

 numbers = []
 if limit >= 0:
 for i in range(1, limit):
 y = sum_of_digits(i, base)
 if i % int(y, base) == 0:
 numbers.append(int_to_base(i, base))
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
 ]
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+119
 to 
+120

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
@tianyizheng02
tianyizheng02
merged commit 9e4f996
into
TheAlgorithms:masterSep 6, 2023
@tianyizheng02
tianyizheng02
commented
Sep 6, 2023

Copy link


Copy Markdown

Contributor
Thanks for your contribution!
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Created harshad_numbers.py by davidekong · Pull Request #9023 · TheAlgorithms/Python · GitHub
Skip to content
Created harshad_numbers.py - #9023
Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Sep 6, 2023
Merged
Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Conversation
@davidekong
@davidekongdavidekong
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number, base_of_interest):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
Comment threadmaths/harshad_numbers.py
Outdated

 return result


def sum_of_digits(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return res


def all_harshad_numbers(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return result, numbers


def is_harshad_number(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

tests are failing
Do not merge until tests pass
labels
Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot
removed
the 
require type hints
https://docs.python.org/3/library/typing.html
label
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py
Outdated

@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+51

 res = 0
 for char in num_str:
 res += int(char, base_of_interest)
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

davidekongand others
added 2 commits
September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 5, 2023
davidekongand others
added 2 commits
September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02
requested changes
Sep 6, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+50

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
Parentheses are unnecessary, and it's kinda strange to read the range backward
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+53
 to 
+55

 res = 0
 for char in num_str:
 res += int(char, base)
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)
Let's avoid manually looping when possible
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+83
 to 
+84

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
See previous comment
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+86
 to 
+91

 numbers = []
 if limit >= 0:
 for i in range(1, limit):
 y = sum_of_digits(i, base)
 if i % int(y, base) == 0:
 numbers.append(int_to_base(i, base))
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
 ]
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+119
 to 
+120

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
@tianyizheng02
tianyizheng02
merged commit 9e4f996
into
TheAlgorithms:masterSep 6, 2023
@tianyizheng02
tianyizheng02
commented
Sep 6, 2023

Copy link


Copy Markdown

Contributor
Thanks for your contribution!
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Created harshad_numbers.py by davidekong · Pull Request #9023 · TheAlgorithms/Python · GitHub
Skip to content
Created harshad_numbers.py - #9023
Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Sep 6, 2023
Merged
Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Conversation
@davidekong
@davidekongdavidekong
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number, base_of_interest):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
Comment threadmaths/harshad_numbers.py
Outdated

 return result


def sum_of_digits(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return res


def all_harshad_numbers(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return result, numbers


def is_harshad_number(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

tests are failing
Do not merge until tests pass
labels
Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot
removed
the 
require type hints
https://docs.python.org/3/library/typing.html
label
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py
Outdated

@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+51

 res = 0
 for char in num_str:
 res += int(char, base_of_interest)
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

davidekongand others
added 2 commits
September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 5, 2023
davidekongand others
added 2 commits
September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02
requested changes
Sep 6, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+50

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
Parentheses are unnecessary, and it's kinda strange to read the range backward
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+53
 to 
+55

 res = 0
 for char in num_str:
 res += int(char, base)
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)
Let's avoid manually looping when possible
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+83
 to 
+84

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
See previous comment
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+86
 to 
+91

 numbers = []
 if limit >= 0:
 for i in range(1, limit):
 y = sum_of_digits(i, base)
 if i % int(y, base) == 0:
 numbers.append(int_to_base(i, base))
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
 ]
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+119
 to 
+120

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
@tianyizheng02
tianyizheng02
merged commit 9e4f996
into
TheAlgorithms:masterSep 6, 2023
@tianyizheng02
tianyizheng02
commented
Sep 6, 2023

Copy link


Copy Markdown

Contributor
Thanks for your contribution!
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Created harshad_numbers.py by davidekong · Pull Request #9023 · TheAlgorithms/Python · GitHub
Skip to content
Created harshad_numbers.py - #9023
Merged
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Sep 6, 2023
Merged
Created harshad_numbers.py#9023
tianyizheng02 merged 20 commits into
TheAlgorithms:masterfrom 
davidekong:master
Conversation
@davidekong
@davidekongdavidekong
commented
Aug 31, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
deec6d4
Fixed a few errors
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
require type hints
https://docs.python.org/3/library/typing.html
labels
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number, base_of_interest):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as:def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
Comment threadmaths/harshad_numbers.py
Outdated

 return result


def sum_of_digits(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return res


def all_harshad_numbers(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as:def function() -> None:
Comment threadmaths/harshad_numbers.py
Outdated

 return result, numbers


def is_harshad_number(num: int, base_of_interest: int):
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as:def function() -> None:
@algorithms-keeperalgorithms-keeperBot
added

awaiting reviews
This PR is ready to be reviewed
and removed

tests are failing
Do not merge until tests pass
labels
Aug 31, 2023
@davidekong
Update harshad_numbers.py
fcb5639
Added function type hints
@algorithms-keeperalgorithms-keeperBot
removed
the 
require type hints
https://docs.python.org/3/library/typing.html
label
Aug 31, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

from typing import Tuple, List


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
44eb286
Fixed depreciated Tuple and List usage
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Aug 31, 2023
@davidekong
Update harshad_numbers.py
ad09b82
Fixed incompatible types in assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

"""


def int_to_base(number: int, base_of_interest: int) -> str:
@algorithms-keeperalgorithms-keeperBotAug 31, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
@davidekong
Update harshad_numbers.py
3d00dad
Fixed incompatible type assignments
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Aug 31, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
Outdated

tianyizheng02
tianyizheng02
requested changes
Sep 5, 2023
View reviewed changes
Comment threadmaths/harshad_numbers.py
Outdated

@@ -0,0 +1,132 @@
"""
A Harshad number is divisible by the sum of its digits in any base n.
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
  1. "Harshad" should be lowercase ("harshad" is not a name).
  2. What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+51

 res = 0
 for char in num_str:
 res += int(char, base_of_interest)
@tianyizheng02tianyizheng02Sep 5, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base_of_interest)
res=sum(int(char, base_of_interest) forcharinnum_str)
Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

Comment threadmaths/harshad_numbers.py
Outdated

davidekongand others
added 2 commits
September 5, 2023 11:06
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
4d1a89c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
21a703d
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 5, 2023
davidekongand others
added 2 commits
September 5, 2023 19:24
@davidekong
Raised Value Error for negative inputs
1584436
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
7b9809c
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
03d0296
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@davidekong@tianyizheng02
Update maths/harshad_numbers.py
2974289
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 5, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Sep 6, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threadmaths/harshad_numbers.py
tianyizheng02
tianyizheng02
requested changes
Sep 6, 2023
View reviewed changes
@tianyizheng02tianyizheng02
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor refactoring suggestions, and make sure to add doctests to all functions
Comment threadmaths/harshad_numbers.py
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+49
 to 
+50

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
Parentheses are unnecessary, and it's kinda strange to read the range backward
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+53
 to 
+55

 res = 0
 for char in num_str:
 res += int(char, base)
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

res=0
forcharinnum_str:
res+=int(char, base)
res=sum(int(char, base) forcharinnum_str)
Let's avoid manually looping when possible
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+83
 to 
+84

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
See previous comment
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+86
 to 
+91

 numbers = []
 if limit >= 0:
 for i in range(1, limit):
 y = sum_of_digits(i, base)
 if i % int(y, base) == 0:
 numbers.append(int_to_base(i, base))
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

numbers= []
iflimit>=0:
foriinrange(1, limit):
y=sum_of_digits(i, base)
ifi%int(y, base) ==0:
numbers.append(int_to_base(i, base))
iflimit<0:
return []
numbers= [
int_to_base(i, base)
foriinrange(1, limit)
ifi%int(sum_of_digits(i, base), base) ==0
 ]
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
Comment threadmaths/harshad_numbers.py
Outdated


Comment on lines

+119
 to 
+120

 if (base > 36) or (base < 2):
 raise ValueError("'base' must be between 36 and 2 inclusive")
@tianyizheng02tianyizheng02Sep 6, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

if(base>36)or(base<2):
raiseValueError("'base' must be between 36 and 2 inclusive")
ifbase<2orbase>36:
raiseValueError("'base' must be between 2 and 36 inclusive")
@davidekong
Update harshad_numbers.py
8dbfa37
Added doc test to int_to_base, fixed nested loop, other minor changes
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Sep 6, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 6, 2023
@tianyizheng02
tianyizheng02
merged commit 9e4f996
into
TheAlgorithms:masterSep 6, 2023
@tianyizheng02
tianyizheng02
commented
Sep 6, 2023

Copy link


Copy Markdown

Contributor
Thanks for your contribution!
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewedtests are failingDo not merge until tests pass

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@davidekong@tianyizheng02