Add MFCC Feature Extraction Algorithm by AmirLavasani · Pull Request #9057 · TheAlgorithms/Python

AmirLavasani · 2023-09-12T08:24:30Z

Describe your change:

Added MFCC Audio Signal Feature Extraction Algorithm.

Fixes#9026

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

rohan472000 · 2023-09-13T14:21:32Z

Raised PR #9058.

Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

* updating DIRECTORY.md * updating DIRECTORY.md * Delete empty junk file * updating DIRECTORY.md * Fix ruff errors * Fix more ruff errors --------- Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Co-authored-by: Christian Clauss <cclauss@me.com>

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

* Remove types from docstring * Rename dct * Add mfcc docstring * Add typing to several functions

rohan472000 · 2023-09-23T08:55:50Z

@cclauss kindly open this PR as due to my mistake I mentioned it in FIX_ISSUES of #9078

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

rohan472000 · 2023-09-24T10:21:22Z

@cclauss kindly review it.

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-09-24T13:27:36Z

+ return filters
+
+
+def get_filter_points(


Please provide return type hint for the function: get_filter_points. If the function does not return a value, please provide the type hint as:def function() -> None:

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links
Repository:
Contributing guidelines
Project Euler solution guidelines
Python:
Formatted string literals (f-strings)
Type hints
doctest
unittest
pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review to trigger the checks for only added pull request files
@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-09-24T21:05:12Z

+ return basis
+
+
+def example(wav_file_path: str = "./path-to-file/sample.wav") -> np.ndarray:


As there is no test file in this pull request nor any test function or class in the file machine_learning/mfcc.py, please provide doctest for the function example

cclauss

Let's do this!! Thanks for your contribution.

AmirLavasani · 2023-09-25T05:24:28Z

Let's do this!! Thanks for your contribution.

I really appreciate your valuable code reviews, @cclauss. It's been a pleasure collaborating with you.

AmirLavasani added 2 commits September 12, 2023 11:39

Add MFCC feature extraction to machine learning
264bc13

Add standalone usage in comments
a1cb36c

AmirLavasani changed the title ~~Add MFCC feature extraction #9026~~Add MFCC feature extractionSep 12, 2023

AmirLavasani changed the title ~~Add MFCC feature extraction~~Add MFCC Feature Extraction AlgorithmSep 12, 2023

algorithms-keeperBot added the tests are failing Do not merge until tests pass label Sep 12, 2023

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

cclauss reviewed Sep 16, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

Apply suggestions from code review
68d2e11
Co-authored-by: Christian Clauss <cclauss@me.com>

algorithms-keeperBot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Sep 17, 2023

algorithms-keeperBot reviewed Sep 17, 2023
View reviewed changes

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Sep 17, 2023

tianyizheng02and others added 10 commits September 17, 2023 11:22

Delete empty junk file (TheAlgorithms#9062)
92d9748
* updating DIRECTORY.md * updating DIRECTORY.md * Delete empty junk file * updating DIRECTORY.md * Fix ruff errors * Fix more ruff errors --------- Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

[main] Fix typo due to auto review change
6c4f90b

Add doctests for all functions
1d843b5

Add MFCC feature extraction to machine learning
d14cc09

Add standalone usage in comments
088eaee

Apply suggestions from code review
554d52b
Co-authored-by: Christian Clauss <cclauss@me.com>

[main] Fix typo due to auto review change
f78fd1b

Add doctests for all functions
cb9d9df

[pre-commit.ci] auto fixes from pre-commit.com hooks
d6bdf63
for more information, see https://pre-commit.ci

Merge branch to resolve conflict
c960a23

algorithms-keeperBot reviewed Sep 17, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py
Comment threadmachine_learning/mfcc.py Outdated
Comment threadmachine_learning/mfcc.py Outdated
Comment threadmachine_learning/mfcc.py
Comment threadmachine_learning/mfcc.py Outdated

Update review issues
2fde552
* Remove types from docstring * Rename dct * Add mfcc docstring * Add typing to several functions

AmirLavasani requested a review from cclauss September 19, 2023 09:00

rohan472000 mentioned this pull request Sep 23, 2023
Update xgboost_regressor.py #9078
Merged
14 tasks

cclauss closed this in #9078 Sep 23, 2023

cclauss reopened this Sep 23, 2023

algorithms-keeperBot reviewed Sep 23, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py
Comment threadmachine_learning/mfcc.py

cclauss reviewed Sep 24, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated

cclauss requested changes Sep 24, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py Outdated
Comment threadmachine_learning/mfcc.py Outdated
Comment threadmachine_learning/mfcc.py Outdated
Comment threadmachine_learning/mfcc.py
Comment threadmachine_learning/mfcc.py

algorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Sep 24, 2023

Apply suggestions from code review
ad0eeef

algorithms-keeperBot reviewed Sep 24, 2023
View reviewed changes

algorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass labels Sep 24, 2023

Update mfcc.py
7e38bc3

algorithms-keeperBot reviewed Sep 24, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py
Comment threadmachine_learning/mfcc.py

get_filter_points() -> tuple[np.ndarray, np.ndarray]:
f410bf2

algorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Sep 24, 2023

algorithms-keeperBot reviewed Sep 24, 2023
View reviewed changes

Comment threadmachine_learning/mfcc.py

algorithm
e143e5b

algorithms-keeperBot reviewed Sep 24, 2023
View reviewed changes

cclauss enabled auto-merge (squash) September 24, 2023 21:05

cclauss approved these changes Sep 24, 2023
View reviewed changes

cclauss merged commit 211247e into TheAlgorithms:masterSep 24, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Sep 24, 2023

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

		return basis


		def example(wav_file_path: str = "./path-to-file/sample.wav") -> np.ndarray:

Uh oh!

Uh oh!

Conversation

AmirLavasani commented Sep 12, 2023

Describe your change:

Checklist:

Uh oh!

rohan472000 commented Sep 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

algorithms-keeperBot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

algorithms-keeperBot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rohan472000 commented Sep 23, 2023

Uh oh!

algorithms-keeperBot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

Uh oh!

rohan472000 commented Sep 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

algorithms-keeperBot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeperBotSep 24, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!