Skip to content

Rewrite of base85.py algorithm - #9069

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
chriso345:base85
Sep 24, 2023
Merged

Rewrite of base85.py algorithm#9069
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
chriso345:base85

Conversation

@chriso345

@chriso345chriso345 commented Sep 20, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Describe your change:

Fixes#8966
Fixes#8965

See #6216

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Sep 20, 2023
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Sep 20, 2023
@chriso345chriso345 changed the title Rewrite of base85.pyRewrite of base85.py algorithmSep 20, 2023
@rohan472000

rohan472000 commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

Now build will pass as #9078 is merged.

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Sep 23, 2023
tianyizheng02
tianyizheng02 requested changes Sep 24, 2023
View reviewed changes
Comment threadciphers/base85.py Outdated
Comment threadciphers/base85.py Outdated
Comment threadciphers/base85.py Outdated
Comment threadciphers/base85.py Outdated
Comment threadciphers/base85.py Outdated
Comment threadciphers/base85.py Outdated
chriso345
chriso345 commented Sep 24, 2023
View reviewed changes
Comment threadciphers/base85.py Outdated
@chriso345@tianyizheng02
Apply suggestions from code review
2a2015e
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@tianyizheng02
tianyizheng02 merged commit 882fb2f into TheAlgorithms:masterSep 24, 2023
@chriso345
chriso345 deleted the base85 branch September 24, 2023 08:19
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02tianyizheng02tianyizheng02 approved these changes

Assignees

No one assigned

Labels

awaiting reviewsThis PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chriso345@rohan472000@tianyizheng02