Uh oh!
There was an error while loading. Please reload this page.
Deleted sorts/random_pivot_quick_sort.py. Fixes #9124 - #9178
Conversation
tianyizheng02
commented
Oct 1, 2023
Thanks for your contribution! |
tianyizheng02
commented
Oct 1, 2023
Just realized that the implementation in |
Oh! My bad i didn't notice it. Are you going to open it? Or do you want me to do so. |
tianyizheng02
commented
Oct 1, 2023
I'll open the PR. The deleted implementation needs much fixing anyway (no tests, no type hints, etc) |
Wait... I just took a look at the original |
aryan1165
commented
Oct 1, 2023
Oh! Thats surprising. Opening another PR doing the same. I think i should take a look and report all those similar implementations in entire codebase as issues. As hacktoberfest has started some new comers will try to fix that issue as their |
tianyizheng02
commented
Oct 1, 2023
I just opened a PR deleting the other file. We actually already have an issue addressing duplicate algorithms (#8098), and I just added the "good first issue" tag to the issue. Thanks for the suggestion |
aryan1165
commented
Oct 1, 2023
I just saw that you also opened a PR regarding same. Sorry i didn't see it earlier. Thanks for considering my suggestion. |
Describe your change:
Fixes#9124.
Deleted sorts/random_pivot_quick_sort.py
Checklist: