Skip to content

Add missing number algorithm - #9203

Merged
cclauss merged 3 commits into
TheAlgorithms:masterfrom
shreyabhalgat:add-missing-number-algorithm
Oct 1, 2023
Merged

Add missing number algorithm#9203
cclauss merged 3 commits into
TheAlgorithms:masterfrom
shreyabhalgat:add-missing-number-algorithm

Conversation

@shreyabhalgat

Copy link
Copy Markdown
Contributor

Describe your change:

Added a new algorithm for finding the missing number in a list of consecutive integers using bit manipulation.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER

@algorithms-keeperalgorithms-keeperBot added the require type hints https://docs.python.org/3/library/typing.html label Oct 1, 2023

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
Comment threadbit_manipulation/missing_number.py Outdated
Comment on lines +1 to +9
def find_missing_number(nums):
"""
Finds the missing number in a list of consecutive integers.

Args:
nums (List[int]): A list of integers.

Returns:
int: The missing number.

@cclausscclaussOct 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy can test data types in the function signature, but not in the comments.

Do not repeat the datatypes in both places because readers will be confused if one is changed and the other is not.

Suggested change
deffind_missing_number(nums):
"""
Findsthemissingnumberinalistofconsecutiveintegers.
Args:
nums (List[int]): Alistofintegers.
Returns:
int: Themissingnumber.
deffind_missing_number(nums: list[int]) ->int:
"""
Findsthemissingnumberinalistofconsecutiveintegers.
Args:
nums: Alistofintegers.
Returns:
Themissingnumber.

@algorithms-keeperalgorithms-keeperBot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@cclauss
cclauss merged commit cfabd91 into TheAlgorithms:masterOct 1, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shreyabhalgat@cclauss