Skip to content

Euler072 - application of vector operations to reduce calculation time and refactoring numpy - #9229

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072
Oct 1, 2023
Merged

Euler072 - application of vector operations to reduce calculation time and refactoring numpy#9229
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072

Conversation

@quant12345

Copy link
Copy Markdown
Contributor

Describe your change:

Application of vector operations to reduce calculation time and refactoring numpy.
With limit: int = 1_000_000, the calculation of the new algorithm is 40% faster, limit: int = 10_000_000 is almost twice as fast.

code test
import datetime
import numpy as np
"""
Problem 72 Counting fractions: https://projecteuler.net/problem=72
Description:
Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1,
it is called a reduced proper fraction.
If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we
get: 1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7,
3/4, 4/5, 5/6, 6/7, 7/8
It can be seen that there are 21 elements in this set.
How many elements would be contained in the set of reduced proper fractions for
d ≤ 1,000,000?
Solution:
Number of numbers between 1 and n that are coprime to n is given by the Euler's Totient
function, phi(n). So, the answer is simply the sum of phi(n) for 2 <= n <= 1,000,000
Sum of phi(d), for all d|n = n. This result can be used to find phi(n) using a sieve.
Time: 1 sec
"""
def solution(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
phi = [i - 1 for i in range(limit + 1)]
for i in range(2, limit + 1):
if phi[i] == i - 1:
for j in range(2 * i, limit + 1, i):
phi[j] -= phi[j] // i
return sum(phi[2 : limit + 1])
def solution_new(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
# generating an array from -1 to limit
phi = np.arange(-1, limit)
for i in range(2, limit + 1):
if phi[i] == i - 1:
ind = np.arange(2 * i, limit + 1, i)# indexes for selection
phi[ind] -= phi[ind] // i
return np.sum(phi[2 : limit + 1])
if __name__ == "__main__":
now = datetime.datetime.now()
old = solution()
print('Returns an integer old', old)
time_original = datetime.datetime.now() - now
print('time_original', time_original.total_seconds())
now = datetime.datetime.now()
new = solution_new()
print('Returns an integer new', new)
time_new = datetime.datetime.now() - now
print('time_new', time_new.total_seconds())
print('old == new', old == new)

Output:

limit: int = 1_000_000
Returns an integer old 303963552391
time_original 1.236859
Returns an integer new 303963552391
time_new 0.816209
old == new True
limit: int = 10_000_000
Returns an integer old 30396356427241
time_original 17.871657
Returns an integer new 30396356427241
time_new 9.741272
old == new True
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
tianyizheng02 merged commit 8d94f77 into TheAlgorithms:masterOct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@quant12345
quant12345 deleted the euler072 branch October 5, 2023 14:06
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@quant12345@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Euler072 - application of vector operations to reduce calculation time and refactoring numpy by quant12345 · Pull Request #9229 · TheAlgorithms/Python · GitHub
Skip to content

Euler072 - application of vector operations to reduce calculation time and refactoring numpy - #9229

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072
Oct 1, 2023
Merged

Euler072 - application of vector operations to reduce calculation time and refactoring numpy#9229
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072

Conversation

@quant12345

Copy link
Copy Markdown
Contributor

Describe your change:

Application of vector operations to reduce calculation time and refactoring numpy.
With limit: int = 1_000_000, the calculation of the new algorithm is 40% faster, limit: int = 10_000_000 is almost twice as fast.

code test
import datetime
import numpy as np
"""
Problem 72 Counting fractions: https://projecteuler.net/problem=72
Description:
Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1,
it is called a reduced proper fraction.
If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we
get: 1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7,
3/4, 4/5, 5/6, 6/7, 7/8
It can be seen that there are 21 elements in this set.
How many elements would be contained in the set of reduced proper fractions for
d ≤ 1,000,000?
Solution:
Number of numbers between 1 and n that are coprime to n is given by the Euler's Totient
function, phi(n). So, the answer is simply the sum of phi(n) for 2 <= n <= 1,000,000
Sum of phi(d), for all d|n = n. This result can be used to find phi(n) using a sieve.
Time: 1 sec
"""
def solution(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
phi = [i - 1 for i in range(limit + 1)]
for i in range(2, limit + 1):
if phi[i] == i - 1:
for j in range(2 * i, limit + 1, i):
phi[j] -= phi[j] // i
return sum(phi[2 : limit + 1])
def solution_new(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
# generating an array from -1 to limit
phi = np.arange(-1, limit)
for i in range(2, limit + 1):
if phi[i] == i - 1:
ind = np.arange(2 * i, limit + 1, i)# indexes for selection
phi[ind] -= phi[ind] // i
return np.sum(phi[2 : limit + 1])
if __name__ == "__main__":
now = datetime.datetime.now()
old = solution()
print('Returns an integer old', old)
time_original = datetime.datetime.now() - now
print('time_original', time_original.total_seconds())
now = datetime.datetime.now()
new = solution_new()
print('Returns an integer new', new)
time_new = datetime.datetime.now() - now
print('time_new', time_new.total_seconds())
print('old == new', old == new)

Output:

limit: int = 1_000_000
Returns an integer old 303963552391
time_original 1.236859
Returns an integer new 303963552391
time_new 0.816209
old == new True
limit: int = 10_000_000
Returns an integer old 30396356427241
time_original 17.871657
Returns an integer new 30396356427241
time_new 9.741272
old == new True
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
tianyizheng02 merged commit 8d94f77 into TheAlgorithms:masterOct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@quant12345
quant12345 deleted the euler072 branch October 5, 2023 14:06
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@quant12345@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Euler072 - application of vector operations to reduce calculation time and refactoring numpy by quant12345 · Pull Request #9229 · TheAlgorithms/Python · GitHub
Skip to content

Euler072 - application of vector operations to reduce calculation time and refactoring numpy - #9229

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072
Oct 1, 2023
Merged

Euler072 - application of vector operations to reduce calculation time and refactoring numpy#9229
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072

Conversation

@quant12345

Copy link
Copy Markdown
Contributor

Describe your change:

Application of vector operations to reduce calculation time and refactoring numpy.
With limit: int = 1_000_000, the calculation of the new algorithm is 40% faster, limit: int = 10_000_000 is almost twice as fast.

code test
import datetime
import numpy as np
"""
Problem 72 Counting fractions: https://projecteuler.net/problem=72
Description:
Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1,
it is called a reduced proper fraction.
If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we
get: 1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7,
3/4, 4/5, 5/6, 6/7, 7/8
It can be seen that there are 21 elements in this set.
How many elements would be contained in the set of reduced proper fractions for
d ≤ 1,000,000?
Solution:
Number of numbers between 1 and n that are coprime to n is given by the Euler's Totient
function, phi(n). So, the answer is simply the sum of phi(n) for 2 <= n <= 1,000,000
Sum of phi(d), for all d|n = n. This result can be used to find phi(n) using a sieve.
Time: 1 sec
"""
def solution(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
phi = [i - 1 for i in range(limit + 1)]
for i in range(2, limit + 1):
if phi[i] == i - 1:
for j in range(2 * i, limit + 1, i):
phi[j] -= phi[j] // i
return sum(phi[2 : limit + 1])
def solution_new(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
# generating an array from -1 to limit
phi = np.arange(-1, limit)
for i in range(2, limit + 1):
if phi[i] == i - 1:
ind = np.arange(2 * i, limit + 1, i)# indexes for selection
phi[ind] -= phi[ind] // i
return np.sum(phi[2 : limit + 1])
if __name__ == "__main__":
now = datetime.datetime.now()
old = solution()
print('Returns an integer old', old)
time_original = datetime.datetime.now() - now
print('time_original', time_original.total_seconds())
now = datetime.datetime.now()
new = solution_new()
print('Returns an integer new', new)
time_new = datetime.datetime.now() - now
print('time_new', time_new.total_seconds())
print('old == new', old == new)

Output:

limit: int = 1_000_000
Returns an integer old 303963552391
time_original 1.236859
Returns an integer new 303963552391
time_new 0.816209
old == new True
limit: int = 10_000_000
Returns an integer old 30396356427241
time_original 17.871657
Returns an integer new 30396356427241
time_new 9.741272
old == new True
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
tianyizheng02 merged commit 8d94f77 into TheAlgorithms:masterOct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@quant12345
quant12345 deleted the euler072 branch October 5, 2023 14:06
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@quant12345@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Euler072 - application of vector operations to reduce calculation time and refactoring numpy by quant12345 · Pull Request #9229 · TheAlgorithms/Python · GitHub
Skip to content

Euler072 - application of vector operations to reduce calculation time and refactoring numpy - #9229

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072
Oct 1, 2023
Merged

Euler072 - application of vector operations to reduce calculation time and refactoring numpy#9229
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072

Conversation

@quant12345

Copy link
Copy Markdown
Contributor

Describe your change:

Application of vector operations to reduce calculation time and refactoring numpy.
With limit: int = 1_000_000, the calculation of the new algorithm is 40% faster, limit: int = 10_000_000 is almost twice as fast.

code test
import datetime
import numpy as np
"""
Problem 72 Counting fractions: https://projecteuler.net/problem=72
Description:
Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1,
it is called a reduced proper fraction.
If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we
get: 1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7,
3/4, 4/5, 5/6, 6/7, 7/8
It can be seen that there are 21 elements in this set.
How many elements would be contained in the set of reduced proper fractions for
d ≤ 1,000,000?
Solution:
Number of numbers between 1 and n that are coprime to n is given by the Euler's Totient
function, phi(n). So, the answer is simply the sum of phi(n) for 2 <= n <= 1,000,000
Sum of phi(d), for all d|n = n. This result can be used to find phi(n) using a sieve.
Time: 1 sec
"""
def solution(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
phi = [i - 1 for i in range(limit + 1)]
for i in range(2, limit + 1):
if phi[i] == i - 1:
for j in range(2 * i, limit + 1, i):
phi[j] -= phi[j] // i
return sum(phi[2 : limit + 1])
def solution_new(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
# generating an array from -1 to limit
phi = np.arange(-1, limit)
for i in range(2, limit + 1):
if phi[i] == i - 1:
ind = np.arange(2 * i, limit + 1, i)# indexes for selection
phi[ind] -= phi[ind] // i
return np.sum(phi[2 : limit + 1])
if __name__ == "__main__":
now = datetime.datetime.now()
old = solution()
print('Returns an integer old', old)
time_original = datetime.datetime.now() - now
print('time_original', time_original.total_seconds())
now = datetime.datetime.now()
new = solution_new()
print('Returns an integer new', new)
time_new = datetime.datetime.now() - now
print('time_new', time_new.total_seconds())
print('old == new', old == new)

Output:

limit: int = 1_000_000
Returns an integer old 303963552391
time_original 1.236859
Returns an integer new 303963552391
time_new 0.816209
old == new True
limit: int = 10_000_000
Returns an integer old 30396356427241
time_original 17.871657
Returns an integer new 30396356427241
time_new 9.741272
old == new True
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
tianyizheng02 merged commit 8d94f77 into TheAlgorithms:masterOct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@quant12345
quant12345 deleted the euler072 branch October 5, 2023 14:06
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@quant12345@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Euler072 - application of vector operations to reduce calculation time and refactoring numpy by quant12345 · Pull Request #9229 · TheAlgorithms/Python · GitHub
Skip to content

Euler072 - application of vector operations to reduce calculation time and refactoring numpy - #9229

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072
Oct 1, 2023
Merged

Euler072 - application of vector operations to reduce calculation time and refactoring numpy#9229
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072

Conversation

@quant12345

Copy link
Copy Markdown
Contributor

Describe your change:

Application of vector operations to reduce calculation time and refactoring numpy.
With limit: int = 1_000_000, the calculation of the new algorithm is 40% faster, limit: int = 10_000_000 is almost twice as fast.

code test
import datetime
import numpy as np
"""
Problem 72 Counting fractions: https://projecteuler.net/problem=72
Description:
Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1,
it is called a reduced proper fraction.
If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we
get: 1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7,
3/4, 4/5, 5/6, 6/7, 7/8
It can be seen that there are 21 elements in this set.
How many elements would be contained in the set of reduced proper fractions for
d ≤ 1,000,000?
Solution:
Number of numbers between 1 and n that are coprime to n is given by the Euler's Totient
function, phi(n). So, the answer is simply the sum of phi(n) for 2 <= n <= 1,000,000
Sum of phi(d), for all d|n = n. This result can be used to find phi(n) using a sieve.
Time: 1 sec
"""
def solution(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
phi = [i - 1 for i in range(limit + 1)]
for i in range(2, limit + 1):
if phi[i] == i - 1:
for j in range(2 * i, limit + 1, i):
phi[j] -= phi[j] // i
return sum(phi[2 : limit + 1])
def solution_new(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
# generating an array from -1 to limit
phi = np.arange(-1, limit)
for i in range(2, limit + 1):
if phi[i] == i - 1:
ind = np.arange(2 * i, limit + 1, i)# indexes for selection
phi[ind] -= phi[ind] // i
return np.sum(phi[2 : limit + 1])
if __name__ == "__main__":
now = datetime.datetime.now()
old = solution()
print('Returns an integer old', old)
time_original = datetime.datetime.now() - now
print('time_original', time_original.total_seconds())
now = datetime.datetime.now()
new = solution_new()
print('Returns an integer new', new)
time_new = datetime.datetime.now() - now
print('time_new', time_new.total_seconds())
print('old == new', old == new)

Output:

limit: int = 1_000_000
Returns an integer old 303963552391
time_original 1.236859
Returns an integer new 303963552391
time_new 0.816209
old == new True
limit: int = 10_000_000
Returns an integer old 30396356427241
time_original 17.871657
Returns an integer new 30396356427241
time_new 9.741272
old == new True
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
tianyizheng02 merged commit 8d94f77 into TheAlgorithms:masterOct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@quant12345
quant12345 deleted the euler072 branch October 5, 2023 14:06
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@quant12345@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Euler072 - application of vector operations to reduce calculation time and refactoring numpy by quant12345 · Pull Request #9229 · TheAlgorithms/Python · GitHub
Skip to content

Euler072 - application of vector operations to reduce calculation time and refactoring numpy - #9229

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072
Oct 1, 2023
Merged

Euler072 - application of vector operations to reduce calculation time and refactoring numpy#9229
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072

Conversation

@quant12345

Copy link
Copy Markdown
Contributor

Describe your change:

Application of vector operations to reduce calculation time and refactoring numpy.
With limit: int = 1_000_000, the calculation of the new algorithm is 40% faster, limit: int = 10_000_000 is almost twice as fast.

code test
import datetime
import numpy as np
"""
Problem 72 Counting fractions: https://projecteuler.net/problem=72
Description:
Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1,
it is called a reduced proper fraction.
If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we
get: 1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7,
3/4, 4/5, 5/6, 6/7, 7/8
It can be seen that there are 21 elements in this set.
How many elements would be contained in the set of reduced proper fractions for
d ≤ 1,000,000?
Solution:
Number of numbers between 1 and n that are coprime to n is given by the Euler's Totient
function, phi(n). So, the answer is simply the sum of phi(n) for 2 <= n <= 1,000,000
Sum of phi(d), for all d|n = n. This result can be used to find phi(n) using a sieve.
Time: 1 sec
"""
def solution(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
phi = [i - 1 for i in range(limit + 1)]
for i in range(2, limit + 1):
if phi[i] == i - 1:
for j in range(2 * i, limit + 1, i):
phi[j] -= phi[j] // i
return sum(phi[2 : limit + 1])
def solution_new(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
# generating an array from -1 to limit
phi = np.arange(-1, limit)
for i in range(2, limit + 1):
if phi[i] == i - 1:
ind = np.arange(2 * i, limit + 1, i)# indexes for selection
phi[ind] -= phi[ind] // i
return np.sum(phi[2 : limit + 1])
if __name__ == "__main__":
now = datetime.datetime.now()
old = solution()
print('Returns an integer old', old)
time_original = datetime.datetime.now() - now
print('time_original', time_original.total_seconds())
now = datetime.datetime.now()
new = solution_new()
print('Returns an integer new', new)
time_new = datetime.datetime.now() - now
print('time_new', time_new.total_seconds())
print('old == new', old == new)

Output:

limit: int = 1_000_000
Returns an integer old 303963552391
time_original 1.236859
Returns an integer new 303963552391
time_new 0.816209
old == new True
limit: int = 10_000_000
Returns an integer old 30396356427241
time_original 17.871657
Returns an integer new 30396356427241
time_new 9.741272
old == new True
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
tianyizheng02 merged commit 8d94f77 into TheAlgorithms:masterOct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@quant12345
quant12345 deleted the euler072 branch October 5, 2023 14:06
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@quant12345@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Euler072 - application of vector operations to reduce calculation time and refactoring numpy by quant12345 · Pull Request #9229 · TheAlgorithms/Python · GitHub
Skip to content

Euler072 - application of vector operations to reduce calculation time and refactoring numpy - #9229

Merged
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072
Oct 1, 2023
Merged

Euler072 - application of vector operations to reduce calculation time and refactoring numpy#9229
tianyizheng02 merged 4 commits into
TheAlgorithms:masterfrom
quant12345:euler072

Conversation

@quant12345

Copy link
Copy Markdown
Contributor

Describe your change:

Application of vector operations to reduce calculation time and refactoring numpy.
With limit: int = 1_000_000, the calculation of the new algorithm is 40% faster, limit: int = 10_000_000 is almost twice as fast.

code test
import datetime
import numpy as np
"""
Problem 72 Counting fractions: https://projecteuler.net/problem=72
Description:
Consider the fraction, n/d, where n and d are positive integers. If n<d and HCF(n,d)=1,
it is called a reduced proper fraction.
If we list the set of reduced proper fractions for d ≤ 8 in ascending order of size, we
get: 1/8, 1/7, 1/6, 1/5, 1/4, 2/7, 1/3, 3/8, 2/5, 3/7, 1/2, 4/7, 3/5, 5/8, 2/3, 5/7,
3/4, 4/5, 5/6, 6/7, 7/8
It can be seen that there are 21 elements in this set.
How many elements would be contained in the set of reduced proper fractions for
d ≤ 1,000,000?
Solution:
Number of numbers between 1 and n that are coprime to n is given by the Euler's Totient
function, phi(n). So, the answer is simply the sum of phi(n) for 2 <= n <= 1,000,000
Sum of phi(d), for all d|n = n. This result can be used to find phi(n) using a sieve.
Time: 1 sec
"""
def solution(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
phi = [i - 1 for i in range(limit + 1)]
for i in range(2, limit + 1):
if phi[i] == i - 1:
for j in range(2 * i, limit + 1, i):
phi[j] -= phi[j] // i
return sum(phi[2 : limit + 1])
def solution_new(limit: int = 1_000_000) -> int:
"""
Returns an integer, the solution to the problem
>>> solution(10)
31
>>> solution(100)
3043
>>> solution(1_000)
304191
"""
# generating an array from -1 to limit
phi = np.arange(-1, limit)
for i in range(2, limit + 1):
if phi[i] == i - 1:
ind = np.arange(2 * i, limit + 1, i)# indexes for selection
phi[ind] -= phi[ind] // i
return np.sum(phi[2 : limit + 1])
if __name__ == "__main__":
now = datetime.datetime.now()
old = solution()
print('Returns an integer old', old)
time_original = datetime.datetime.now() - now
print('time_original', time_original.total_seconds())
now = datetime.datetime.now()
new = solution_new()
print('Returns an integer new', new)
time_new = datetime.datetime.now() - now
print('time_new', time_new.total_seconds())
print('old == new', old == new)

Output:

limit: int = 1_000_000
Returns an integer old 303963552391
time_original 1.236859
Returns an integer new 303963552391
time_new 0.816209
old == new True
limit: int = 10_000_000
Returns an integer old 30396356427241
time_original 17.871657
Returns an integer new 30396356427241
time_new 9.741272
old == new True
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
tianyizheng02 merged commit 8d94f77 into TheAlgorithms:masterOct 1, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@quant12345
quant12345 deleted the euler072 branch October 5, 2023 14:06
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@quant12345@tianyizheng02