Uh oh!
There was an error while loading. Please reload this page.
adding factorial - #930
Conversation
shahabmohammadi
left a comment
There was a problem hiding this comment.
good , the code working correctly and i think could explain the idea of developer very easy.
cclauss
commented
Jul 13, 2019
Could you please add a doctest or two? |
jpg-130
commented
Jul 14, 2019
It is showing that the travis-ci build failed, however, it works well on the local machine. What changes should I incorporate? |
cclauss
commented
Jul 14, 2019
https://travis-ci.org/TheAlgorithms/Python/builds/558476077#L705 |
cclauss
commented
Jul 14, 2019
Need another hint? |
@cclauss I'll try. Thanks! |
| if __name__ == "__main__": | ||
| import doctest | ||
| result=[-1]*10 | ||
| result[0]=result[1]=1 |
There was a problem hiding this comment.
Hint: Move lines 33 and 34 inside the factorial() function.
There was a problem hiding this comment.
Ok but if I do that the values are recomputed every time the function is called i.e. I don't want to recompute 3! if 7! is already computed.
There was a problem hiding this comment.
Understood. Then put those two lines at the top of the file at global scopebefore the function and the main()
* adding factorial * adding doctest * Update factorial.py
calculating factorial using memoization added