Uh oh!
There was an error while loading. Please reload this page.
add ons in string directory - Boyer_Moore_Search - #933
Conversation
Erfaniaa
commented
Jul 2, 2019
I think it's "Boyer" Moore Search. If I'm right, please let me change it. |
Dharni0607
commented
Jul 2, 2019
via email
Yes, it's my bad. I will edit it. Thanks. …On Tue, Jul 2, 2019 at 1:59 PM Erfan Alimohammadi ***@***.***> wrote:
I think it's "Boyer" Moore Search. If I'm right, please let me change it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#933?email_source=notifications&email_token=AHKYK4ZQ5VRGSOGWN73HUTDP5MGWLA5CNFSM4H4RQRW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZAPYCA#issuecomment-507575304>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHKYK46ADOPY2BJO33NUBDDP5MGWLANCNFSM4H4RQRWQ>
.
|
Erfaniaa
left a comment
There was a problem hiding this comment.
Please make the requested changes.
| m=length of pattern string | ||
| """ | ||
| class BayerMooreSearch: |
There was a problem hiding this comment.
Please change the dictation mistake in the class name.
| return currentPos + i | ||
| return -1 | ||
| def badCharacterHeuristic(self): |
There was a problem hiding this comment.
Please use snake_case for all methods.
Like: bad_character_heuristic
| def badCharacterHeuristic(self): | ||
| positions = [] | ||
| for i in range(self.textLen - self.patLen + 1): | ||
| misMatchIndex = self.misMatchInText(i) |
There was a problem hiding this comment.
Use snake_case: mismatch_index
Try to use it in all variable names.
| return -1 | ||
| """ following functions tries to find the mis-matched character's index in text from last, |
There was a problem hiding this comment.
Place docstrings after the "def" line.
Explain the parameters and the return value separately.
Please Google "Python docstrings conventions".
https://www.datacamp.com/community/tutorials/docstrings-python#second-head
| pattern = "ABC" | ||
| bms = BayerMooreSearch(text, pattern) | ||
| positions = bms.badCharacterHeuristic() | ||
| if(len(positions) == 0): |
| print("No match found") | ||
| else: | ||
| print("Pattern found in following positions: ") | ||
| print(positions) |
There was a problem hiding this comment.
I ran your code and the algorithm seems to work fine.
3377842 to
62d0413Compare
#697, I have added Boyer Moore search function(bad character heuristic). Please review and let me know if any changes are required. Thanks. ;)