Skip to content

Create text_splitter.py - #9441

Closed
dimonalik wants to merge 6 commits into
TheAlgorithms:masterfrom
dimonalik:patch-8
Closed

Create text_splitter.py#9441
dimonalik wants to merge 6 commits into
TheAlgorithms:masterfrom
dimonalik:patch-8

Conversation

@dimonalik

Copy link
Copy Markdown
Contributor

Text splitter by number of symbols

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

dimonalikand others added 2 commits October 2, 2023 13:12
Text splitter by number of symbols
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 2, 2023
dimonalikand others added 3 commits October 2, 2023 13:30
Remade algorithm without PySimpleGUI
Fixed "line too long" error
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 2, 2023
fixed "typos" in lorem ipsum to pass tests
@algorithms-keeperalgorithms-keeperBot mentioned this pull request Oct 2, 2023
14 tasks
@tianyizheng02

Copy link
Copy Markdown
Contributor

@cclauss Would you say this algorithm, in concept, adds enough value to the repo to even include?

@cclauss

Copy link
Copy Markdown
Member

There are no classes, no functions, no type hints, and no tests.
CONTRIBUTING.md says no class, no function == no algorithm
I sense this could be written in a single line of Python.

@cclausscclauss closed this Oct 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewsThis PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dimonalik@tianyizheng02@cclauss