Skip to content

Updated check_bipartite_graph_dfs.py - #9525

Merged
cclauss merged 26 commits into
TheAlgorithms:masterfrom
debnath003:master
Oct 5, 2023
Merged

Updated check_bipartite_graph_dfs.py#9525
cclauss merged 26 commits into
TheAlgorithms:masterfrom
debnath003:master

Conversation

@debnath003

@debnath003debnath003 commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 2, 2023
@debnath003

debnath003 commented Oct 2, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02 please merge my PR, awaiting your review

@debnath003

debnath003 commented Oct 3, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02 awaiting your review #9525

@debnath003

debnath003 commented Oct 3, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again

@debnath003

debnath003 commented Oct 3, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest

@debnath003

debnath003 commented Oct 3, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest

@debnath003

debnath003 commented Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02@cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!

cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py Outdated
@debnath003@cclauss
Update graphs/check_bipartite_graph_dfs.py
b7522ba
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py Outdated
cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py Outdated
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 4, 2023
cclauss
cclauss requested changes Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py Outdated
@cclauss

cclauss commented Oct 4, 2023

Copy link
Copy Markdown
Member

if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.

@debnath003

debnath003 commented Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.

I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss

@debnath003

debnath003 commented Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss looks like the code is having some error, in build, could you please point out the error?

@cclauss

cclauss commented Oct 4, 2023•
edited
Loading

Copy link
Copy Markdown
Member

https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710

Scroll to line 710

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 4, 2023
@debnath003

debnath003 commented Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label

@debnath003

debnath003 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss@tianyizheng02 please someone check the review and approve my PR! Awaiting for review!

@cclauss
Let's use self-documenting variable names
272d924
This is complex code so let's use self-documenting function and variable names to help readers to understand.
We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black.
I am not sure if `nbor` was supposed to be `neighbour`. ;-)
@cclauss
Update check_bipartite_graph_dfs.py
498438b
@cclauss

cclauss commented Oct 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This is complex code so let's use function and variable names that are self-documenting to help readers understand.

We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.

I am unsure if nbor was supposed to be neighbour. ;-)

@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 5, 2023
@debnath003

debnath003 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

All the checks have passed! @cclauss

@debnath003

debnath003 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

This is complex code so let's use function and variable names that are self-documenting to help readers understand.

We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.

I am unsure if nbor was supposed to be neighbour. ;-)

I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss

@debnath003

debnath003 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss could you please check this PR once again?

@cclauss

cclauss commented Oct 5, 2023

Copy link
Copy Markdown
Member

https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.

Python/.pre-commit-config.yaml

Lines 18 to 26 in 87494f1

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks:
- id: ruff
- repo: https://github.com/psf/black
rev: 23.9.1
hooks:
- id: black

cclauss
cclauss approved these changes Oct 5, 2023
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023
@cclauss
cclauss merged commit b76115e into TheAlgorithms:masterOct 5, 2023
@debnath003

debnath003 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.

Python/.pre-commit-config.yaml

Lines 18 to 26 in 87494f1

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks:
- id: ruff
- repo: https://github.com/psf/black
rev: 23.9.1
hooks:
- id: black

I think I forgot it 😅

@debnath003

debnath003 commented Oct 5, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Nice work!!!

Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss

@cclauss

cclauss commented Oct 5, 2023

Copy link
Copy Markdown
Member

Hacktoberfest knows this repo... They will accept this automatically but just in case...

@cclausscclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 5, 2023
@debnath003

debnath003 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot @cclauss !

@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003@cclauss
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Updated check_bipartite_graph_dfs.py by debnath003 · Pull Request #9525 · TheAlgorithms/Python · GitHub
Skip to content
Updated check_bipartite_graph_dfs.py - #9525
Merged
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Oct 5, 2023
Merged
Updated check_bipartite_graph_dfs.py#9525
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Conversation
@debnath003
@debnath003debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 2, 2023
@debnath003
debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please merge my PR, awaiting your review
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 awaiting your review #9525
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02@cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@debnath003@cclauss
Update graphs/check_bipartite_graph_dfs.py
b7522ba
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
requested changes
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@cclauss
cclauss
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss looks like the code is having some error, in build, could you please point out the error?
@cclauss
cclauss
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Member
https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710
Scroll to line 710
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02 please someone check the review and approve my PR! Awaiting for review!
@cclauss
Let's use self-documenting variable names
272d924
This is complex code so let's use self-documenting function and variable names to help readers to understand.
We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black.
I am not sure if `nbor` was supposed to be `neighbour`. ;-)
@cclauss
Update check_bipartite_graph_dfs.py
498438b
@cclauss
cclauss
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
All the checks have passed! @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss could you please check this PR once again?
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
cclauss
cclauss
approved these changes
Oct 5, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 5, 2023
@cclauss
cclauss
merged commit b76115e
into
TheAlgorithms:masterOct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
I think I forgot it 😅
@debnath003
debnath003
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Nice work!!!
Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Hacktoberfest knows this repo... They will accept this automatically but just in case...
@cclausscclauss
added
the 
hacktoberfest-accepted
Accepted to be counted towards Hacktoberfest
label
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot @cclauss !
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updated check_bipartite_graph_dfs.py by debnath003 · Pull Request #9525 · TheAlgorithms/Python · GitHub
Skip to content
Updated check_bipartite_graph_dfs.py - #9525
Merged
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Oct 5, 2023
Merged
Updated check_bipartite_graph_dfs.py#9525
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Conversation
@debnath003
@debnath003debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 2, 2023
@debnath003
debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please merge my PR, awaiting your review
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 awaiting your review #9525
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02@cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@debnath003@cclauss
Update graphs/check_bipartite_graph_dfs.py
b7522ba
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
requested changes
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@cclauss
cclauss
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss looks like the code is having some error, in build, could you please point out the error?
@cclauss
cclauss
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Member
https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710
Scroll to line 710
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02 please someone check the review and approve my PR! Awaiting for review!
@cclauss
Let's use self-documenting variable names
272d924
This is complex code so let's use self-documenting function and variable names to help readers to understand.
We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black.
I am not sure if `nbor` was supposed to be `neighbour`. ;-)
@cclauss
Update check_bipartite_graph_dfs.py
498438b
@cclauss
cclauss
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
All the checks have passed! @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss could you please check this PR once again?
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
cclauss
cclauss
approved these changes
Oct 5, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 5, 2023
@cclauss
cclauss
merged commit b76115e
into
TheAlgorithms:masterOct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
I think I forgot it 😅
@debnath003
debnath003
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Nice work!!!
Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Hacktoberfest knows this repo... They will accept this automatically but just in case...
@cclausscclauss
added
the 
hacktoberfest-accepted
Accepted to be counted towards Hacktoberfest
label
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot @cclauss !
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updated check_bipartite_graph_dfs.py by debnath003 · Pull Request #9525 · TheAlgorithms/Python · GitHub
Skip to content
Updated check_bipartite_graph_dfs.py - #9525
Merged
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Oct 5, 2023
Merged
Updated check_bipartite_graph_dfs.py#9525
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Conversation
@debnath003
@debnath003debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 2, 2023
@debnath003
debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please merge my PR, awaiting your review
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 awaiting your review #9525
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02@cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@debnath003@cclauss
Update graphs/check_bipartite_graph_dfs.py
b7522ba
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
requested changes
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@cclauss
cclauss
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss looks like the code is having some error, in build, could you please point out the error?
@cclauss
cclauss
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Member
https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710
Scroll to line 710
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02 please someone check the review and approve my PR! Awaiting for review!
@cclauss
Let's use self-documenting variable names
272d924
This is complex code so let's use self-documenting function and variable names to help readers to understand.
We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black.
I am not sure if `nbor` was supposed to be `neighbour`. ;-)
@cclauss
Update check_bipartite_graph_dfs.py
498438b
@cclauss
cclauss
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
All the checks have passed! @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss could you please check this PR once again?
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
cclauss
cclauss
approved these changes
Oct 5, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 5, 2023
@cclauss
cclauss
merged commit b76115e
into
TheAlgorithms:masterOct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
I think I forgot it 😅
@debnath003
debnath003
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Nice work!!!
Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Hacktoberfest knows this repo... They will accept this automatically but just in case...
@cclausscclauss
added
the 
hacktoberfest-accepted
Accepted to be counted towards Hacktoberfest
label
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot @cclauss !
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Updated check_bipartite_graph_dfs.py by debnath003 · Pull Request #9525 · TheAlgorithms/Python · GitHub
Skip to content
Updated check_bipartite_graph_dfs.py - #9525
Merged
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Oct 5, 2023
Merged
Updated check_bipartite_graph_dfs.py#9525
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Conversation
@debnath003
@debnath003debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 2, 2023
@debnath003
debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please merge my PR, awaiting your review
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 awaiting your review #9525
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02@cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@debnath003@cclauss
Update graphs/check_bipartite_graph_dfs.py
b7522ba
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
requested changes
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@cclauss
cclauss
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss looks like the code is having some error, in build, could you please point out the error?
@cclauss
cclauss
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Member
https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710
Scroll to line 710
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02 please someone check the review and approve my PR! Awaiting for review!
@cclauss
Let's use self-documenting variable names
272d924
This is complex code so let's use self-documenting function and variable names to help readers to understand.
We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black.
I am not sure if `nbor` was supposed to be `neighbour`. ;-)
@cclauss
Update check_bipartite_graph_dfs.py
498438b
@cclauss
cclauss
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
All the checks have passed! @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss could you please check this PR once again?
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
cclauss
cclauss
approved these changes
Oct 5, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 5, 2023
@cclauss
cclauss
merged commit b76115e
into
TheAlgorithms:masterOct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
I think I forgot it 😅
@debnath003
debnath003
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Nice work!!!
Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Hacktoberfest knows this repo... They will accept this automatically but just in case...
@cclausscclauss
added
the 
hacktoberfest-accepted
Accepted to be counted towards Hacktoberfest
label
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot @cclauss !
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updated check_bipartite_graph_dfs.py by debnath003 · Pull Request #9525 · TheAlgorithms/Python · GitHub
Skip to content
Updated check_bipartite_graph_dfs.py - #9525
Merged
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Oct 5, 2023
Merged
Updated check_bipartite_graph_dfs.py#9525
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Conversation
@debnath003
@debnath003debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 2, 2023
@debnath003
debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please merge my PR, awaiting your review
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 awaiting your review #9525
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02@cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@debnath003@cclauss
Update graphs/check_bipartite_graph_dfs.py
b7522ba
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
requested changes
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@cclauss
cclauss
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss looks like the code is having some error, in build, could you please point out the error?
@cclauss
cclauss
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Member
https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710
Scroll to line 710
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02 please someone check the review and approve my PR! Awaiting for review!
@cclauss
Let's use self-documenting variable names
272d924
This is complex code so let's use self-documenting function and variable names to help readers to understand.
We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black.
I am not sure if `nbor` was supposed to be `neighbour`. ;-)
@cclauss
Update check_bipartite_graph_dfs.py
498438b
@cclauss
cclauss
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
All the checks have passed! @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss could you please check this PR once again?
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
cclauss
cclauss
approved these changes
Oct 5, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 5, 2023
@cclauss
cclauss
merged commit b76115e
into
TheAlgorithms:masterOct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
I think I forgot it 😅
@debnath003
debnath003
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Nice work!!!
Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Hacktoberfest knows this repo... They will accept this automatically but just in case...
@cclausscclauss
added
the 
hacktoberfest-accepted
Accepted to be counted towards Hacktoberfest
label
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot @cclauss !
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Updated check_bipartite_graph_dfs.py by debnath003 · Pull Request #9525 · TheAlgorithms/Python · GitHub
Skip to content
Updated check_bipartite_graph_dfs.py - #9525
Merged
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Oct 5, 2023
Merged
Updated check_bipartite_graph_dfs.py#9525
cclauss merged 26 commits into
TheAlgorithms:masterfrom 
debnath003:master
Conversation
@debnath003
@debnath003debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 2, 2023
@debnath003
debnath003
commented
Oct 2, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please merge my PR, awaiting your review
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 awaiting your review #9525
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest
@debnath003
debnath003
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@tianyizheng02@cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@debnath003@cclauss
Update graphs/check_bipartite_graph_dfs.py
b7522ba
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
requested changes
Oct 4, 2023
View reviewed changes
Comment threadgraphs/check_bipartite_graph_dfs.py
Outdated

@cclauss
cclauss
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.
I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss looks like the code is having some error, in build, could you please point out the error?
@cclauss
cclauss
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Member
https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710
Scroll to line 710
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@debnath003
debnath003
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss@tianyizheng02 please someone check the review and approve my PR! Awaiting for review!
@cclauss
Let's use self-documenting variable names
272d924
This is complex code so let's use self-documenting function and variable names to help readers to understand.
We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black.
I am not sure if `nbor` was supposed to be `neighbour`. ;-)
@cclauss
Update check_bipartite_graph_dfs.py
498438b
@cclauss
cclauss
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

tests are failing
Do not merge until tests pass
labels
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
All the checks have passed! @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
This is complex code so let's use function and variable names that are self-documenting to help readers understand.
We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.
I am unsure if nbor was supposed to be neighbour. ;-)
I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@cclauss could you please check this PR once again?
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
cclauss
cclauss
approved these changes
Oct 5, 2023
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 5, 2023
@cclauss
cclauss
merged commit b76115e
into
TheAlgorithms:masterOct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.
Python/.pre-commit-config.yaml

Lines 18 to 26
in
87494f1
 - repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.292
hooks: 
 - id: ruff
 - repo: https://github.com/psf/black
rev: 23.9.1
hooks: 
 - id: black
I think I forgot it 😅
@debnath003
debnath003
commented
Oct 5, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Nice work!!!
Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss
@cclauss
cclauss
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Hacktoberfest knows this repo... They will accept this automatically but just in case...
@cclausscclauss
added
the 
hacktoberfest-accepted
Accepted to be counted towards Hacktoberfest
label
Oct 5, 2023
@debnath003
debnath003
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot @cclauss !
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing fileshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@debnath003@cclauss