Skip to content

Upgrade our Devcontainer to Python 3.12 on Debian bookworm - #9580

Merged
cclauss merged 2 commits into
masterfrom
Python-3.12-on-Debian-bookworm
Oct 3, 2023
Merged

Upgrade our Devcontainer to Python 3.12 on Debian bookworm#9580
cclauss merged 2 commits into
masterfrom
Python-3.12-on-Debian-bookworm

Conversation

@cclauss

@cclausscclauss commented Oct 3, 2023

Copy link
Copy Markdown
Member

Describe your change:

Repeats #9578

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@cclauss, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

Invalid files in this pull request: .devcontainer/Dockerfile

@algorithms-keeper
algorithms-keeperBot removed the request for review from dhruvmanilaOctober 3, 2023 09:23
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2023
@dhruvmanila

Copy link
Copy Markdown
Member

Oh, the ACCEPTED_EXTENSIONS doesn't work like that, sorry didn't realize what you were trying to do.

@cclauss

Copy link
Copy Markdown
MemberAuthor

I cannot yet brew install python@3.12 and I needed a Py3.12 environment to fix #9581 but I will just keep doing GHA builds to get that green.

@dhruvmaniladhruvmanila reopened this Oct 3, 2023
@algorithms-keeperalgorithms-keeperBot added the enhancement This PR modified some existing files label Oct 3, 2023
@cclauss
cclauss enabled auto-merge (squash) October 3, 2023 09:43
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 3, 2023
@cclauss
cclaussforce-pushed the Python-3.12-on-Debian-bookworm branch from 1a9b5f6 to b7a93a4CompareOctober 3, 2023 09:52
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 3, 2023
@cclauss
cclauss requested a review from chriso345October 3, 2023 10:01
@cclauss
cclauss merged commit e60779c into masterOct 3, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 3, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss@dhruvmanila@chriso345