Skip to content

Arunsiva003 patch 1 flatten tree - #9695

Merged
cclauss merged 39 commits into
TheAlgorithms:masterfrom
Arunsiva003:Arunsiva003-patch-1-flattenTree
Oct 4, 2023
Merged

Arunsiva003 patch 1 flatten tree#9695
cclauss merged 39 commits into
TheAlgorithms:masterfrom
Arunsiva003:Arunsiva003-patch-1-flattenTree

Conversation

@Arunsiva003

@Arunsiva003Arunsiva003 commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

fixes#9694
closing #9694

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Arunsiva003and others added 17 commits October 2, 2023 13:09
@Arunsiva003
infix to prefix missing feature added
e3f51e6
@Arunsiva003
infix to prefix missing feature added
64aa843
@Arunsiva003
infix to prefix missing feature added
c59a81c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ed09ab
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
5cb6799
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
56f6ff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8a9a6f
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
c8d12c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2caec5
for more information, see https://pre-commit.ci
@Arunsiva003
newly updated infix_to_prefix
b51c2a2
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
da601b7
@Arunsiva003
newly updated infix_to_prefix_2
2c4166f
@Arunsiva003
newly updated infix_to_prefix_3
b0f71e9
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
71f9365
@Arunsiva003
from the beginning
1931aee
@Arunsiva003
Created flatten_binarytree_to_linkedlist.py
922af56
@Arunsiva003
Update flatten_binarytree_to_linkedlist.py
4b7f3c2
@algorithms-keeperalgorithms-keeperBot added require tests Tests [doctest/unittest/pytest] are required awaiting reviews This PR is ready to be reviewed labels Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 4, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
current = current.right


def main() -> None:

@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 4, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
current = current.right


def main() -> None:

@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main

algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 4, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
current = current.right


def main() -> None:

@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main

algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 4, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 4, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
current = current.right


def main() -> None:

@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main

algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 4, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
current = current.right


def main() -> None:

@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main

algorithms-keeper[bot]
algorithms-keeperBot reviewed Oct 4, 2023
View reviewed changes

@algorithms-keeperalgorithms-keeperBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
current = current.right


def main() -> None:

@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 4, 2023
cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py Outdated
cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml Outdated
entry: ./scripts/validate_filenames.py
language: script
pass_filenames: false
# - repo: local

@cclausscclaussOct 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.

@Arunsiva003Arunsiva003Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why am i getting error as
Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases
for the validate filenames checking??

@cclausscclaussOct 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run python in the command prompt?

@Arunsiva003Arunsiva003Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to script mode
I even checked python --version
And it gave like 3.11.4

@algorithms-keeperalgorithms-keeperBot removed the require tests Tests [doctest/unittest/pytest] are required label Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 4, 2023
@cclauss
cclauss merged commit d743497 into TheAlgorithms:masterOct 4, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2023
@Arunsiva003
Arunsiva003 deleted the Arunsiva003-patch-1-flattenTree branch October 14, 2023 12:12
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@dhruvmaniladhruvmanilaAwaiting requested review from dhruvmanila
+1 more reviewer
@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add "Flatten binary tree to linked list algorithm"

2 participants

@Arunsiva003@cclauss
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Arunsiva003 patch 1 flatten tree by Arunsiva003 · Pull Request #9695 · TheAlgorithms/Python · GitHub
Skip to content
Arunsiva003 patch 1 flatten tree - #9695
Merged
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Oct 4, 2023
Merged
Arunsiva003 patch 1 flatten tree#9695
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Conversation
@Arunsiva003
@Arunsiva003Arunsiva003
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
fixes#9694

closing #9694
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Arunsiva003and others
added 17 commits
October 2, 2023 13:09
@Arunsiva003
infix to prefix missing feature added
e3f51e6
@Arunsiva003
infix to prefix missing feature added
64aa843
@Arunsiva003
infix to prefix missing feature added
c59a81c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ed09ab
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
5cb6799
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
56f6ff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8a9a6f
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
c8d12c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2caec5
for more information, see https://pre-commit.ci
@Arunsiva003
newly updated infix_to_prefix
b51c2a2
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
da601b7
@Arunsiva003
newly updated infix_to_prefix_2
2c4166f
@Arunsiva003
newly updated infix_to_prefix_3
b0f71e9
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
71f9365
@Arunsiva003
from the beginning
1931aee
@Arunsiva003
Created flatten_binarytree_to_linkedlist.py
922af56
@Arunsiva003
Update flatten_binarytree_to_linkedlist.py
4b7f3c2
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml
Outdated

 entry: ./scripts/validate_filenames.py
 language: script
 pass_filenames: false
# - repo: local
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why am i getting error as

Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases

for the validate filenames checking??
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run python in the command prompt?
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to script mode

I even checked python --version

And it gave like 3.11.4
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@cclauss
cclauss
merged commit d743497
into
TheAlgorithms:masterOct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@Arunsiva003
Arunsiva003
deleted the

Arunsiva003-patch-1-flattenTree

branch
October 14, 2023 12:12
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@dhruvmaniladhruvmanilaAwaiting requested review from dhruvmanila

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add "Flatten binary tree to linked list algorithm"


2 participants

@Arunsiva003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Arunsiva003 patch 1 flatten tree by Arunsiva003 · Pull Request #9695 · TheAlgorithms/Python · GitHub
Skip to content
Arunsiva003 patch 1 flatten tree - #9695
Merged
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Oct 4, 2023
Merged
Arunsiva003 patch 1 flatten tree#9695
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Conversation
@Arunsiva003
@Arunsiva003Arunsiva003
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
fixes#9694

closing #9694
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Arunsiva003and others
added 17 commits
October 2, 2023 13:09
@Arunsiva003
infix to prefix missing feature added
e3f51e6
@Arunsiva003
infix to prefix missing feature added
64aa843
@Arunsiva003
infix to prefix missing feature added
c59a81c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ed09ab
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
5cb6799
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
56f6ff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8a9a6f
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
c8d12c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2caec5
for more information, see https://pre-commit.ci
@Arunsiva003
newly updated infix_to_prefix
b51c2a2
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
da601b7
@Arunsiva003
newly updated infix_to_prefix_2
2c4166f
@Arunsiva003
newly updated infix_to_prefix_3
b0f71e9
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
71f9365
@Arunsiva003
from the beginning
1931aee
@Arunsiva003
Created flatten_binarytree_to_linkedlist.py
922af56
@Arunsiva003
Update flatten_binarytree_to_linkedlist.py
4b7f3c2
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml
Outdated

 entry: ./scripts/validate_filenames.py
 language: script
 pass_filenames: false
# - repo: local
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why am i getting error as

Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases

for the validate filenames checking??
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run python in the command prompt?
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to script mode

I even checked python --version

And it gave like 3.11.4
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@cclauss
cclauss
merged commit d743497
into
TheAlgorithms:masterOct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@Arunsiva003
Arunsiva003
deleted the

Arunsiva003-patch-1-flattenTree

branch
October 14, 2023 12:12
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@dhruvmaniladhruvmanilaAwaiting requested review from dhruvmanila

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add "Flatten binary tree to linked list algorithm"


2 participants

@Arunsiva003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Arunsiva003 patch 1 flatten tree by Arunsiva003 · Pull Request #9695 · TheAlgorithms/Python · GitHub
Skip to content
Arunsiva003 patch 1 flatten tree - #9695
Merged
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Oct 4, 2023
Merged
Arunsiva003 patch 1 flatten tree#9695
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Conversation
@Arunsiva003
@Arunsiva003Arunsiva003
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
fixes#9694

closing #9694
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Arunsiva003and others
added 17 commits
October 2, 2023 13:09
@Arunsiva003
infix to prefix missing feature added
e3f51e6
@Arunsiva003
infix to prefix missing feature added
64aa843
@Arunsiva003
infix to prefix missing feature added
c59a81c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ed09ab
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
5cb6799
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
56f6ff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8a9a6f
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
c8d12c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2caec5
for more information, see https://pre-commit.ci
@Arunsiva003
newly updated infix_to_prefix
b51c2a2
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
da601b7
@Arunsiva003
newly updated infix_to_prefix_2
2c4166f
@Arunsiva003
newly updated infix_to_prefix_3
b0f71e9
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
71f9365
@Arunsiva003
from the beginning
1931aee
@Arunsiva003
Created flatten_binarytree_to_linkedlist.py
922af56
@Arunsiva003
Update flatten_binarytree_to_linkedlist.py
4b7f3c2
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml
Outdated

 entry: ./scripts/validate_filenames.py
 language: script
 pass_filenames: false
# - repo: local
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why am i getting error as

Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases

for the validate filenames checking??
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run python in the command prompt?
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to script mode

I even checked python --version

And it gave like 3.11.4
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@cclauss
cclauss
merged commit d743497
into
TheAlgorithms:masterOct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@Arunsiva003
Arunsiva003
deleted the

Arunsiva003-patch-1-flattenTree

branch
October 14, 2023 12:12
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@dhruvmaniladhruvmanilaAwaiting requested review from dhruvmanila

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add "Flatten binary tree to linked list algorithm"


2 participants

@Arunsiva003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Arunsiva003 patch 1 flatten tree by Arunsiva003 · Pull Request #9695 · TheAlgorithms/Python · GitHub
Skip to content
Arunsiva003 patch 1 flatten tree - #9695
Merged
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Oct 4, 2023
Merged
Arunsiva003 patch 1 flatten tree#9695
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Conversation
@Arunsiva003
@Arunsiva003Arunsiva003
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
fixes#9694

closing #9694
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Arunsiva003and others
added 17 commits
October 2, 2023 13:09
@Arunsiva003
infix to prefix missing feature added
e3f51e6
@Arunsiva003
infix to prefix missing feature added
64aa843
@Arunsiva003
infix to prefix missing feature added
c59a81c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ed09ab
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
5cb6799
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
56f6ff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8a9a6f
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
c8d12c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2caec5
for more information, see https://pre-commit.ci
@Arunsiva003
newly updated infix_to_prefix
b51c2a2
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
da601b7
@Arunsiva003
newly updated infix_to_prefix_2
2c4166f
@Arunsiva003
newly updated infix_to_prefix_3
b0f71e9
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
71f9365
@Arunsiva003
from the beginning
1931aee
@Arunsiva003
Created flatten_binarytree_to_linkedlist.py
922af56
@Arunsiva003
Update flatten_binarytree_to_linkedlist.py
4b7f3c2
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml
Outdated

 entry: ./scripts/validate_filenames.py
 language: script
 pass_filenames: false
# - repo: local
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why am i getting error as

Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases

for the validate filenames checking??
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run python in the command prompt?
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to script mode

I even checked python --version

And it gave like 3.11.4
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@cclauss
cclauss
merged commit d743497
into
TheAlgorithms:masterOct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@Arunsiva003
Arunsiva003
deleted the

Arunsiva003-patch-1-flattenTree

branch
October 14, 2023 12:12
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@dhruvmaniladhruvmanilaAwaiting requested review from dhruvmanila

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add "Flatten binary tree to linked list algorithm"


2 participants

@Arunsiva003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Arunsiva003 patch 1 flatten tree by Arunsiva003 · Pull Request #9695 · TheAlgorithms/Python · GitHub
Skip to content
Arunsiva003 patch 1 flatten tree - #9695
Merged
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Oct 4, 2023
Merged
Arunsiva003 patch 1 flatten tree#9695
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Conversation
@Arunsiva003
@Arunsiva003Arunsiva003
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
fixes#9694

closing #9694
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Arunsiva003and others
added 17 commits
October 2, 2023 13:09
@Arunsiva003
infix to prefix missing feature added
e3f51e6
@Arunsiva003
infix to prefix missing feature added
64aa843
@Arunsiva003
infix to prefix missing feature added
c59a81c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ed09ab
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
5cb6799
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
56f6ff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8a9a6f
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
c8d12c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2caec5
for more information, see https://pre-commit.ci
@Arunsiva003
newly updated infix_to_prefix
b51c2a2
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
da601b7
@Arunsiva003
newly updated infix_to_prefix_2
2c4166f
@Arunsiva003
newly updated infix_to_prefix_3
b0f71e9
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
71f9365
@Arunsiva003
from the beginning
1931aee
@Arunsiva003
Created flatten_binarytree_to_linkedlist.py
922af56
@Arunsiva003
Update flatten_binarytree_to_linkedlist.py
4b7f3c2
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml
Outdated

 entry: ./scripts/validate_filenames.py
 language: script
 pass_filenames: false
# - repo: local
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why am i getting error as

Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases

for the validate filenames checking??
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run python in the command prompt?
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to script mode

I even checked python --version

And it gave like 3.11.4
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@cclauss
cclauss
merged commit d743497
into
TheAlgorithms:masterOct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@Arunsiva003
Arunsiva003
deleted the

Arunsiva003-patch-1-flattenTree

branch
October 14, 2023 12:12
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@dhruvmaniladhruvmanilaAwaiting requested review from dhruvmanila

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add "Flatten binary tree to linked list algorithm"


2 participants

@Arunsiva003@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Arunsiva003 patch 1 flatten tree by Arunsiva003 · Pull Request #9695 · TheAlgorithms/Python · GitHub
Skip to content
Arunsiva003 patch 1 flatten tree - #9695
Merged
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Oct 4, 2023
Merged
Arunsiva003 patch 1 flatten tree#9695
cclauss merged 39 commits into
TheAlgorithms:masterfrom 
Arunsiva003:Arunsiva003-patch-1-flattenTree
Conversation
@Arunsiva003
@Arunsiva003Arunsiva003
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
Describe your change:
fixes#9694

closing #9694
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Arunsiva003and others
added 17 commits
October 2, 2023 13:09
@Arunsiva003
infix to prefix missing feature added
e3f51e6
@Arunsiva003
infix to prefix missing feature added
64aa843
@Arunsiva003
infix to prefix missing feature added
c59a81c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ed09ab
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
5cb6799
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
56f6ff8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a8a9a6f
for more information, see https://pre-commit.ci
@Arunsiva003
infix to prefix missing feature added (comments)
c8d12c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2caec5
for more information, see https://pre-commit.ci
@Arunsiva003
newly updated infix_to_prefix
b51c2a2
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
da601b7
@Arunsiva003
newly updated infix_to_prefix_2
2c4166f
@Arunsiva003
newly updated infix_to_prefix_3
b0f71e9
@Arunsiva003
Merge branch 'master' ofhttps://github.com/Arunsiva003/Python
71f9365
@Arunsiva003
from the beginning
1931aee
@Arunsiva003
Created flatten_binarytree_to_linkedlist.py
922af56
@Arunsiva003
Update flatten_binarytree_to_linkedlist.py
4b7f3c2
@algorithms-keeperalgorithms-keeperBot
added

require tests
Tests [doctest/unittest/pytest] are required
awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
algorithms-keeper[bot]
algorithms-keeperBot
reviewed
Oct 4, 2023
View reviewed changes
@algorithms-keeperalgorithms-keeperBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.
NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

 current = current.right


def main() -> None:
@algorithms-keeperalgorithms-keeperBotOct 4, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/flatten_binarytree_to_linkedlist.py, please provide doctest for the function main
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment threaddata_structures/binary_tree/flatten_binarytree_to_linkedlist.py
Outdated

cclauss
cclauss
reviewed
Oct 4, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml
Outdated

 entry: ./scripts/validate_filenames.py
 language: script
 pass_filenames: false
# - repo: local
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert.
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why am i getting error as

Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases

for the validate filenames checking??
@cclausscclaussOct 4, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you run python in the command prompt?
@Arunsiva003Arunsiva003Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to script mode

I even checked python --version

And it gave like 3.11.4
@algorithms-keeperalgorithms-keeperBot
removed
the 
require tests
Tests [doctest/unittest/pytest] are required
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added

tests are failing
Do not merge until tests pass
and removed

awaiting reviews
This PR is ready to be reviewed
labels
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Oct 4, 2023
@cclauss
cclauss
merged commit d743497
into
TheAlgorithms:masterOct 4, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 4, 2023
@Arunsiva003
Arunsiva003
deleted the

Arunsiva003-patch-1-flattenTree

branch
October 14, 2023 12:12
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@dhruvmaniladhruvmanilaAwaiting requested review from dhruvmanila

+1 more reviewer

@algorithms-keeperalgorithms-keeper[bot]algorithms-keeper[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Add "Flatten binary tree to linked list algorithm"


2 participants

@Arunsiva003@cclauss