Skip to content

largest divisible subset - #9825

Merged
cclauss merged 13 commits into
TheAlgorithms:masterfrom
pa-kh039:new-branch
Oct 5, 2023
Merged

largest divisible subset#9825
cclauss merged 13 commits into
TheAlgorithms:masterfrom
pa-kh039:new-branch

Conversation

@pa-kh039

@pa-kh039pa-kh039 commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023
@pa-kh039

pa-kh039 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@tianyizheng02@cclauss please review (PR for hacktoberfest 2023)

@cclauss

cclauss commented Oct 5, 2023

Copy link
Copy Markdown
Member

When would someone want to use this algorithm?

@pa-kh039

pa-kh039 commented Oct 5, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

When would someone want to use this algorithm?

@cclauss
There are several possible use cases for this algorithm. To enlist a few:

  1. When managing a portfolio of financial assets, you might want to find the largest subset of assets where each asset's price is a multiple of another, which can help with diversification and risk management.
  2. In data analysis, you may encounter situations where you want to group data points into clusters based on some criteria, and this problem can be used to find the largest subset of data points that are related according to specific rules.

So, with some changes in it , this algorithm can be utilised at several places.

cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
Comment threaddynamic_programming/largest_divisible_subset.py Outdated
cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
Comment threaddynamic_programming/largest_divisible_subset.py Outdated
@pa-kh039@cclauss
adding more test cases
e78e5f6
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
Comment threaddynamic_programming/largest_divisible_subset.py Outdated
pa-kh039and others added 2 commits October 5, 2023 20:24
@pa-kh039@cclauss
improving code for better readability
16ff978
Co-authored-by: Christian Clauss <cclauss@me.com>
@pa-kh039@cclauss
update
344a545
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Oct 5, 2023
cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
Comment threaddynamic_programming/largest_divisible_subset.py Outdated
cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
Comment threaddynamic_programming/largest_divisible_subset.py Outdated
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Oct 5, 2023
@pa-kh039

pa-kh039 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss Did all the changes suggested by you and all the associated changes.

@algorithms-keeperalgorithms-keeperBot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 5, 2023
cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
Comment threaddynamic_programming/largest_divisible_subset.py Outdated
cclauss
cclauss reviewed Oct 5, 2023
View reviewed changes
Comment threaddynamic_programming/largest_divisible_subset.py Outdated
@pa-kh039

pa-kh039 commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@cclauss Would you like to suggest any more changes in the latest version?

@cclauss
cclauss enabled auto-merge (squash) October 5, 2023 16:21
@cclauss
cclauss merged commit 87494f1 into TheAlgorithms:masterOct 5, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pa-kh039@cclauss