Skip to content

feat: added input validation in installer - #26

Open
Ayush4958 wants to merge 2 commits into
TheCodeVerseHub:mainfrom
Ayush4958:input-validation-installer
Open

feat: added input validation in installer#26
Ayush4958 wants to merge 2 commits into
TheCodeVerseHub:mainfrom
Ayush4958:input-validation-installer

Conversation

@Ayush4958

@Ayush4958Ayush4958 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

I had added input validation and safety checks in installation process which will prevent user to enter invalid input during installlation.

Changes

  • Validate Disk Selection
  • Prevent an accidental formatting , check if the disk is mounted or not , checks for disk labels (archiso/cvh/codeverse)
  • Safer Hostname & Username Input , re-try had been limited upto 3 attempt at single run

Related Issue

Fix#16

Checklist

  • Scope is focused (no unrelated changes)
  • Docs updated (if needed)
  • Scripts/configs changed were tested

@Ayush4958
feat: added input validation in installer
8358c7f
Signed-off-by: Ayush <bhandariayush935@gmail.com>
@Ayush4958
Ayush4958 requested a review from a team as a code ownerApril 15, 2026 13:25
@Ayush4958Ayush4958 mentioned this pull request Apr 15, 2026
Open
youngcoder45
youngcoder45 reviewed May 30, 2026
View reviewed changes

@youngcoder45youngcoder45 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh looks good to me just want a review from @sinisterMage

Comment threadscripts/install.sh
log_warn "Invalid username '$USERNAME'. (Attempt $attempt/$max_attempts)"
echo -e " ${DIM}Usernames must start with a letter or underscore,${NC}"
echo -e " ${DIM}and contain only lowercase letters, digits, - or _.${NC}"
echo

@youngcoder45youngcoder45May 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

CopilotAI reviewed May 30, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds additional input validation and safety checks to the interactive installer flow to reduce the risk of destructive actions (e.g., wiping the wrong disk) due to invalid user input.

Changes:

  • Adds live-boot medium detection and excludes it from install targets (including --disk preselection).
  • Improves disk selection UX with detailed disk info and a confirmation prompt; adds retry limits for invalid selections.
  • Adds retry-limited validation loops for hostname and username prompts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadscripts/install.sh Outdated
Comment threadscripts/install.sh
Comment threadscripts/install.sh
Comment threadscripts/install.sh Outdated
Comment threadscripts/install.sh
Comment threadscripts/install.sh
@youngcoder45
Potential fix for pull request finding
197faec
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI mentioned this pull request May 31, 2026
Merged
@youngcoder45

youngcoder45 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@sinisterMage Can u review this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youngcoder45youngcoder45youngcoder45 left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@sinisterMagesinisterMageAwaiting requested review from sinisterMage

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add input validation to installer

3 participants

@Ayush4958@youngcoder45