Uh oh!
There was an error while loading. Please reload this page.
MVP of Complete rewrite - #30
Open
bristermitten wants to merge 26 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR is a ground-up rewrite of the website, migrating from a hand-rolled Elm SPA build/deploy setup to an Elm Land–based app with a new layout/theme and updated tooling (Bun, Nix flake, GitHub Pages deploy).
Changes:
- Replaced the old Elm SPA routing/views with Elm Land pages/layouts and shared model/message structure.
- Added the new Home, Rules, and Learning Resources pages (including resource detail view) using the new theming.
- Reworked build/deploy tooling: Bun-based scripts, Tailwind module generation, Nix flake dev shell, and GitHub Pages workflows.
Reviewed changes
Copilot reviewed 44 out of 62 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds TypeScript config (used for repo scripts/tooling). |
| tailwind.config.ts | New Tailwind configuration (colors/fonts/content). |
| tailwind.config.js | Removes legacy Tailwind config. |
| static/index.html | Removes legacy static entrypoint HTML. |
| static/devden-logo.svg | Adds new logo asset. |
| static/devden-banner.svg | Adds new banner asset. |
| static/custom.css | Removes legacy custom font CSS. |
| static/base.css | Adds base stylesheet (Tailwind directives, fonts, CSS variables). |
| src/Views/ServicesRules.elm | Removes legacy view module. |
| src/Views/Rules.elm | Removes legacy view module. |
| src/Views/Home.elm | Removes legacy view module. |
| src/Views/Blank.elm | Removes legacy blank view module. |
| src/View.elm | Introduces Elm Land view adapter using Html.Styled. |
| src/Theming.elm | Adds shared theming helpers (gradients/fonts/card shell). |
| src/Shared/Msg.elm | Adds shared message type (learning index fetch, retry, etc.). |
| src/Shared/Model.elm | Adds shared model for learning database status. |
| src/Shared.elm | Adds Elm Land shared init/update/subscriptions to fetch learning DB. |
| src/Route.elm | Removes legacy custom route parser/stringifier. |
| src/Redirects.elm | Simplifies redirect constants to Discord/GitHub only. |
| src/Pages/Rules.elm | New Rules page (data-driven sections and rendering). |
| src/Pages/Learning/Resource_.elm | New Learning topic detail page with sidebar + resource cards. |
| src/Pages/Learning.elm | New Learning directory page with search + grouping. |
| src/Pages/Home_.elm | New Home page (banner + CTA + floating social links). |
| src/Page.elm | Removes legacy page wrapper/background/navbar implementation. |
| src/OpenApi/Common.elm | Adds shared OpenAPI/HTTP decoder utilities and error types. |
| src/Main.elm | Removes legacy Browser.application entrypoint. |
| src/LearningResources/Types.elm | Adds generated types for LearningResources database schema. |
| src/LearningResources/Json.elm | Adds generated JSON encoders/decoders for LearningResources schema. |
| src/LearningResources/Emojis.elm | Adds emoji fallback mapping logic for topics. |
| src/LearningResources.elm | Adds small helper functions for filtering metadata/resources. |
| src/Layouts/Global.elm | Adds global layout (navbar, page shell). |
| src/Effect.elm | Adds Elm Land effect system (routing, shared messages, cmd wrapping). |
| src/Api.elm | Adds API helper to fetch LearningResources DB from jsdelivr. |
| README.MD | Updates local dev/formatting instructions and TODO list. |
| postcss.config.js | Replaces legacy PostCSS config with new plugin-based config. |
| package.json | Switches to Bun/Elm Land toolchain and updates dependencies/scripts. |
| nginx.conf | Removes legacy nginx deployment config. |
| main.css | Removes legacy Tailwind entry CSS file. |
| LICENSE | Removes legacy MIT license file. |
| generate-elm-types.ts | Adds script to generate Elm types from LearningResources OpenAPI schema. |
| flake.nix | Replaces dev env with flake-parts + treefmt + Bun/Elm tooling. |
| flake.lock | Updates lockfile for new flake inputs. |
| elm.json | Updates Elm dependencies and source directories for Elm Land + gen output. |
| elm-land.json | Adds Elm Land app configuration (meta, stylesheet link, scripts). |
| Dockerfile | Removes legacy Docker build/deploy pipeline. |
| .yarnrc.yml | Removes Yarn config (moving away from Yarn). |
| .gitignore | Updates ignores for Elm Land, Bun, Nix/direnv, generated Tailwind modules. |
| .github/workflows/deploy.yml | Replaces Docker registry flow with GitHub Pages build + deploy. |
| .github/workflows/ci.yml | Adds CI build/lint workflow using Bun + Elm Land + Tailwind module generation. |
| .envrc | Updates direnv flake invocation. |
| .dockerignore | Removes Docker ignore file (Docker removed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+8
| import Json.Decode as Json | ||
| import LearningResources.Json as LearningResources | ||
| import LearningResources.Types as LearningResources | ||
| import Yaml.Decode |
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc | ||
| - run: bun install --frozen-lockfile | ||
| }; No newline at end of file | ||
| export default { | ||
| plugins: { | ||
| "@tailwindcss/postcss": {}, |
| "link": [ | ||
| { | ||
| "rel": "stylesheet", | ||
| "href": "/base.css" |
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+1
to
+11
| import { | ||
| quicktype, | ||
| InputData, | ||
| JSONSchemaInput, | ||
| FetchingJSONSchemaStore | ||
| } from "quicktype-core"; | ||
| import path from "path"; | ||
| import fs from "fs" | ||
| import { $ } from "bun"; | ||
| const SCHEMA_URL = "https://cdn.jsdelivr.net/gh/TheDeveloperDen/LearningResources@cb31652/openapi.schema.json"; |
Comment on lines
20
to
25
| "dependencies": { | ||
| "postcss-loader": "^6.1.1", | ||
| "serve": "^12.0.1", | ||
| "watch": "^1.0.2", | ||
| "yarn": "^1.22.15" | ||
| "@tailwindcss/postcss": "^4.3.0", | ||
| "elm-tailwind-modules": "^0.5.0", | ||
| "postcss": "^8.4.0", | ||
| "tailwindcss": "^3.4.0" | ||
| } |
Comment on lines
+15
to
+18
| import Api | ||
| import Dict | ||
| import Effect exposing (Effect) | ||
| import Json.Decode |
Comment on lines
+8
to
+10
| import Dict exposing (Dict) | ||
| import Http | ||
| import LearningResources.Types as LearningResources |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+6
to
+7
| import Tailwind.Theme as Tw | ||
| import Tailwind.Utilities as Tw |
Comment on lines
+12
to
+13
| import Tailwind.Theme as Tw | ||
| import Tailwind.Utilities as Tw |
Comment on lines
+18
to
+19
| import Tailwind.Theme as Tw | ||
| import Tailwind.Utilities as Tw |
Comment on lines
+16
to
+17
| import Tailwind.Theme as Tw | ||
| import Tailwind.Utilities as Tw |
| import Route exposing (Route) | ||
| import Route.Path | ||
| import Shared | ||
| import Tailwind.Theme as Tw |
Comment on lines
+5
to
+7
| import Html.Styled as Html exposing (Html, div, span, text) | ||
| import Html.Styled.Attributes as Attr exposing (css, href, target) | ||
| import Layouts |
Comment on lines
+15
to
+18
| import Api | ||
| import Dict | ||
| import Effect exposing (Effect) | ||
| import Json.Decode |
Comment on lines
+8
to
+10
| import Dict exposing (Dict) | ||
| import Http | ||
| import LearningResources.Types as LearningResources |
Comment on lines
+4
to
+6
| import Effect exposing (Effect) | ||
| import Html.Styled as Html exposing (Html, a, div, fieldset, h1, h2, i, img, legend, p, text) | ||
| import Html.Styled.Attributes as Attr exposing (css, href, target) |
Comment on lines
+13
to
+16
| import Tailwind.Breakpoints as Breakpoints | ||
| import Tailwind.Theme as Tw | ||
| import Tailwind.Utilities as Tw | ||
| import Theming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have:
unlike before, this finally matches the actual design and colour schemes of the server!