Skip to content

Add Windows bindings generation support#1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thihup merged 8 commits into from
Jan 16, 2026
Merged

Add Windows bindings generation support #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b453bb
Initial plan
Copilot Jan 15, 2026
6c93548
Add Windows support to bindings build workflow
Copilot Jan 15, 2026
97c2842
Update natives build.gradle to support Windows toolchain
Copilot Jan 15, 2026
f8f161c
Simplify workflow by splitting extract steps
Copilot Jan 15, 2026
d38dbe4
Address code review feedback
Copilot Jan 15, 2026
b26be52
Add explicit permissions to workflow for security
Copilot Jan 15, 2026
8c1c112
Fix Windows jextract download to use tar.gz
Copilot Jan 15, 2026
3bcb1c8
Quote Gradle parameters to fix Windows parsing
Copilot Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 53 additions & 10 deletions .github/workflows/build-and-publish-bindings.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,12 +17,55 @@ on:
required: true
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
include:
- os: ubuntu-latest
jextract_url: https://download.java.net/java/early_access/jextract/25/2/openjdk-25-jextract+2-4_linux-x64_bin.tar.gz
jextract_archive: jdk.tar.gz
os_name: linux
gradle_cmd: ./gradlew
- os: windows-latest
jextract_url: https://download.java.net/java/early_access/jextract/25/2/openjdk-25-jextract+2-4_windows-x64_bin.tar.gz
jextract_archive: jdk.tar.gz
os_name: windows
gradle_cmd: .\gradlew.bat
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- run: wget -O $RUNNER_TEMP/jdk.tar.gz https://download.java.net/java/early_access/jextract/25/2/openjdk-25-jextract+2-4_linux-x64_bin.tar.gz
- run: tar -xf $RUNNER_TEMP/jdk.tar.gz
- run: echo "JEXTRACT_HOME=$(pwd)/jextract-25" >> $GITHUB_ENV

- name: Download jextract (Linux)
if: matrix.os == 'ubuntu-latest'
run: wget -O $RUNNER_TEMP/${{ matrix.jextract_archive }} ${{ matrix.jextract_url }}

- name: Download jextract (Windows)
if: matrix.os == 'windows-latest'
run: |
Invoke-WebRequest -Uri "${{ matrix.jextract_url }}" -OutFile "$env:RUNNER_TEMP\${{ matrix.jextract_archive }}"
shell: pwsh

- name: Extract jextract (Linux)
if: matrix.os == 'ubuntu-latest'
run: tar -xf $RUNNER_TEMP/${{ matrix.jextract_archive }}

- name: Extract jextract (Windows)
if: matrix.os == 'windows-latest'
run: tar -xf $env:RUNNER_TEMP\${{ matrix.jextract_archive }}
shell: pwsh

- name: Set JEXTRACT_HOME (Linux)
if: matrix.os == 'ubuntu-latest'
run: echo "JEXTRACT_HOME=$(pwd)/jextract-25" >> $GITHUB_ENV

- name: Set JEXTRACT_HOME (Windows)
if: matrix.os == 'windows-latest'
run: echo "JEXTRACT_HOME=$((Get-Location).Path)\jextract-25" >> $env:GITHUB_ENV
shell: pwsh

- uses: actions/setup-java@v4
id: install-jdk
with:
Expand All@@ -35,25 +78,25 @@ jobs:
gradle-version: wrapper

- name: Download natives
run: ./gradlew -PwgpuVersion=${{ inputs.wgpuVersion }} :natives:download
run: ${{ matrix.gradle_cmd }} "-PwgpuVersion=${{ inputs.wgpuVersion }}" "-Pos=${{ matrix.os_name }}" :natives:download

CopilotAIJan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -Pos parameter is passed without a corresponding -Ptoolchain parameter for Windows builds. While the Gradle file defaults to 'msvc' when OS is Windows, it would be more explicit and maintainable to pass -Ptoolchain=msvc for Windows builds in the matrix configuration to ensure the correct toolchain is always used.

Copilot uses AI. Check for mistakes.

- name: Extract natives
run: ./gradlew -PwgpuVersion=${{ inputs.wgpuVersion }} :natives:unzip
run: ${{ matrix.gradle_cmd }} "-PwgpuVersion=${{ inputs.wgpuVersion }}" "-Pos=${{ matrix.os_name }}" :natives:unzip

- name: Copy headers
run: ./gradlew -PwgpuVersion=${{ inputs.wgpuVersion }} ':natives:copyWgpuHeaders'
run: ${{ matrix.gradle_cmd }} "-PwgpuVersion=${{ inputs.wgpuVersion }}" "-Pos=${{ matrix.os_name }}" ':natives:copyWgpuHeaders'

- name: Generate bindings
run: ./gradlew -PwgpuVersion=${{ inputs.wgpuVersion }}-Pjextract.home=${{ env.JEXTRACT_HOME }} :lib:bindings
run: ${{ matrix.gradle_cmd }} "-PwgpuVersion=${{ inputs.wgpuVersion }}" "-Pjextract.home=${{ env.JEXTRACT_HOME }}" :lib:bindings

- name: Publish bindings as artifact
uses: actions/upload-artifact@v4
with:
name: webgpu-bindings
name: webgpu-bindings-${{ matrix.os_name }}
path: lib/build/webgpu.jar

- name: Publish bindings to GH packages
run: ./gradlew -PwgpuVersion=${{ inputs.wgpuVersion }} :lib:publish
run: ${{ matrix.gradle_cmd }} "-PwgpuVersion=${{ inputs.wgpuVersion }}" :lib:publish

CopilotAIJan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish step doesn't pass the -Pos parameter unlike other Gradle commands. If the lib:publish task or any of its dependencies rely on the os property from the natives build.gradle, this could cause inconsistencies. Verify whether this is intentional or if the parameter should be included for consistency.

Suggested change
run: ${{ matrix.gradle_cmd }} "-PwgpuVersion=${{ inputs.wgpuVersion }}" :lib:publish
run: ${{ matrix.gradle_cmd }} "-PwgpuVersion=${{ inputs.wgpuVersion }}" "-Pos=${{ matrix.os_name }}" :lib:publish

Copilot uses AI. Check for mistakes.
env:
GITHUB_USER: ${{ github.actor }}
GITHUB_TOKEN: ${{ secrets.PKG_PUBLISHING_AUTH_TOKEN }}
15 changes: 10 additions & 5 deletions natives/build.gradle
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,19 +12,24 @@ def wgpuVersion = project.findProperty('wgpuVersion')
def os = project.hasProperty('os') ? project.findProperty('os') : 'linux'
def arch = project.hasProperty('arch') ? project.findProperty('arch') : 'x86_64'
def type = project.hasProperty('type') ? project.findProperty('type') : 'debug'
def toolchain = project.hasProperty('toolchain') ? project.findProperty('toolchain') : (os == 'windows' ? 'msvc' : null)

CopilotAIJan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic checks project.hasProperty('toolchain') but then calls project.findProperty('toolchain') which can return null even when the property exists but is not set. This could lead to unexpected behavior. Consider using a consistent approach: either check for existence and get the value, or just use findProperty() with a null check.

Suggested change
deftoolchain= project.hasProperty('toolchain') ? project.findProperty('toolchain') : (os =='windows'?'msvc':null)
deftoolchainProperty= project.findProperty('toolchain')
def toolchain = (toolchainProperty !=null) ? toolchainProperty : (os =='windows'?'msvc':null)

Copilot uses AI. Check for mistakes.

// Construct the platform string based on OS
def platformString = (os == 'windows' && toolchain) ? "$os-$arch-$toolchain" : "$os-$arch"
def fileName = "wgpu-$platformString-${type}.zip"

task download(type: Download) {
src "https://github.com/gfx-rs/wgpu-native/releases/download/$wgpuVersion/wgpu-$os-$arch-${type}.zip"
dest "bin/$wgpuVersion/$os-$arch-${type}.zip"
src "https://github.com/gfx-rs/wgpu-native/releases/download/$wgpuVersion/$fileName"
dest "bin/$wgpuVersion/$fileName"
}

task unzip(type: Copy) {
from zipTree("bin/$wgpuVersion/$os-$arch-${type}.zip")
into "bin/$wgpuVersion/$os-$arch-$type"
from zipTree("bin/$wgpuVersion/$fileName")
into "bin/$wgpuVersion/$platformString-$type"
}

task copyWgpuHeaders(type: Copy) {
from "bin/$wgpuVersion/$os-$arch-$type/include/webgpu/webgpu.h"
from "bin/$wgpuVersion/$platformString-$type/include/webgpu/webgpu.h"
into 'build/headers/'
}

Expand Down