Skip to content

Fix: Serial port configuration not applied - #3

Open
sadounlilya wants to merge 1 commit into
ThingSet:mainfrom
sadounlilya:config_correction
Open

Fix: Serial port configuration not applied #3
sadounlilya wants to merge 1 commit into
ThingSet:mainfrom
sadounlilya:config_correction

Conversation

@sadounlilya

Copy link
Copy Markdown

When using the Serial connection with the app, the port configuration was never actually updated meaning all received bytes were corrupted.

It is because the config setter is never triggered and sp_set_config() from the libserialport is never called.

This fix creates a new SerialPortConfig object and assigns it via the setter which will call the sp_set_config() to actually update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant