Skip to content

Vote Command Improvements - #751

Open
tro2 wants to merge 12 commits into
masterfrom
Trodaire/filtering-vote-feedbacks
Open

Vote Command Improvements#751
tro2 wants to merge 12 commits into
masterfrom
Trodaire/filtering-vote-feedbacks

Conversation

@tro2

@tro2tro2 commented Feb 21, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

ViBot [X.X.X]

Changelog

Features

  • Added vote tagging to feedbacks pulled for votes

Changes

  • Reworked vote setup panel to change which feedbacks are included in vote

Quality of Life

  • Changed display of sent votes to show tags and a timestamp

Summary

Overview

  • Added vote tagging and filtering functions to populate the votes with relevant feedbacks
    image
  • Added a panel for an HRL to interact that allows them to choose which feedbacks are displayed on the vote
    image
  • You can add and remove votes
    image
    image
  • You send votes in sequence to the channel the command was run in
    image
  • Added slash command
    image

Huntifer-RotMGand others added 6 commits February 19, 2024 09:02
@Huntifer-RotMG@tro2
Merging Huntifer PR 672 Switch vote to use restart safe interactions;…
0dac5a5
… redis upgrades; legacycommandparser upgrades; and add vote slash command
@tro2
In progress vote changes
02c858a
Renamed voteConfiguration to voteConfig
Added documentation within vote.js
Added feedback type identification and filtering
IN PROGRESS Reworking vote setup interactions
@tro2
Merge branch 'master' into Trodaire/filtering-vote-feedbacks
b15d96a
@tro2
saving progress on vote.js
e913928
work in progress
@tro2
Merge branch 'master' into Trodaire/filtering-vote-feedbacks
3e87302
@tro2
update vote.js
ef1ab33
finalize changes before draft PR
@tro2
tro2 requested a review from a team as a code ownerFebruary 21, 2024 21:08
@tro2tro2 linked an issue Feb 21, 2024 that may be closed by this pull request
Vote Command Improvements #750
Open
4 tasks
@tro2
tro2 marked this pull request as draft February 21, 2024 21:24
@Huntifer-RotMGHuntifer-RotMG mentioned this pull request Feb 21, 2024
Closed
@tro2
TEMP votejs
60729d3
debugging vote progression
@tro2
tro2force-pushed the Trodaire/filtering-vote-feedbacks branch from 4cf49fe to 60729d3CompareFebruary 22, 2024 17:45
@tro2
Merge branch 'master' into Trodaire/filtering-vote-feedbacks
7986b87
@tro2
Finalized vote changes
1a5a6fd
Fixed up display of votes, added functionality to add and remove votes from included list
@tro2
tro2 marked this pull request as ready for review February 23, 2024 09:26
@tro2

tro2 commented Feb 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Ready for review

@tro2tro2 changed the title [DRAFT] Vote Command Improvements[Vote Command ImprovementsFeb 23, 2024
@tro2tro2 changed the title [Vote Command ImprovementsVote Command ImprovementsFeb 23, 2024
husky-rotmgand others added 2 commits February 23, 2024 14:25
husky-rotmg
Merge branch 'master' into Trodaire/filtering-vote-feedbacks
437be4e
@tro2
Updated vote
5eccc86
Changed args to list of users
Fixed a bug with failing to add feedbacks when list length is 0
Changed display of votes to use emojis
ghost
ghost suggested changes Feb 23, 2024
View reviewed changes

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are nitpicks but there are a couple small things that do need addressing first.

Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js Outdated
Comment threadcommands/vote.js
@tro2
Update vote.js
d830ef0
changed votesetup from class to an object with typedef
improved documentation
altered display of unidentified dungeon
@tro2
tro2 requested a review from a userFebruary 24, 2024 00:24
ghost
ghost approved these changes Feb 24, 2024
View reviewed changes

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vote Command Improvements

2 participants

@tro2@Huntifer-RotMG