Skip to content

fix: allow forwarded messages with media in media-only channels - #1419

Merged
christolis merged 4 commits into
Together-Java:developfrom
vlaym:fix/forward-media-to-media-channel
Feb 26, 2026
Merged

fix: allow forwarded messages with media in media-only channels#1419
christolis merged 4 commits into
Together-Java:developfrom
vlaym:fix/forward-media-to-media-channel

Conversation

@vlaym

@vlaymvlaym commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Fixes#1243

Forwarded messages that contain media (attachments, embeds, or links)
were incorrectly deleted in media-only channels, because the bot only
checked the message itself, not its MessageSnapshots.

Changes:

  • Extended messageHasNoMediaAttached() to also check MessageSnapshot contents
  • Extracted hasMedia() helper method for reuse
  • Added tests for forwarded messages with and without media

@vlaym
vlaym requested a review from a team as a code ownerFebruary 23, 2026 13:06
@CLAassistant

CLAassistant commented Feb 23, 2026•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Zabuzard
Zabuzard requested changes Feb 23, 2026
View reviewed changes
Comment thread...cation/src/main/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListener.java Outdated
Comment thread...cation/src/main/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListener.java Outdated
Comment thread...cation/src/main/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListener.java Outdated
Comment thread...on/src/test/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListenerTest.java Outdated
@vlaym
vlaym requested a review from ZabuzardFebruary 23, 2026 16:13
Zabuzard
Zabuzard previously approved these changes Feb 24, 2026
View reviewed changes
@Zabuzard

Zabuzard commented Feb 24, 2026•
edited
Loading

Copy link
Copy Markdown
Member

nice stuff, thanks. just make the CI/CD happy and we can get it merged soon :)

@Zabuzard

Zabuzard commented Feb 24, 2026

Copy link
Copy Markdown
Member

poggers, all green 👍

firasrg
firasrg reviewed Feb 24, 2026
View reviewed changes

@firasrgfirasrg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VlaM5 for the work and the thoughtful solution! Left some comments to help make the PR cleaner, Good luck

Comment thread...cation/src/main/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListener.java
Comment thread...cation/src/main/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListener.java
Comment thread...cation/src/main/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListener.java
Comment thread...cation/src/main/java/org/togetherjava/tjbot/features/mediaonly/MediaOnlyChannelListener.java
christolis
christolis approved these changes Feb 25, 2026
View reviewed changes

@christolischristolis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perfect PR, good job.

@christolis
christolis merged commit 1070f23 into Together-Java:developFeb 26, 2026
9 checks passed
christolis referenced this pull request Feb 28, 2026
@firasrg
Analytics: remove AnalyticsService injection in PingCommand and using…
5002f75
… it from BotCore;
@ZabuzardZabuzard mentioned this pull request Mar 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZabuzardZabuzardZabuzard approved these changes
@firasrgfirasrgfirasrg left review comments
@tj-wazeitj-wazeitj-wazei left review comments
@christolischristolischristolis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to forward messages with images to media channels

6 participants

@vlaym@CLAassistant@Zabuzard@christolis@firasrg@tj-wazei