Skip to content

Added "Mark Active" button to help-thread "inactivity-closed" message - #1423

Merged
Zabuzard merged 9 commits into
Together-Java:developfrom
SleepyStack:develop
Mar 3, 2026
Merged

Added "Mark Active" button to help-thread "inactivity-closed" message#1423
Zabuzard merged 9 commits into
Together-Java:developfrom
SleepyStack:develop

Conversation

@SleepyStack

@SleepyStackSleepyStack commented Mar 1, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#1140

Overview

Added a "Mark Active" button to help threads flagged for inactivity.

Instead of a "Dismiss" button, I put "Mark Active" because it better reflects the user's intent to keep the thread open. When clicked, the bot unarchives the thread and deletes the inactivity warning to keep the history clean.

Changes

  • HelpThreadAutoArchiver.java: Added the button to the inactivity message and updated the embed text to tell users to click it to reopen the thread.
  • HelpThreadCreatedListener.java:
    • Created a small hook in onButtonClick using a new thread-inactivity namespace.
    • This ensures the reactivation logic stays isolated from the existing ChatGPT dismiss button.
    • Added handleMarkActiveInteraction to unarchive the thread and delete the bot's warning message.

Why this approach?

A button is more reliable than a message listener since it bypasses the 14-day deletion limit and doesn't require extra database tracking. It's a simple fix that doesn't mess with the existing thread logic.

@SleepyStack
SleepyStack requested a review from a team as a code ownerMarch 1, 2026 18:22
@CLAassistant

CLAassistant commented Mar 1, 2026•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Zabuzard
Zabuzard requested changes Mar 2, 2026
View reviewed changes
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Zabuzard
Zabuzard requested changes Mar 2, 2026
View reviewed changes

@ZabuzardZabuzard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better now. the component id generator topic needs to be looked into. ill dig a bit to assist better on it and then callback

Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
Zabuzard
Zabuzard requested changes Mar 2, 2026
View reviewed changes
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java Outdated
@SleepyStack
refactor: move thread reactivation logic to HelpThreadAutoArchiver
e92c09d
- Make HelpThreadAutoArchiver implement UserInteractor (name: thread-inactivity)
- Own ComponentIdInteractor for mark-active button ID generation
- Move onButtonClick/onInactivityButton from listener to archiver
- Remove mark-active routing and getComponentIdInteractor from listener
- Remove unused generateMarkActiveId from HelpSystemHelper
- Extract mark-active literal to constant (SonarLint S1192)
Zabuzard
Zabuzard requested changes Mar 2, 2026
View reviewed changes

@ZabuzardZabuzard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the direction is great now. just some smaller cleanup 👍

Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/Features.java Outdated
@SleepyStack

SleepyStack commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

Refactored with the cleanups, looks good to me now 👍🏻

Zabuzard
Zabuzard previously approved these changes Mar 2, 2026
View reviewed changes

@ZabuzardZabuzard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, thanks 👍

@ZabuzardZabuzard changed the title feat(help): add "Mark Active" button to inactivity warningAdded "Mark Active" button to help-thread "inactivity-closed" messageMar 2, 2026
christolis
christolis requested changes Mar 2, 2026
View reviewed changes
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/Features.java Outdated
Comment threadapplication/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java
christolis
christolis approved these changes Mar 3, 2026
View reviewed changes

@christolischristolis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zabuzard
Zabuzard merged commit 9015870 into Together-Java:developMar 3, 2026
9 checks passed
@ZabuzardZabuzard mentioned this pull request Mar 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZabuzardZabuzardZabuzard approved these changes
@christolischristolischristolis approved these changes

Assignees

@SleepyStackSleepyStack

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Question closed due to inactivity" message taking up screen

4 participants

@SleepyStack@CLAassistant@Zabuzard@christolis