updated spotless files

[Taz03]

No description provided.

[marko-radosavljevic]

How did you generate this config? Does it produce the same results as the previous one? Why is it so much shorter? I notice the version is the same, 13, and the current default eclipse config is on version 22 (at 400 lines).

Default config exported from eclipse: (click)

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<profilesversion="22">
<profilekind="CodeFormatterProfile"name="Eclipse [built-in]"version="22">
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_ellipsis"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_enum_declarations"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_allocation_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_for_statment"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.comment.new_lines_at_block_boundaries"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_constructor_declaration_parameters"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.insert_new_line_for_parameter"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_package"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_enum_constant"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_while"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_annotation_type_member_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.format_javadoc_comments"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.indentation.size"value="4"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_enum_constant_declaration"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_semicolon_in_for"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.align_with_spaces"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.continuation_indentation"value="2"/>
<settingid="org.eclipse.jdt.core.formatter.number_of_blank_lines_before_code_block"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_switch_case_expressions"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_after_package"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_multiple_local_declarations"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_enum_constant"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_angle_bracket_in_parameterized_type_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.indent_root_tags"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_or_operator_multicatch"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.enabling_tag"value="@formatter:on"/>
<settingid="org.eclipse.jdt.core.formatter.comment.count_line_length_from_starting_position"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_record_components"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_method_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_parameter"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_multiplicative_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.keep_then_statement_on_same_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_explicitconstructorcall_arguments"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_prefix_operator"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_brace_in_array_initializer"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_angle_bracket_in_type_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_method"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_parameterized_type_references"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_logical_operator"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_parenthesized_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_annotation_declaration_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_record_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_enum_constant"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_multiplicative_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_and_in_type_parameter"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_method_invocation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_assignment_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_type_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_for"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.preserve_white_space_between_code_and_line_comments"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_local_variable"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_abstract_method"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.keep_enum_constant_declaration_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.align_variable_declarations_on_columns"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_method_invocation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_union_type_in_multicatch"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.number_of_blank_lines_at_beginning_of_method_body"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.keep_else_statement_on_same_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_catch_clause"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_parameterized_type_reference"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_array_initializer"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_annotation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_explicit_constructor_call"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_multiplicative_operator"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.keep_anonymous_type_declaration_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_switch_case_expressions"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_shift_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.indent_body_declarations_compare_to_annotation_declaration_header"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_block"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.number_of_blank_lines_at_end_of_code_block"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_bitwise_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.put_empty_statement_on_new_line"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_parameters_in_constructor_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_type_parameters"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_compact_loops"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.comment.clear_blank_lines_in_block_comment"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.keep_simple_for_body_on_same_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_at_end_of_file_if_missing"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_switch_case_arrow_operator"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_array_initializer"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_unary_operator"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.format_line_comment_starting_on_first_column"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_annotation"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_ellipsis"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_semicolon_in_try_resources"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_assert"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_annotations_on_enum_constant"value="49"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_and_in_type_parameter"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_parenthesized_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.text_block_indentation"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.align_type_members_on_columns"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_assignment"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_module_statements"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.indent_body_declarations_compare_to_type_header"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_method_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.align_tags_names_descriptions"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_enum_constant"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_if_then_body_block_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_first_class_body_declaration"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_before_closing_brace_in_array_initializer"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_constructor_declaration_parameters"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.format_guardian_clause_on_one_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_if"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.align_assignment_statements_on_columns"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_permitted_types"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_block_in_case"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_constructor_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_conditional_expression_chain"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.comment.format_header"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_type_annotations"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_allocation_expression"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_assertion_message_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_switch"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_method_declaration"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.align_fields_grouping_blank_lines"value="2147483647"/>
<settingid="org.eclipse.jdt.core.formatter.comment.new_lines_at_javadoc_boundaries"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_bitwise_operator"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_annotation_type_declaration"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_for"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_resources_in_try"value="80"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_selector_in_method_invocation"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.never_indent_block_comments_on_first_column"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_synchronized"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_allocation_expression"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.format_source_code"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_array_initializer"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_field"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_at_in_annotation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_method"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_superclass_in_type_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_parenthesized_expression_in_throw"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_not_operator"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_type_annotation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_brace_in_array_initializer"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_parenthesized_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.format_html"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_at_in_annotation_type_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_method_delcaration"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_compact_if"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.indent_empty_lines"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_type_arguments"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_unary_operator"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_enum_constant"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_annotation"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_enum_declarations"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_annotations_on_package"value="49"/>
<settingid="org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_before_else_in_if_statement"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_assignment_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_label"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.indent_body_declarations_compare_to_enum_declaration_header"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_conditional"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_method_declaration_parameters"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_cast"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_arrow_in_switch_case"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_before_while_in_do_statement"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_bracket_in_array_type_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.indent_body_declarations_compare_to_record_header"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_angle_bracket_in_parameterized_type_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_opening_brace_in_array_initializer"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.indent_breaks_compare_to_cases"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_method_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_bitwise_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_try"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_lambda_arrow"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_method_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.indent_tag_description"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.keep_imple_if_on_one_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_record_constructor"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_enum_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_brackets_in_array_type_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_angle_bracket_in_type_parameters"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_string_concatenation"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_semicolon_in_for"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_bracket_in_array_allocation_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_multiple_fields"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_enum_constant_arguments"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_prefix_operator"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_array_initializer"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_shift_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_method_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_type_parameters"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_catch"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_shift_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_empty_braces_in_array_initializer"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_multiple_local_declarations"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_simple_do_while_body_on_same_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_annotation_type_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_record_components"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_outer_expressions_when_nested"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_closing_paren_in_cast"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_synchronized"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_annotation_type_member_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_expressions_in_for_loop_header"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_additive_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.keep_simple_getter_setter_on_one_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_while"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_angle_bracket_in_type_parameters"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_string_concatenation"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_lambda_arrow"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.join_lines_in_comments"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_record_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_relational_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_multiple_field_declarations"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_between_import_groups"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_at_in_annotation_type_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_logical_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_method_invocation"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_after_imports"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.comment.insert_new_line_before_root_tags"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_record_declaration"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_method_declaration_throws"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_switch_statement"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_postfix_operator"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_for_increments"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_type_arguments"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_arrow_in_switch_default"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_for_inits"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.disabling_tag"value="@formatter:off"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_enum_constants"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_imports"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.number_of_blank_lines_at_end_of_method_body"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_if_while_statement"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_closing_brace_in_block"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_parenthesized_expression_in_return"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_arrow_in_switch_case"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_field"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_between_type_declarations"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.keep_switch_body_block_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_for"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_catch"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_switch"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_anonymous_type_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.never_indent_line_comments_on_first_column"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_for_inits"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.indent_statements_compare_to_block"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_anonymous_type_declaration"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_question_in_wildcard"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_annotation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_method_invocation_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_expressions_in_switch_case_with_arrow"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_switch"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.align_tags_descriptions_grouped"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.comment.line_length"value="80"/>
<settingid="org.eclipse.jdt.core.formatter.use_on_off_tags"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.keep_method_body_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_empty_brackets_in_array_allocation_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_loop_body_block_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_enum_constant"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_method_declaration"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_for"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_type_declaration_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_closing_angle_bracket_in_type_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_additive_operator"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_multiple_field_declarations"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_record_constructor"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_relational_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_superinterfaces"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_record_declaration_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_default"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_question_in_conditional"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_constructor_declaration"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_lambda_body"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.compact_else_if"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_type_parameters"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_catch"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_method_invocation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_invocation_arguments"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_method_invocation"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_before_catch_in_try_statement"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_try"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_annotations_on_parameter"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.comment.clear_blank_lines_in_javadoc_comment"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_relational_operator"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_expressions_in_array_initializer"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.number_of_empty_lines_to_preserve"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_case"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_additive_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_if"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_type_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_string_concatenation"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.format_line_comments"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.align_selector_in_method_invocation_on_expression_first_line"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_record_declaration"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_labeled_statement"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_switch_case_with_arrow_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_expressions_in_switch_case_with_colon"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.number_of_blank_lines_after_code_block"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_superinterfaces_in_type_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_conditional_expression"value="80"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_type"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_annotations_on_type"value="49"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_block"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_annotations_on_local_variable"value="49"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_enum_declaration"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_arrow_in_switch_default"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.insert_new_line_between_different_tags"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_additive_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_method_invocation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_while"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.join_wrapped_lines"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_constructor_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_annotations_on_field"value="49"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_conditional_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_cases"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_bracket_in_array_allocation_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_synchronized"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_shift_operator"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.use_tabs_only_for_leading_indentations"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_try_clause"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.keep_code_block_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_constructor_declaration_throws"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_record_components"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.tabulation.size"value="4"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_bitwise_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_bracket_in_array_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_conditional"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_try"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_semicolon_in_try_resources"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer"value="2"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_question_in_wildcard"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_record_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_superinterfaces_in_enum_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_assignment_operator"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_labeled_statement"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_switch"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_superinterfaces"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_declaration_parameters"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_closing_angle_bracket_in_type_parameters"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_switch_case_with_arrow"value="20"/>
<settingid="org.eclipse.jdt.core.formatter.keep_lambda_body_block_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_annotations_on_method"value="49"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_parameterized_type_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_record_constructor_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_record_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_empty_array_initializer_on_one_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_assertion_message"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_constructor_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_new_chunk"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_bracket_in_array_allocation_expression"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_constructor_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_angle_bracket_in_parameterized_type_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_angle_bracket_in_type_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_assert"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_member_type"value="1"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_logical_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_qualified_allocation_expression"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_superinterfaces_in_record_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_if"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_semicolon"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_relational_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_postfix_operator"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_angle_bracket_in_type_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_cast"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.format_block_comments"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.alignment_for_parameters_in_method_declaration"value="16"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_declaration_throws"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_after_last_class_body_declaration"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.indent_statements_compare_to_body"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.keep_simple_while_body_on_same_line"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_logical_operator"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_between_statement_group_in_switch"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_bracket_in_array_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_annotation"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_enum_constant_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.parentheses_positions_in_lambda_declaration"value="common_lines"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_case"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_permitted_types"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_bracket_in_array_reference"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.keep_enum_declaration_on_one_line"value="one_line_never"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_method_declaration"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_enum_constant"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.brace_position_for_type_declaration"value="end_of_line"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_multiplicative_operator"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.blank_lines_before_package"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_for"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_for_increments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_enum_constant"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_explicitconstructorcall_arguments"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_annotation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.indent_body_declarations_compare_to_enum_constant_header"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_constructor_declaration"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_constructor_declaration_throws"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_closing_angle_bracket_in_type_parameters"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_question_in_conditional"value="insert"/>
<settingid="org.eclipse.jdt.core.formatter.comment.indent_parameter_description"value="false"/>
<settingid="org.eclipse.jdt.core.formatter.number_of_blank_lines_at_beginning_of_code_block"value="0"/>
<settingid="org.eclipse.jdt.core.formatter.insert_new_line_before_finally_in_try_statement"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.tabulation.char"value="tab"/>
<settingid="org.eclipse.jdt.core.formatter.wrap_before_string_concatenation"value="true"/>
<settingid="org.eclipse.jdt.core.formatter.lineSplit"value="120"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_annotation"value="do not insert"/>
<settingid="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_switch"value="insert"/>
</profile>
</profiles>

Diff is difficult to read in github UI, mostly worried about so many deleted lines. So more info would be helpful. ☺️

[Taz03]

How did you generate this config?

manually look each value in docs 💀 and see their default value, if its explicitly being set to the default i remove it.

Does it produce the same results as the previous one?

yes, wait for the bug to fix then it'll run spotless automatically, so u can verify

Why is it so much shorter?

no explicitly setting of default values

the current default eclipse config is on version 22

didn't knew that, will update. is that the latest?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[marko-radosavljevic]

so here we probably want:
value="one_line_never"

same for the constructor, lambda in one line reads better, so I agree with it

[Taz03]

u want record to curly braces opened? wasn't that the whole point of this pr? to close them if empty

[marko-radosavljevic]

The point was to update and fix the config, so we can use the latest version of eclipse jdt formatter.

Because of this issue, we started pinning the version:
#140

And because of the pinning, we didn't have support for newer language features like @snippet:
#591

So we should also check if those issues have been fixed.

---

To keep it consistent with all other constructs and with the current formatting, record declaration and method body should also be closed after a newline. Which should also be the default.

Because, for example, we don't put braced code in one line if empty for: loops, conditionals, switch cases, class and anonymous class declarations, enum and enum constant declarations..

[Taz03]

And because of the pinning, we didn't have support for newer language features like @snippet

we still don't have that, thats a eclipse jdt issue

[marko-radosavljevic]

It's probably a good idea to add all default values at the end of the file, after a comment explaining they are defaults.

Just so defaults do not change randomly without our knowledge, and so it's easier to edit a specific thing without having to read the docs.

[Taz03]

just read the docs

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

[Zabuzard]

@Taz03 why is it failing so many checks? it should automatically use the new config, no? please check, dont want to merge sth that "breaks" the code base and everyones PR.

[Taz03]

@Zabuzard dk isn't reproduce able on my system

[marko-radosavljevic]

@Taz03 Are you still working on this? ^^

There is still one unresolved conversation.

I don't like that we introduced some diffs, but I mostly agree with them (except records and constructors with closed braces in the same line). I think method chaining always on the new line was the intended behavior, like this:

 if (messageHasNoMediaAttached(message)) {
- message.delete().flatMap(any -> dmUser(message)).queue(any -> {- }, failure -> tempNotifyUserInChannel(message));+ message.delete()+ .flatMap(any -> dmUser(message))+ .queue(any -> {}, failure -> tempNotifyUserInChannel(message));
}

It just sometimes didn't work properly with the jda flatmaps and whatnot. So JDT got smarter or something? Just trying to figure out what introduced the diff.

[Taz03]

that is because of this config <setting id="org.eclipse.jdt.core.formatter.keep_lambda_body_block_on_one_line" value="one_line_if_empty"/> in line 75, it wasn't there before

[Taz03]

@Zabuzard do u also agree with keeping records body open (curly braces in different lines)?

[Zabuzard]

i dont mind

[marko-radosavljevic]

that is because of this config <setting id="org.eclipse.jdt.core.formatter.keep_lambda_body_block_on_one_line" value="one_line_if_empty"/> in line 75, it wasn't there before

Ah yeah, now I get it. I agree with that one, makes both lambdas and method chaining easier to read. Thanks ❤️

@Zabuzard do u also agree with keeping records body open (curly braces in different lines)?

It's just for consistency, I don't really mind either. But we introduced unwanted diff, we might have merge conflicts because of it, and I don't even agree with it. To quote myself:

To keep it consistent with all other constructs and with the current formatting, record declaration and method body should also be closed after a newline. Which should also be the default.

Because, for example, we don't put braced code in one line if empty for: loops, conditionals, switch cases, class and anonymous class declarations, enum and enum constant declarations..

So yeah, just keep it like it was, same with constructors. If you feel strongly about it, we can discuss these changes in a separate issue.

[marko-radosavljevic]

After brief testing, it seems that original issue that made us pin the version solved itself? The problem was with our config, but I can no longer reproduce it with the latest JDT version and old formatting xml. I guess it's either zabu's refactor or jdt updates.

Also, just updating the JDT produces new changes with indentation, method chaining (like in this PR) and record closing bracket. With the old config, which is not something I would expect..

Are you sure eclipse defaults are stable and very rarely changing? Because now I'm worried about consistency again. We don't want defaults randomly changing, breaking our build and introducing merge conflicts. Ideally, our formatting always stays the same.

It's probably a good idea to add all default values at the end of the file, after a comment explaining they are defaults.

Just so defaults do not change randomly without our knowledge, and so it's easier to edit a specific thing without having to read the docs.

Trying to understand all the details, so I can document everything, since I'm the only one familiar with all spotless/jdt/formatting history and changes.

[Taz03]

Are you sure eclipse defaults are stable and very rarely changing?

no idea actually but should be, the only to know is to check defaults in last 10-20 versions which i ain't doin

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Taz03]

THIS PR IS OPEN FOR SOMEONE ELSE TO TAKE OVER, OR CLOSE

[Taz03]

do better