Uh oh!
There was an error while loading. Please reload this page.
Feat: card popup window - #26
Open
micwallace wants to merge 7 commits into
Open
Conversation
Open TS viewer window to resolve proxy. This allows us to break out of the extension sandbox.
Open popup in center
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
micwallace
commented
Nov 21, 2024
ContributorAuthor
Note: Please merge recaptcha PR first, since this branch shares code with it. |
micwallaceforce-pushed
the
feat/card-popup-window
branch
from
November 22, 2024 03:10
0d56c9b to
f4a7415Comparemicwallaceforce-pushed
the
feat/card-popup-window
branch
from
November 22, 2024 03:27
0874dbc to
6bff3d4Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@futantan As discussed this adds an option to open tokenscript actions in a popup window rather than an iframe modal.
This speeds up the loading process significantly, since script info and token data can be cached. It also enables local storage support for cards opened this way.
At the moment the default is false, so the extension will continue to work as-is unless the user explicitly turns this feature on via the extension options page.