PR_26171_040 clean Idea Board production copy - #15
Conversation
…ea-board-production-copy-cleanup # Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:acbc5b113e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <p>No project records or mutating API requests are created by this tool surface.</p> | ||
| <p class="status" role="status" data-idea-board-status>Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.</p> | ||
| <p>Use this board to shape ideas and notes before creating a project.</p> | ||
| <p class="status" role="status" data-idea-board-status>Ready to shape ideas and notes.</p> |
There was a problem hiding this comment.
When creators add or edit ideas/notes and then reload or navigate away, those changes are lost because the page still only mutates the in-memory ideaTable/noteTable arrays and does not write to storage or an API. This replacement removes the previous visible "in-page only" warning and presents the board as ready, so users can enter real ideas without knowing they are not saved; keep a creator-safe temporary/unsaved warning here.
Useful? React with 👍 / 👎.
| } | ||
| const SOURCE_CONTROLLED_TOOLBOX_TOOL_IDS = new Set(["game-workspace", "messages", "tags", "text-to-speech", "users"]); | ||
| const SOURCE_CONTROLLED_TOOLBOX_TOOL_IDS = new Set(["game-workspace", "idea-board", "messages", "tags", "text-to-speech", "users"]); |
There was a problem hiding this comment.
Adding idea-board to the source-controlled set makes ensureToolboxToolMetadataRows/supabaseToolboxToolMetadataRows reapply every field listed in SOURCE_CONTROLLED_TOOLBOX_METADATA_FIELDS, including group, path, status, and visibility. In the Admin Tool Votes flow, an admin can still change Idea Board's state/group/path and see a success message, but the next metadata snapshot silently resets those edits to source defaults; if the goal is only to clean stale copy, restrict the source sync to the copy fields instead of locking the whole metadata row.
Useful? React with 👍 / 👎.
| <p>Create Project will be available after an idea is ready.</p> | ||
| <button class="btn primary" type="button" disabled data-idea-board-create-project>Create Project</button> |
There was a problem hiding this comment.
This copy says Create Project becomes available after an idea is ready, but the button remains permanently disabled and the Idea Board script never enables it when an idea's status is changed to Ready to Shape. Creators who mark an idea ready will still be blocked with no explanation, so the copy should not describe a readiness-triggered action unless the enabling behavior is implemented.
Useful? React with 👍 / 👎.
Summary
Validation
node --check toolbox/idea-board/index.jsnode --check src/dev-runtime/server/local-api-router.mjsnode --check src/shared/toolbox/tool-metadata-inventory.jsnode --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjsnode --check tests/playwright/tools/ToolboxRoutePages.spec.mjsnpx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=linenpx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"git diff --checkorigin/mainand resolving report-only conflicts.toolbox/idea-board/index.js, while server-side registry files are advisory WARN as not browser-collected.Artifact
tmp/PR_26171_040-idea-board-production-copy-cleanup_delta.zip