') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); PR_26175_ALFA_051-idea-board-game-hub-row-expectation by ToolboxAid · Pull Request #163 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content

PR_26175_ALFA_051-idea-board-game-hub-row-expectation - #163

Merged
ToolboxAid merged 1 commit into
mainfrom
codex/pr-26175-alfa-051-idea-board-game-hub-row-expectation
Jun 24, 2026
Merged

PR_26175_ALFA_051-idea-board-game-hub-row-expectation#163
ToolboxAid merged 1 commit into
mainfrom
codex/pr-26175-alfa-051-idea-board-game-hub-row-expectation

Conversation

@ToolboxAid

@ToolboxAidToolboxAid commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Aligns the Idea Board cross-flow Game Hub expanded-row expectation with current Game Hub rendering.
  • Expects source-idea and readiness-output rows, removing the stale summary-row assertion from this test path.

Validation

  • PASS: node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
  • PASS: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --workers=1

Package

  • tmp/PR_26175_ALFA_051-idea-board-game-hub-row-expectation_delta.zip

@ToolboxAid
ToolboxAid merged commit 592f217 into mainJun 24, 2026
1 check passed
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Jun 24, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:654cf47afd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread...dev/reports/PR_26175_ALFA_051-idea-board-game-hub-row-expectation_manual-validation-notes.md
@@ -0,0 +1,5 @@
# PR_26175_ALFA_051-idea-board-game-hub-row-expectation Manual Validation Notes

- Confirmed the stale three-row expectation was limited to the Idea Board cross-flow test path.

@chatgpt-codex-connectorchatgpt-codex-connectorBotJun 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct the stale expectation scope claim

This stale three-row expectation is not limited to the Idea Board cross-flow path: tests/playwright/tools/GameHubMockRepository.spec.mjs:571-577 still asserts the same summary/source-idea/readiness-output expanded rows, while the current renderExpandedGameRow only renders source-idea and readiness-output. As written, the report can mark the PR complete while leaving the Game Hub parent/child table lane with the same stale assertion that this change is meant to resolve.

Useful? React with 👍 / 👎.

Comment threaddocs_build/dev/reports/PR_26175_ALFA_051-idea-board-game-hub-row-expectation_report.md
@@ -0,0 +1,14 @@
# PR_26175_ALFA_051-idea-board-game-hub-row-expectation Report

@chatgpt-codex-connectorchatgpt-codex-connectorBotJun 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match the active BUILD source of truth

The repo workflow says the BUILD doc is the source of truth, but at this commit docs_build/dev/BUILD_PR.md still defines PR_26175_ALFA_047-theme-v2-svg-icon-registry with SVG registry targets and validation, while this run adds ALFA_051 reports and changes IdeaBoardTableNotes.spec.mjs instead. In contexts where the BUILD gates are enforced, this work is outside the active exact scope and skips the required validation, so either update the BUILD doc for ALFA_051 or move these changes to the correct build before marking it PASS.

Useful? React with 👍 / 👎.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ToolboxAid