Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
PR_26171_034 style idea board chevrons inline by ToolboxAid · Pull Request #9 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' PR_26171_034 style idea board chevrons inline by ToolboxAid · Pull Request #9 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' PR_26171_034 style idea board chevrons inline by ToolboxAid · Pull Request #9 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' PR_26171_034 style idea board chevrons inline by ToolboxAid · Pull Request #9 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' PR_26171_034 style idea board chevrons inline by ToolboxAid · Pull Request #9 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' PR_26171_034 style idea board chevrons inline by ToolboxAid · Pull Request #9 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); PR_26171_034 style idea board chevrons inline by ToolboxAid · Pull Request #9 · ToolboxAid/HTML-JavaScript-Gaming · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,44 @@ td {
text-transform: none
}

.data-table [data-idea-board-idea-cell] {
cursor: pointer
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
gap: .35em;
color: inherit;
font: inherit;
line-height: inherit;
vertical-align: baseline
}

.idea-board-idea-chevron {
display: inline-block;
width: 1em;
height: 1em;
flex: 0 0 1em;
background: currentColor;
-webkit-mask-position: center;
mask-position: center;
-webkit-mask-repeat: no-repeat;
mask-repeat: no-repeat;
-webkit-mask-size: contain;
mask-size: contain
}

.idea-board-idea-chevron--down {
-webkit-mask-image: url("../images/gfs-chevron-down.svg");
mask-image: url("../images/gfs-chevron-down.svg")
}

.idea-board-idea-chevron--up {
-webkit-mask-image: url("../images/gfs-chevron-up.svg");
mask-image: url("../images/gfs-chevron-up.svg")
}

.tool-form-table {
table-layout: fixed;
width: 100%
Expand Down
36 changes: 31 additions & 5 deletions tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page }) => {
const server = await startRepoServer();
const previousApiUrl = process.env.GAMEFOUNDRY_API_URL;
Expand DownExpand Up@@ -58,15 +84,15 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.getByText("Selected")).toHaveCount(0);

await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] th")).toHaveText("Top Thoughts");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(0)).toHaveText("Smartest person wins...");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(1)).toHaveText("Exploring");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] td").nth(2)).toHaveText("2026-06-20");
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='top-thoughts'] [data-idea-board-idea-action]")).toHaveText(["Edit", "Delete"]);

await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] th")).toHaveText("Sky Orchard");
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-idea-row='sky-orchard'] td").nth(0)).toHaveText("Grow floating islands...");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-idea-row='clockwork-courier'] th")).toHaveText("Clockwork Courier");
Expand All@@ -77,7 +103,7 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts'] [data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.locator("[data-idea-board-notes-table] th[scope='col']", { hasText: "Type" })).toHaveCount(0);
Expand DownExpand Up@@ -113,12 +139,12 @@ test("Idea Board uses DB-shaped accordion table ideas and notes", async ({ page
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toHaveCount(0);
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-up.svg");
await page.locator("[data-idea-board-notes-count='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row='sky-orchard']")).toBeVisible();
await page.locator("[data-idea-board-idea-cell='sky-orchard']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await expect(page.locator("[data-idea-board-chevron='sky-orchard']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "sky-orchard", "gfs-chevron-down.svg");

await page.locator("[data-idea-board-add-idea]").click();
const ideaInputRow = page.locator("[data-idea-board-idea-input-row]").last();
Expand Down
30 changes: 28 additions & 2 deletions tests/playwright/tools/ToolboxRoutePages.spec.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,6 +112,32 @@ function restoreEnvValue(key, value) {
process.env[key] = value;
}

async function expectIdeaChevron(page, ideaId, iconName) {
const metrics = await page.locator(`[data-idea-board-idea-row='${ideaId}'] th`).evaluate((cell, targetIdeaId) => {
const label = cell.querySelector(".idea-board-idea-label");
const icon = cell.querySelector(`[data-idea-board-chevron='${targetIdeaId}']`);
const cellStyles = getComputedStyle(cell);
const labelStyles = getComputedStyle(label);
const iconStyles = getComputedStyle(icon);
return {
iconName: icon.dataset.ideaBoardChevronIcon,
labelDisplay: labelStyles.display,
iconWidth: Number.parseFloat(iconStyles.width),
iconHeight: Number.parseFloat(iconStyles.height),
fontSize: Number.parseFloat(cellStyles.fontSize),
iconColor: iconStyles.backgroundColor,
textColor: cellStyles.color,
maskImage: iconStyles.getPropertyValue("-webkit-mask-image") || iconStyles.maskImage,
};
}, ideaId);
expect(metrics.iconName).toBe(iconName);
expect(metrics.labelDisplay).toBe("inline-flex");
expect(Math.abs(metrics.iconWidth - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(Math.abs(metrics.iconHeight - metrics.fontSize)).toBeLessThanOrEqual(1);
expect(metrics.iconColor).toBe(metrics.textColor);
expect(metrics.maskImage).toContain(iconName);
}

test("tools route aliases render toolbox tool pages", async ({ page }) => {
const server = await startRepoServer();
const failedRequests = [];
Expand DownExpand Up@@ -226,13 +252,13 @@ test("Idea Board launches from Toolbox with accordion table notes model", async
await expect(page.locator("[data-idea-board-notes-count='top-thoughts']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='sky-orchard']")).toHaveText("3 Notes");
await expect(page.locator("[data-idea-board-notes-count='clockwork-courier']")).toHaveText("0 Notes");
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-down\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-down.svg");
await expect(page.locator("[data-idea-board-status]")).toHaveText("Idea Board table edits are in-page only. No project records, auth, AI, or database behavior is connected.");
await page.locator("[data-idea-board-notes-count='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row]")).toHaveCount(0);
await page.locator("[data-idea-board-idea-cell='top-thoughts']").click();
await expect(page.locator("[data-idea-board-expanded-row='top-thoughts']")).toBeVisible();
await expect(page.locator("[data-idea-board-chevron='top-thoughts']")).toHaveAttribute("src", /gfs-chevron-up\.svg$/);
await expectIdeaChevron(page, "top-thoughts", "gfs-chevron-up.svg");
await expect(page.locator("[data-idea-board-notes-header='top-thoughts']")).toHaveText("Notes");
await expect(page.locator("[data-idea-board-notes-table='top-thoughts'] th[scope='col']")).toHaveText(["Note", "Actions"]);
await expect(page.getByText("Notes for Sky Orchard")).toHaveCount(0);
Expand Down
14 changes: 10 additions & 4 deletions toolbox/idea-board/index.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,13 +188,19 @@ function renderIdeaRow(tbody, record) {
idea.setAttribute("aria-expanded", String(expanded));
idea.setAttribute("role", "button");
idea.setAttribute("aria-label", `${expanded ? "Collapse" : "Expand"} notes for ${record.idea}`);
const ideaLabel = document.createElement("span");
ideaLabel.className = "idea-board-idea-label";
const ideaText = document.createElement("span");
ideaText.className = "idea-board-idea-label__text";
ideaText.textContent = record.idea;
const chevron = document.createElement("img");
chevron.alt = "";
const chevron = document.createElement("span");
const chevronIcon = expanded ? "gfs-chevron-up.svg" : "gfs-chevron-down.svg";
chevron.className = `idea-board-idea-chevron idea-board-idea-chevron--${expanded ? "up" : "down"}`;
chevron.setAttribute("aria-hidden", "true");
chevron.dataset.ideaBoardChevron = record.ideaId;
chevron.src = expanded ? "assets/theme-v2/images/gfs-chevron-up.svg" : "assets/theme-v2/images/gfs-chevron-down.svg";
idea.append(ideaText, " ", chevron);
chevron.dataset.ideaBoardChevronIcon = chevronIcon;
ideaLabel.append(ideaText, chevron);
idea.append(ideaLabel);
row.append(idea);
row.append(cell(record.pitch));
row.append(cell(record.status));
Expand Down
Loading